Skip to content

Conversation

@theanarkh
Copy link
Contributor

trace process sync APIs. The example is as follows.

execFileSync('node',['-e','setTimeout(() =>{}, 5000)']);
image
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • tests and/or benchmarks are included
  • documentation is changed or added
  • commit message follows commit guidelines

@nodejs-github-botnodejs-github-bot added c++ Issues and PRs that require attention from people who are familiar with C++. child_process Issues and PRs related to the child_process subsystem. needs-ci PRs that need a full CI run. labels Jul 20, 2023
@gengjiawen
Copy link
Member

Not sure this triggered coverage failure, cc @bcoe

@gengjiawen
Copy link
Member

@nodejs/coverage-admins This is likely a false positive, any idea to fix this ?

@gengjiawengengjiawen added the request-ci Add this label to start a Jenkins CI on a PR. label Jul 25, 2023
@github-actionsgithub-actionsbot removed the request-ci Add this label to start a Jenkins CI on a PR. label Jul 25, 2023
@nodejs-github-bot
Copy link
Collaborator

@theanarkhtheanarkhforce-pushed the trace_process_spawn_sync branch from 14315c7 to 145a4ecCompareOctober 7, 2023 12:22
@theanarkhtheanarkhforce-pushed the trace_process_spawn_sync branch from 145a4ec to 1fc5a98CompareNovember 7, 2023 18:19
@theanarkh
Copy link
ContributorAuthor

@jasnell Hi jasnell, Do you know why coverage checks fail, I haven't seen in other PR 🤔️。

@theanarkhtheanarkhforce-pushed the trace_process_spawn_sync branch from 1fc5a98 to 9ce152bCompareNovember 23, 2023 14:15
@theanarkhtheanarkh reopened this Nov 25, 2023
@theanarkhtheanarkhforce-pushed the trace_process_spawn_sync branch from 9ce152b to 3f69a63CompareFebruary 22, 2024 16:33
@aduh95aduh95force-pushed the trace_process_spawn_sync branch from 3f69a63 to 2b662d9CompareMay 11, 2024 14:14
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

c++Issues and PRs that require attention from people who are familiar with C++.child_processIssues and PRs related to the child_process subsystem.needs-ciPRs that need a full CI run.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants

@theanarkh@gengjiawen@nodejs-github-bot@jasnell