Uh oh!
There was an error while loading. Please reload this page.
- Notifications
You must be signed in to change notification settings - Fork 34.2k
test: add tmpdir.fileURL()#49040
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
test: add tmpdir.fileURL()#49040
Uh oh!
There was an error while loading. Please reload this page.
Conversation
LiviaMedeiros commented Aug 6, 2023 • edited
Loading Uh oh!
There was an error while loading. Please reload this page.
edited
Uh oh!
There was an error while loading. Please reload this page.
tniessen commented Aug 6, 2023
Why is the URL not a |
LiviaMedeiros commented Aug 6, 2023
For consistency with |
tniessen commented Aug 6, 2023
I see. For anyone else wondering the same thing, it sounds like the main issue is that |
aduh95 commented Aug 8, 2023
We could have |
joyeecheung commented Aug 8, 2023
Considering we also already have |
1dbf437 to 0e08b72Compare This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
nodejs-github-bot commented Aug 10, 2023
nodejs-github-bot commented Aug 10, 2023
Landed in 7bbcb29 |
PR-URL: nodejs#49040 Reviewed-By: Antoine du Hamel <[email protected]> Reviewed-By: Joyee Cheung <[email protected]>
PR-URL: nodejs#49040 Reviewed-By: Antoine du Hamel <[email protected]> Reviewed-By: Joyee Cheung <[email protected]>
PR-URL: nodejs#49040 Reviewed-By: Antoine du Hamel <[email protected]> Reviewed-By: Joyee Cheung <[email protected]>
PR-URL: #49040 Reviewed-By: Antoine du Hamel <[email protected]> Reviewed-By: Joyee Cheung <[email protected]>
PR-URL: nodejs#49040 Reviewed-By: Antoine du Hamel <[email protected]> Reviewed-By: Joyee Cheung <[email protected]>
PR-URL: nodejs#49040 Reviewed-By: Antoine du Hamel <[email protected]> Reviewed-By: Joyee Cheung <[email protected]>
PR-URL: #49040 Reviewed-By: Antoine du Hamel <[email protected]> Reviewed-By: Joyee Cheung <[email protected]>
PR-URL: #49138 Refs: #49040 Reviewed-By: Luigi Pinca <[email protected]>
PR-URL: #49138 Refs: #49040 Reviewed-By: Luigi Pinca <[email protected]>
PR-URL: nodejs#49040 Reviewed-By: Antoine du Hamel <[email protected]> Reviewed-By: Joyee Cheung <[email protected]>
PR-URL: #49040 Backport-PR-URL: #50669 Reviewed-By: Antoine du Hamel <[email protected]> Reviewed-By: Joyee Cheung <[email protected]>
PR-URL: #49138 Refs: #49040 Reviewed-By: Luigi Pinca <[email protected]>
PR-URL: nodejs/node#49040 Backport-PR-URL: nodejs/node#50669 Reviewed-By: Antoine du Hamel <[email protected]> Reviewed-By: Joyee Cheung <[email protected]>
PR-URL: nodejs/node#49138 Refs: nodejs/node#49040 Reviewed-By: Luigi Pinca <[email protected]>
PR-URL: nodejs/node#49040 Backport-PR-URL: nodejs/node#50669 Reviewed-By: Antoine du Hamel <[email protected]> Reviewed-By: Joyee Cheung <[email protected]>
PR-URL: nodejs/node#49138 Refs: nodejs/node#49040 Reviewed-By: Luigi Pinca <[email protected]>
Almost every time
tmpdir.pathis used in tests, we have to importpathto use it.Whenever we need
URLof something in tmpdir, we also have to importurl.pathToFileURL.Adding
tmpdir.urlwould reduceto
or to native resolving
Additionally, maybe we could add path-oriented
tmpdir.resolve(...paths)to replacepath.join(tmpdir.path, ...paths)in tests?