Uh oh!
There was an error while loading. Please reload this page.
- Notifications
You must be signed in to change notification settings - Fork 34.3k
esm: fix globalPreload warning#49069
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Uh oh!
There was an error while loading. Please reload this page.
Conversation
nodejs-github-bot commented Aug 8, 2023
Review requested:
|
GeoffreyBooth commented Aug 8, 2023
No, we need to keep the language about it being removed in a future version. |
aduh95 commented Aug 8, 2023
Why? |
GeoffreyBooth commented Aug 8, 2023
Because it's stronger. It means you must refactor, it's not just a recommendation. They should know that this is coming. |
JakobJingleheimer commented Aug 8, 2023
I agree that the existing verbiage is better than the proposal because we're pretty darn sure upgrading is required (whereas the proposal makes it sound like merely a better option). |
aduh95 commented Aug 8, 2023
Well we plan to remove it, but we can't know for sure if we are definitely going to remove it.
Surely you don't mean that, the current warning is not correct English. |
GeoffreyBooth commented Aug 8, 2023
I assume he means that the gist of the current warning is better than the proposed alternative. As in, just fix the grammar error without changing the intent of what we're trying to say. |
JakobJingleheimer commented Aug 8, 2023
Yes, the minor typographic error aside, the current is better information for the user. I think it would be better to correct the current message. |
aduh95 commented Aug 8, 2023
What would be your suggestion? |
Uh oh!
There was an error while loading. Please reload this page.
nodejs-github-bot commented Aug 10, 2023
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
nodejs-github-bot commented Aug 13, 2023
nodejs-github-bot commented Aug 13, 2023
Landed in b5da2f4 |
PR-URL: nodejs#49069Fixes: nodejs#49026 Reviewed-By: Chemi Atlow <[email protected]> Reviewed-By: Jacob Smith <[email protected]>
PR-URL: #49069Fixes: #49026 Reviewed-By: Chemi Atlow <[email protected]> Reviewed-By: Jacob Smith <[email protected]>
PR-URL: nodejs#49069Fixes: nodejs#49026 Reviewed-By: Chemi Atlow <[email protected]> Reviewed-By: Jacob Smith <[email protected]>
PR-URL: nodejs#49069Fixes: nodejs#49026 Reviewed-By: Chemi Atlow <[email protected]> Reviewed-By: Jacob Smith <[email protected]>
PR-URL: #49069Fixes: #49026 Reviewed-By: Chemi Atlow <[email protected]> Reviewed-By: Jacob Smith <[email protected]>
PR-URL: #49069Fixes: #49026 Reviewed-By: Chemi Atlow <[email protected]> Reviewed-By: Jacob Smith <[email protected]>
PR-URL: nodejs#49069Fixes: nodejs#49026 Reviewed-By: Chemi Atlow <[email protected]> Reviewed-By: Jacob Smith <[email protected]>
PR-URL: #49069 Backport-PR-URL: #50669Fixes: #49026 Reviewed-By: Chemi Atlow <[email protected]> Reviewed-By: Jacob Smith <[email protected]>
PR-URL: nodejs/node#49069 Backport-PR-URL: nodejs/node#50669Fixes: nodejs/node#49026 Reviewed-By: Chemi Atlow <[email protected]> Reviewed-By: Jacob Smith <[email protected]>
PR-URL: nodejs/node#49069 Backport-PR-URL: nodejs/node#50669Fixes: nodejs/node#49026 Reviewed-By: Chemi Atlow <[email protected]> Reviewed-By: Jacob Smith <[email protected]>
Fixes: #49026
Before:
After: