Skip to content

Conversation

@aduh95
Copy link
Contributor

Fixes: #49026

Before:

(node:9201) ExperimentalWarning: `globalPreload` will be removed in a future version. Please use `initialize` instead. is an experimental feature and might change at any time 

After:

(node:34642) ExperimentalWarning: It is recommended to use `initialize` instead of `globalPreload`, which is an experimental feature and might change at any time 

@nodejs-github-bot
Copy link
Collaborator

Review requested:

  • @nodejs/loaders
  • @nodejs/modules

@aduh95aduh95 added the request-ci Add this label to start a Jenkins CI on a PR. label Aug 8, 2023
@nodejs-github-botnodejs-github-bot added esm Issues and PRs related to the ECMAScript Modules implementation. needs-ci PRs that need a full CI run. labels Aug 8, 2023
@GeoffreyBooth
Copy link
Member

No, we need to keep the language about it being removed in a future version.

@aduh95
Copy link
ContributorAuthor

No, we need to keep the language about it being removed in a future version.

Why?

@GeoffreyBooth
Copy link
Member

Because it's stronger. It means you must refactor, it's not just a recommendation. They should know that this is coming.

@JakobJingleheimer
Copy link
Member

I agree that the existing verbiage is better than the proposal because we're pretty darn sure upgrading is required (whereas the proposal makes it sound like merely a better option).

@aduh95
Copy link
ContributorAuthor

Well we plan to remove it, but we can't know for sure if we are definitely going to remove it.

I agree that the existing verbiage is better than the proposal

Surely you don't mean that, the current warning is not correct English.

@GeoffreyBooth
Copy link
Member

Surely you don't mean that, the current warning is not correct English.

I assume he means that the gist of the current warning is better than the proposed alternative. As in, just fix the grammar error without changing the intent of what we're trying to say.

@JakobJingleheimer
Copy link
Member

Surely you don't mean that, the current warning is not correct English.

I assume he means that the gist of the current warning is better than the proposed alternative. As in, just fix the grammar error without changing the intent of what we're trying to say.

Yes, the minor typographic error aside, the current is better information for the user. I think it would be better to correct the current message.

@aduh95
Copy link
ContributorAuthor

Surely you don't mean that, the current warning is not correct English.

I assume he means that the gist of the current warning is better than the proposed alternative. As in, just fix the grammar error without changing the intent of what we're trying to say.

Yes, the minor typographic error aside, the current is better information for the user. I think it would be better to correct the current message.

What would be your suggestion?

@github-actionsgithub-actionsbot removed the request-ci Add this label to start a Jenkins CI on a PR. label Aug 10, 2023
@nodejs-github-bot
Copy link
Collaborator

@aduh95aduh95 added author ready PRs that have at least one approval, no pending requests for changes, and a CI started. request-ci Add this label to start a Jenkins CI on a PR. labels Aug 13, 2023
@github-actionsgithub-actionsbot removed the request-ci Add this label to start a Jenkins CI on a PR. label Aug 13, 2023
@nodejs-github-bot
Copy link
Collaborator

@aduh95aduh95 added the commit-queue Add this label to land a pull request using GitHub Actions. label Aug 13, 2023
@aduh95aduh95 added the commit-queue-squash Add this label to instruct the Commit Queue to squash all the PR commits into the first one. label Aug 13, 2023
@nodejs-github-botnodejs-github-bot removed the commit-queue Add this label to land a pull request using GitHub Actions. label Aug 13, 2023
@nodejs-github-botnodejs-github-bot merged commit b5da2f4 into nodejs:mainAug 13, 2023
@nodejs-github-bot
Copy link
Collaborator

Landed in b5da2f4

@aduh95aduh95 deleted the globalPreload-warning branch August 13, 2023 14:54
Ceres6 pushed a commit to Ceres6/node that referenced this pull request Aug 14, 2023
PR-URL: nodejs#49069Fixes: nodejs#49026 Reviewed-By: Chemi Atlow <[email protected]> Reviewed-By: Jacob Smith <[email protected]>
RafaelGSS pushed a commit that referenced this pull request Aug 15, 2023
PR-URL: #49069Fixes: #49026 Reviewed-By: Chemi Atlow <[email protected]> Reviewed-By: Jacob Smith <[email protected]>
@UlisesGasconUlisesGascon mentioned this pull request Aug 15, 2023
RafaelGSS pushed a commit to RafaelGSS/node that referenced this pull request Aug 15, 2023
PR-URL: nodejs#49069Fixes: nodejs#49026 Reviewed-By: Chemi Atlow <[email protected]> Reviewed-By: Jacob Smith <[email protected]>
rluvaton pushed a commit to rluvaton/node that referenced this pull request Aug 15, 2023
PR-URL: nodejs#49069Fixes: nodejs#49026 Reviewed-By: Chemi Atlow <[email protected]> Reviewed-By: Jacob Smith <[email protected]>
RafaelGSS pushed a commit that referenced this pull request Aug 16, 2023
PR-URL: #49069Fixes: #49026 Reviewed-By: Chemi Atlow <[email protected]> Reviewed-By: Jacob Smith <[email protected]>
RafaelGSS pushed a commit that referenced this pull request Aug 17, 2023
PR-URL: #49069Fixes: #49026 Reviewed-By: Chemi Atlow <[email protected]> Reviewed-By: Jacob Smith <[email protected]>
targos pushed a commit to targos/node that referenced this pull request Nov 11, 2023
PR-URL: nodejs#49069Fixes: nodejs#49026 Reviewed-By: Chemi Atlow <[email protected]> Reviewed-By: Jacob Smith <[email protected]>
targos pushed a commit that referenced this pull request Nov 23, 2023
PR-URL: #49069 Backport-PR-URL: #50669Fixes: #49026 Reviewed-By: Chemi Atlow <[email protected]> Reviewed-By: Jacob Smith <[email protected]>
@targostargos mentioned this pull request Nov 28, 2023
sercher added a commit to sercher/graaljs that referenced this pull request Apr 25, 2024
PR-URL: nodejs/node#49069 Backport-PR-URL: nodejs/node#50669Fixes: nodejs/node#49026 Reviewed-By: Chemi Atlow <[email protected]> Reviewed-By: Jacob Smith <[email protected]>
sercher added a commit to sercher/graaljs that referenced this pull request Apr 25, 2024
PR-URL: nodejs/node#49069 Backport-PR-URL: nodejs/node#50669Fixes: nodejs/node#49026 Reviewed-By: Chemi Atlow <[email protected]> Reviewed-By: Jacob Smith <[email protected]>
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

author readyPRs that have at least one approval, no pending requests for changes, and a CI started.commit-queue-squashAdd this label to instruct the Commit Queue to squash all the PR commits into the first one.esmIssues and PRs related to the ECMAScript Modules implementation.needs-ciPRs that need a full CI run.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

loaders: globalPreload warning is incorrect

6 participants

@aduh95@nodejs-github-bot@GeoffreyBooth@JakobJingleheimer@atlowChemi@targos