Skip to content

src: use exact return value for uv_os_getenv#49149

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
nodejs-github-bot merged 1 commit into from
Sep 30, 2023
Merged

src: use exact return value for uv_os_getenv#49149

nodejs-github-bot merged 1 commit into from
Sep 30, 2023

Conversation

@anonrig
Copy link
Member

@anonriganonrig commented Aug 13, 2023

uv_os_getenv returns 0 for happy path.

@nodejs-github-botnodejs-github-bot added c++ Issues and PRs that require attention from people who are familiar with C++. needs-ci PRs that need a full CI run. labels Aug 13, 2023
@anonriganonrig added the request-ci Add this label to start a Jenkins CI on a PR. label Aug 13, 2023
@github-actionsgithub-actionsbot removed the request-ci Add this label to start a Jenkins CI on a PR. label Aug 13, 2023
@nodejs-github-bot
Copy link
Collaborator

nodejs-github-bot commented Aug 13, 2023

CI: https://ci.nodejs.org/job/node-test-pull-request/53292/

@github-actionsgithub-actionsbot mentioned this pull request Aug 15, 2023
Open
22 tasks
@nodejs-github-bot
Copy link
Collaborator

nodejs-github-bot commented Aug 15, 2023

CI: https://ci.nodejs.org/job/node-test-pull-request/53361/

@github-actionsgithub-actionsbot mentioned this pull request Aug 16, 2023
Open
24 tasks
@joyeecheungjoyeecheung mentioned this pull request Aug 16, 2023
Merged
This was referenced Aug 17, 2023
Open
Open
@anonriganonrig added the author ready PRs that have at least one approval, no pending requests for changes, and a CI started. label Aug 29, 2023
@nodejs-github-bot
Copy link
Collaborator

nodejs-github-bot commented Aug 29, 2023

CI: https://ci.nodejs.org/job/node-test-pull-request/53625/

@anonriganonrig added the request-ci Add this label to start a Jenkins CI on a PR. label Sep 27, 2023
@github-actionsgithub-actionsbot removed the request-ci Add this label to start a Jenkins CI on a PR. label Sep 27, 2023
@nodejs-github-bot
Copy link
Collaborator

nodejs-github-bot commented Sep 27, 2023

CI: https://ci.nodejs.org/job/node-test-pull-request/54285/

@aduh95aduh95 added the commit-queue Add this label to land a pull request using GitHub Actions. label Sep 30, 2023
@nodejs-github-botnodejs-github-bot removed the commit-queue Add this label to land a pull request using GitHub Actions. label Sep 30, 2023
@nodejs-github-botnodejs-github-bot merged commit b903a71 into nodejs:mainSep 30, 2023
@nodejs-github-bot
Copy link
Collaborator

nodejs-github-bot commented Sep 30, 2023

Landed in b903a71

GeoffreyBooth pushed a commit to GeoffreyBooth/node that referenced this pull request Oct 1, 2023
@anonrig@GeoffreyBooth
src: use exact return value for uv_os_getenv
43428e7
PR-URL: nodejs#49149 Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: Stephen Belanger <[email protected]>
@RafaelGSSRafaelGSS mentioned this pull request Oct 9, 2023
Merged
alexfernandez pushed a commit to alexfernandez/node that referenced this pull request Nov 1, 2023
@anonrig@alexfernandez
src: use exact return value for uv_os_getenv
8d0e0c0
PR-URL: nodejs#49149 Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: Stephen Belanger <[email protected]>
targos pushed a commit that referenced this pull request Nov 11, 2023
@anonrig@targos
src: use exact return value for uv_os_getenv
5131fde
PR-URL: #49149 Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: Stephen Belanger <[email protected]>
@targostargos mentioned this pull request Nov 12, 2023
Merged
@juanarboljuanarbol mentioned this pull request Dec 6, 2023
Merged
debadree25 pushed a commit to debadree25/node that referenced this pull request Apr 15, 2024
@anonrig@debadree25
src: use exact return value for uv_os_getenv
8dc9233
PR-URL: nodejs#49149 Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: Stephen Belanger <[email protected]>
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@QardQardQard approved these changes

@lpincalpincalpinca approved these changes

Assignees

No one assigned

Labels

author readyPRs that have at least one approval, no pending requests for changes, and a CI started.c++Issues and PRs that require attention from people who are familiar with C++.needs-ciPRs that need a full CI run.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@anonrig@nodejs-github-bot@Qard@lpinca@aduh95