Skip to content

Conversation

@aduh95
Copy link
Contributor

--loader is an undocumented flag, the rest of the docs uses --experimental-loader to design that flag (--loader was kept as an undocumented alias to avoid a breaking change).

@aduh95aduh95 added doc Issues and PRs related to the documentations. fast-track PRs that do not need to wait for 48 hours to land. labels Aug 14, 2023
@nodejs-github-bot
Copy link
Collaborator

Review requested:

  • @nodejs/loaders
  • @nodejs/modules

@github-actions
Copy link
Contributor

Fast-track has been requested by @aduh95. Please 👍 to approve.

@nodejs-github-botnodejs-github-bot added the esm Issues and PRs related to the ECMAScript Modules implementation. label Aug 14, 2023
@debadree25debadree25 added the author ready PRs that have at least one approval, no pending requests for changes, and a CI started. label Aug 14, 2023
@debadree25debadree25 added the commit-queue Add this label to land a pull request using GitHub Actions. label Aug 14, 2023
@nodejs-github-botnodejs-github-bot removed the commit-queue Add this label to land a pull request using GitHub Actions. label Aug 14, 2023
@nodejs-github-botnodejs-github-bot merged commit 52b3007 into nodejs:mainAug 14, 2023
@nodejs-github-bot
Copy link
Collaborator

Landed in 52b3007

@aduh95aduh95 deleted the undocumented-flag branch August 14, 2023 13:13
Ceres6 pushed a commit to Ceres6/node that referenced this pull request Aug 14, 2023
PR-URL: nodejs#49158 Reviewed-By: Debadree Chatterjee <[email protected]> Reviewed-By: Jacob Smith <[email protected]> Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: Michaël Zasso <[email protected]>
RafaelGSS pushed a commit that referenced this pull request Aug 15, 2023
PR-URL: #49158 Reviewed-By: Debadree Chatterjee <[email protected]> Reviewed-By: Jacob Smith <[email protected]> Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: Michaël Zasso <[email protected]>
@UlisesGasconUlisesGascon mentioned this pull request Aug 15, 2023
RafaelGSS pushed a commit to RafaelGSS/node that referenced this pull request Aug 15, 2023
PR-URL: nodejs#49158 Reviewed-By: Debadree Chatterjee <[email protected]> Reviewed-By: Jacob Smith <[email protected]> Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: Michaël Zasso <[email protected]>
rluvaton pushed a commit to rluvaton/node that referenced this pull request Aug 15, 2023
PR-URL: nodejs#49158 Reviewed-By: Debadree Chatterjee <[email protected]> Reviewed-By: Jacob Smith <[email protected]> Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: Michaël Zasso <[email protected]>
RafaelGSS pushed a commit that referenced this pull request Aug 16, 2023
PR-URL: #49158 Reviewed-By: Debadree Chatterjee <[email protected]> Reviewed-By: Jacob Smith <[email protected]> Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: Michaël Zasso <[email protected]>
RafaelGSS pushed a commit that referenced this pull request Aug 17, 2023
PR-URL: #49158 Reviewed-By: Debadree Chatterjee <[email protected]> Reviewed-By: Jacob Smith <[email protected]> Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: Michaël Zasso <[email protected]>
targos pushed a commit to targos/node that referenced this pull request Nov 11, 2023
PR-URL: nodejs#49158 Reviewed-By: Debadree Chatterjee <[email protected]> Reviewed-By: Jacob Smith <[email protected]> Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: Michaël Zasso <[email protected]>
targos pushed a commit that referenced this pull request Nov 23, 2023
PR-URL: #49158 Backport-PR-URL: #50669 Reviewed-By: Debadree Chatterjee <[email protected]> Reviewed-By: Jacob Smith <[email protected]> Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: Michaël Zasso <[email protected]>
@targostargos mentioned this pull request Nov 28, 2023
sercher added a commit to sercher/graaljs that referenced this pull request Apr 25, 2024
PR-URL: nodejs/node#49158 Backport-PR-URL: nodejs/node#50669 Reviewed-By: Debadree Chatterjee <[email protected]> Reviewed-By: Jacob Smith <[email protected]> Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: Michaël Zasso <[email protected]>
sercher added a commit to sercher/graaljs that referenced this pull request Apr 25, 2024
PR-URL: nodejs/node#49158 Backport-PR-URL: nodejs/node#50669 Reviewed-By: Debadree Chatterjee <[email protected]> Reviewed-By: Jacob Smith <[email protected]> Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: Michaël Zasso <[email protected]>
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

author readyPRs that have at least one approval, no pending requests for changes, and a CI started.docIssues and PRs related to the documentations.esmIssues and PRs related to the ECMAScript Modules implementation.fast-trackPRs that do not need to wait for 48 hours to land.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants

@aduh95@nodejs-github-bot@lpinca@targos@JakobJingleheimer@debadree25