doc: caveat unavailability of import.meta.resolve in custom loaders#49242
Uh oh!
There was an error while loading. Please reload this page.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Collaborator
nodejs-github-bot commented Aug 19, 2023
Review requested:
|
nodejs-github-bot added doc 
JakobJingleheimer added the fast-track 
Contributor
Fast-track has been requested by @JakobJingleheimer. Please 👍 to approve. |
aduh95 approved these changes Aug 19, 2023
Contributor
aduh95 commented Aug 19, 2023
Can you fix the linter error please? |
MemberAuthor
JakobJingleheimer commented Aug 19, 2023
Gah, friggin line-wrap. It's fixed |
GeoffreyBooth approved these changes Aug 19, 2023
aduh95 added author ready nodejs-github-bot removed the commit-queue Collaborator
nodejs-github-bot commented Aug 19, 2023
Landed in 41a3a1d |
JakobJingleheimer deleted the doc/add-loader-caveat-to-import-meta-resolve- branch UlisesGascon pushed a commit that referenced this pull request Sep 10, 2023
PR-URL: #49242 Reviewed-By: Antoine du Hamel <[email protected]> Reviewed-By: Geoffrey Booth <[email protected]>
Merged
targos pushed a commit to targos/node that referenced this pull request Nov 11, 2023
PR-URL: nodejs#49242 Reviewed-By: Antoine du Hamel <[email protected]> Reviewed-By: Geoffrey Booth <[email protected]>
targos pushed a commit that referenced this pull request Nov 23, 2023
PR-URL: #49242 Backport-PR-URL: #50669 Reviewed-By: Antoine du Hamel <[email protected]> Reviewed-By: Geoffrey Booth <[email protected]>
sercher added a commit to sercher/graaljs that referenced this pull request Apr 25, 2024
PR-URL: nodejs/node#49242 Backport-PR-URL: nodejs/node#50669 Reviewed-By: Antoine du Hamel <[email protected]> Reviewed-By: Geoffrey Booth <[email protected]>
sercher added a commit to sercher/graaljs that referenced this pull request Apr 25, 2024
PR-URL: nodejs/node#49242 Backport-PR-URL: nodejs/node#50669 Reviewed-By: Antoine du Hamel <[email protected]> Reviewed-By: Geoffrey Booth <[email protected]>
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
closes#49198