Skip to content

src: remove unused function GetName() in node_perf#49244

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
nodejs-github-bot merged 2 commits into from
Aug 21, 2023
Merged

src: remove unused function GetName() in node_perf #49244

nodejs-github-bot merged 2 commits into from
Aug 21, 2023

Conversation

@pluris
Copy link
Contributor

@plurispluris commented Aug 19, 2023•
edited
Loading

I looked through the code, but couldn't find where GetName() is used.
Both test and build passed, I think it can be deleted.

@nodejs-github-botnodejs-github-bot added c++ Issues and PRs that require attention from people who are familiar with C++. needs-ci PRs that need a full CI run. labels Aug 19, 2023
aduh95
aduh95 reviewed Aug 19, 2023
View reviewed changes
@plurispluris requested a review from aduh95August 19, 2023 16:58
@aduh95aduh95 added the request-ci Add this label to start a Jenkins CI on a PR. label Aug 20, 2023
@github-actionsgithub-actionsbot removed the request-ci Add this label to start a Jenkins CI on a PR. label Aug 20, 2023
@nodejs-github-bot
Copy link
Collaborator

nodejs-github-bot commented Aug 20, 2023

CI: https://ci.nodejs.org/job/node-test-pull-request/53450/

@nodejs-github-bot
Copy link
Collaborator

nodejs-github-bot commented Aug 20, 2023

CI: https://ci.nodejs.org/job/node-test-pull-request/53453/

@aduh95aduh95 added the author ready PRs that have at least one approval, no pending requests for changes, and a CI started. label Aug 20, 2023
@deokjinkimdeokjinkim added commit-queue-squash Add this label to instruct the Commit Queue to squash all the PR commits into the first one. commit-queue Add this label to land a pull request using GitHub Actions. labels Aug 20, 2023
@github-actionsgithub-actionsbot mentioned this pull request Aug 21, 2023
Open
35 tasks
@nodejs-github-botnodejs-github-bot removed the commit-queue Add this label to land a pull request using GitHub Actions. label Aug 21, 2023
@nodejs-github-botnodejs-github-bot merged commit a16b610 into nodejs:mainAug 21, 2023
@nodejs-github-bot
Copy link
Collaborator

nodejs-github-bot commented Aug 21, 2023

Landed in a16b610

This was referenced Aug 22, 2023
Open
Open
Open
@plurispluris deleted the remove/unused_function branch August 30, 2023 16:12
UlisesGascon pushed a commit that referenced this pull request Sep 10, 2023
@UlisesGascon
src: remove unused function GetName() in node_perf
dc09286
PR-URL: #49244 Reviewed-By: Antoine du Hamel <[email protected]> Reviewed-By: Deokjin Kim <[email protected]>
@UlisesGasconUlisesGascon mentioned this pull request Sep 10, 2023
Merged
targos pushed a commit that referenced this pull request Nov 27, 2023
@targos
src: remove unused function GetName() in node_perf
066d9d4
PR-URL: #49244 Reviewed-By: Antoine du Hamel <[email protected]> Reviewed-By: Deokjin Kim <[email protected]>
@targostargos mentioned this pull request Nov 28, 2023
Merged
sercher added a commit to sercher/graaljs that referenced this pull request Apr 25, 2024
@sercher
src: remove unused function GetName() in node_perf
df883b8
PR-URL: nodejs/node#49244 Reviewed-By: Antoine du Hamel <[email protected]> Reviewed-By: Deokjin Kim <[email protected]>
sercher added a commit to sercher/graaljs that referenced this pull request Apr 25, 2024
@sercher
src: remove unused function GetName() in node_perf
a28f870
PR-URL: nodejs/node#49244 Reviewed-By: Antoine du Hamel <[email protected]> Reviewed-By: Deokjin Kim <[email protected]>
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@deokjinkimdeokjinkimdeokjinkim approved these changes

@aduh95aduh95aduh95 approved these changes

Assignees

No one assigned

Labels

author readyPRs that have at least one approval, no pending requests for changes, and a CI started.c++Issues and PRs that require attention from people who are familiar with C++.commit-queue-squashAdd this label to instruct the Commit Queue to squash all the PR commits into the first one.needs-ciPRs that need a full CI run.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@pluris@nodejs-github-bot@deokjinkim@aduh95