test: make test-worker-prof more robust#49274
Merged
Uh oh!
There was an error while loading. Please reload this page.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
nodejs-github-bot added needs-ci 
joyeecheungforce-pushed the worker-prof-test branch from 097acb3 to c5d821dCompare
MemberAuthor
Stress test on Windows 2022 + VS 2019 https://ci.nodejs.org/job/node-stress-single-test/418/ |
github-actionsbot removed the request-ci 
Collaborator
nodejs-github-bot commented Aug 22, 2023
joyeecheungforce-pushed the worker-prof-test branch from c5d821d to d966328CompareMemberAuthor
joyeecheung commented Aug 22, 2023
Looks like it can still be flaky with the current workload. Switching to a time-based workload... |
github-actionsbot removed the request-ci Collaborator
nodejs-github-bot commented Aug 22, 2023
27 tasks
Collaborator
nodejs-github-bot commented Aug 23, 2023
MemberAuthor
joyeecheung commented Aug 23, 2023
Another stress test on more platforms: https://ci.nodejs.org/job/node-stress-single-test/420/ |
This was referenced Aug 24, 2023
MemberAuthor
joyeecheung commented Aug 25, 2023
Updated the workload a bit, this seems to guarantee ~1000 ticks on both the parent and the worker. |
joyeecheungforce-pushed the worker-prof-test branch from 7779fab to 5c66341Comparegithub-actionsbot removed the request-ci Collaborator
nodejs-github-bot commented Aug 25, 2023
MemberAuthor
joyeecheung commented Aug 25, 2023
Another stress test: https://ci.nodejs.org/job/node-stress-single-test/422/ |
This was referenced Aug 26, 2023
Collaborator
nodejs-github-bot commented Aug 27, 2023
Collaborator
nodejs-github-bot commented Aug 27, 2023
25 tasks
Use a JS workload instead of repeating FS operations and use a timer to make it less flaky on machines with little resources.
joyeecheungforce-pushed the worker-prof-test branch from 5c66341 to 0d3a6f2CompareMemberAuthor
joyeecheung commented Aug 28, 2023
Looks like the CI is having trouble rebasing the PR. Manually rebased instead. |
Collaborator
nodejs-github-bot commented Aug 28, 2023
This was referenced Aug 29, 2023
github-actionsbot removed the request-ci Collaborator
nodejs-github-bot commented Aug 30, 2023
18 tasks
Collaborator
nodejs-github-bot commented Aug 31, 2023
20 tasks
Collaborator
nodejs-github-bot commented Sep 1, 2023
22 tasks
Collaborator
nodejs-github-bot commented Sep 2, 2023
This was referenced Sep 3, 2023
benjamingr approved these changes Sep 4, 2023
joyeecheung added the commit-queue nodejs-github-bot removed the commit-queue Collaborator
nodejs-github-bot commented Sep 4, 2023
Landed in 7f001c2 |
This was referenced Sep 5, 2023
ruyadorno pushed a commit that referenced this pull request Sep 28, 2023
Use a JS workload instead of repeating FS operations and use a timer to make it less flaky on machines with little resources. PR-URL: #49274 Refs: #26401 Refs: nodejs/reliability#640 Reviewed-By: Benjamin Gruenbaum <[email protected]>
alexfernandez pushed a commit to alexfernandez/node that referenced this pull request Nov 1, 2023
Use a JS workload instead of repeating FS operations and use a timer to make it less flaky on machines with little resources. PR-URL: nodejs#49274 Refs: nodejs#26401 Refs: nodejs/reliability#640 Reviewed-By: Benjamin Gruenbaum <[email protected]>
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Use a JS workload instead of repeating FS operations to make it less flaky on machines with little resources.
Refs: #26401
Refs: nodejs/reliability#640