Skip to content

Conversation

@deokjinkim
Copy link
Contributor

@deokjinkimdeokjinkim commented Aug 23, 2023

Remove redundant code by moving it to outside of if/else. Plus, make options optional in doc.

Below code is duplicated because it exists on both if and else.

 const{readableStreamCancel, } = require('internal/webstreams/readablestream'); this[kRef](); this.once('close', () =>{readableStreamCancel(readable)}); 

And options param is optional like below.

 /** * @typedef{import('../webstreams/readablestream').ReadableStream * } ReadableStream * @param{{* type?: string; * }} [options] * @returns{ReadableStream} */ readableWebStream(options = kEmptyObject){

Remove redundant code by moving it to outside of `if/else`. Plus, make `options` optional in doc.
@nodejs-github-botnodejs-github-bot added fs Issues and PRs related to the fs subsystem / file system. needs-ci PRs that need a full CI run. labels Aug 23, 2023
Copy link
Member

@debadree25debadree25 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks 😄

@debadree25debadree25 added author ready PRs that have at least one approval, no pending requests for changes, and a CI started. request-ci Add this label to start a Jenkins CI on a PR. labels Aug 24, 2023
@github-actionsgithub-actionsbot removed the request-ci Add this label to start a Jenkins CI on a PR. label Aug 24, 2023
@nodejs-github-bot
Copy link
Collaborator

@deokjinkimdeokjinkim added the commit-queue Add this label to land a pull request using GitHub Actions. label Aug 24, 2023
@nodejs-github-botnodejs-github-bot removed the commit-queue Add this label to land a pull request using GitHub Actions. label Aug 25, 2023
@nodejs-github-botnodejs-github-bot merged commit c5cad08 into nodejs:mainAug 25, 2023
@nodejs-github-bot
Copy link
Collaborator

Landed in c5cad08

UlisesGascon pushed a commit that referenced this pull request Sep 10, 2023
Remove redundant code by moving it to outside of `if/else`. Plus, make `options` optional in doc. PR-URL: #49298 Reviewed-By: Debadree Chatterjee <[email protected]> Reviewed-By: Luigi Pinca <[email protected]>
@UlisesGasconUlisesGascon mentioned this pull request Sep 10, 2023
alexfernandez pushed a commit to alexfernandez/node that referenced this pull request Nov 1, 2023
Remove redundant code by moving it to outside of `if/else`. Plus, make `options` optional in doc. PR-URL: nodejs#49298 Reviewed-By: Debadree Chatterjee <[email protected]> Reviewed-By: Luigi Pinca <[email protected]>
targos pushed a commit that referenced this pull request Nov 27, 2023
Remove redundant code by moving it to outside of `if/else`. Plus, make `options` optional in doc. PR-URL: #49298 Reviewed-By: Debadree Chatterjee <[email protected]> Reviewed-By: Luigi Pinca <[email protected]>
@targostargos mentioned this pull request Nov 28, 2023
sercher added a commit to sercher/graaljs that referenced this pull request Apr 25, 2024
Remove redundant code by moving it to outside of `if/else`. Plus, make `options` optional in doc. PR-URL: nodejs/node#49298 Reviewed-By: Debadree Chatterjee <[email protected]> Reviewed-By: Luigi Pinca <[email protected]>
sercher added a commit to sercher/graaljs that referenced this pull request Apr 25, 2024
Remove redundant code by moving it to outside of `if/else`. Plus, make `options` optional in doc. PR-URL: nodejs/node#49298 Reviewed-By: Debadree Chatterjee <[email protected]> Reviewed-By: Luigi Pinca <[email protected]>
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

author readyPRs that have at least one approval, no pending requests for changes, and a CI started.fsIssues and PRs related to the fs subsystem / file system.needs-ciPRs that need a full CI run.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants

@deokjinkim@nodejs-github-bot@lpinca@debadree25