dgram: scope redeclared variables

[Trott]

A few variables in lib/dgram.js are redeclared with var in a scope
where they have already been declared. These instances can be scoped
more narrowly with const, so that's what this change does.

[Trott]

CI: https://ci.nodejs.org/job/node-test-pull-request/1426/

[jasnell]

LGTM
lts-watch label applied

[cjihrig]

LGTM

[Trott]

Landed in 1800bf4

[MylesBorins]

@Trott this commit relies on a semver minor change 137f53c#diff-5c0ca4f44209cc4cc68c4dccadbd4a07

would you be able to manually back port it?

[Trott]

@thealphanerd It applies cleanly for me against de0e293 on the v4.x-staging branch. Or is the problem not that it doesn't apply cleanly but that it breaks once it's applied?

[MylesBorins]

@Trott have you updated the branch? How are you landing it? git am is blowing up for me

https://gist.github.com/6c9069bd7457291af1cb

[Trott]

It's working for me like this:

$ git fetch upstream && git rebase upstream/v4.x-staging && git checkout -b test-for-myles && curl -L https://github.com/nodejs/node/pull/4940.patch | git am remote: Counting objects: 5, done. remote: Compressing objects: 100% (1/1), done. remote: Total 5 (delta 4), reused 5 (delta 4), pack-reused 0 Unpacking objects: 100% (5/5), done. From github.com:nodejs/node a99111a..0242c87 v4.x-staging -> upstream/v4.x-staging First, rewinding head to replay your work on top of it... Fast-forwarded v4.x-staging to upstream/v4.x-staging. Switched to a new branch 'test-for-myles' % Total % Received % Xferd Average Speed Time Time Time Current Dload Upload Total Spent Left Speed 100 138 0 138 0 0 269 0 --:--:-- --:--:-- --:--:-- 270 0 0 0 1805 0 0 1776 0 --:--:-- 0:00:01 --:--:-- 1762k Applying: dgram: scope redeclared variables $