meta: remove modules team from CODEOWNERS#49412
Merged
Uh oh!
There was an error while loading. Please reload this page.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
benjamingr added the meta Uh oh!
There was an error while loading. Please reload this page.
GeoffreyBooth approved these changes Aug 30, 2023
richardlau approved these changes Aug 30, 2023
Member
ljharb commented Aug 30, 2023
The modules team is inactive but we very much use the github team for notifications; I can be added to the loaders team but i usually don't want those notifications. |
Collaborator
nodejs-github-bot commented Aug 30, 2023
Review requested:
|
anonrig approved these changes Aug 30, 2023
RafaelGSS approved these changes Aug 30, 2023
lpinca approved these changes Aug 31, 2023
JakobJingleheimer approved these changes Sep 1, 2023
GeoffreyBooth added the commit-queue 
nodejs-github-bot removed the commit-queue Collaborator
nodejs-github-bot commented Sep 1, 2023
Commit Queue failed- Loading data for nodejs/node/pull/49412 ✔ Done loading data for nodejs/node/pull/49412 ----------------------------------- PR info ------------------------------------ Title meta: remove modules team from CODEOWNERS (#49412) Author Benjamin Gruenbaum (@benjamingr) Branch benjamingr:benjamingr-patch-1 -> nodejs:main Labels meta Commits 1 - meta: remove modules team from CODEOWNERS Committers 1 - GitHub PR-URL: https://github.com/nodejs/node/pull/49412 Reviewed-By: Geoffrey Booth Reviewed-By: Richard Lau Reviewed-By: Yagiz Nizipli Reviewed-By: Rafael Gonzaga Reviewed-By: Luigi Pinca Reviewed-By: Jacob Smith ------------------------------ Generated metadata ------------------------------ PR-URL: https://github.com/nodejs/node/pull/49412 Reviewed-By: Geoffrey Booth Reviewed-By: Richard Lau Reviewed-By: Yagiz Nizipli Reviewed-By: Rafael Gonzaga Reviewed-By: Luigi Pinca Reviewed-By: Jacob Smith -------------------------------------------------------------------------------- ℹ This PR was created on Wed, 30 Aug 2023 16:31:29 GMT ✔ Approvals: 6 ✔ - Geoffrey Booth (@GeoffreyBooth) (TSC): https://github.com/nodejs/node/pull/49412#pullrequestreview-1603111038 ✔ - Richard Lau (@richardlau) (TSC): https://github.com/nodejs/node/pull/49412#pullrequestreview-1603111317 ✔ - Yagiz Nizipli (@anonrig) (TSC): https://github.com/nodejs/node/pull/49412#pullrequestreview-1603163118 ✔ - Rafael Gonzaga (@RafaelGSS) (TSC): https://github.com/nodejs/node/pull/49412#pullrequestreview-1603483216 ✔ - Luigi Pinca (@lpinca): https://github.com/nodejs/node/pull/49412#pullrequestreview-1605620553 ✔ - Jacob Smith (@JakobJingleheimer): https://github.com/nodejs/node/pull/49412#pullrequestreview-1607301198 ✘ Last GitHub CI failed ℹ Green GitHub CI is sufficient -------------------------------------------------------------------------------- ✔ Aborted `git node land` session in /home/runner/work/node/node/.ncuhttps://github.com/nodejs/node/actions/runs/6052223823 |
nodejs-github-bot added the commit-queue-failed 
Currently the modules team is inactive and the loaders team functions as the team in charge of these files/areas. cc @nodejs/modules in case anyone wants to join the @nodejs/loaders team since the modules may be removed.
GeoffreyBoothforce-pushed the benjamingr-patch-1 branch from 6d33054 to 14929d6CompareGeoffreyBooth added commit-queue nodejs-github-bot added commit-queue-failed Collaborator
nodejs-github-bot commented Sep 1, 2023
Commit Queue failed- Loading data for nodejs/node/pull/49412 ✔ Done loading data for nodejs/node/pull/49412 ----------------------------------- PR info ------------------------------------ Title meta: remove modules team from CODEOWNERS (#49412) Author Benjamin Gruenbaum (@benjamingr) Branch benjamingr:benjamingr-patch-1 -> nodejs:main Labels meta Commits 1 - meta: remove modules team from CODEOWNERS Committers 1 - Geoffrey Booth PR-URL: https://github.com/nodejs/node/pull/49412 Reviewed-By: Geoffrey Booth Reviewed-By: Richard Lau Reviewed-By: Yagiz Nizipli Reviewed-By: Rafael Gonzaga Reviewed-By: Luigi Pinca Reviewed-By: Jacob Smith ------------------------------ Generated metadata ------------------------------ PR-URL: https://github.com/nodejs/node/pull/49412 Reviewed-By: Geoffrey Booth Reviewed-By: Richard Lau Reviewed-By: Yagiz Nizipli Reviewed-By: Rafael Gonzaga Reviewed-By: Luigi Pinca Reviewed-By: Jacob Smith -------------------------------------------------------------------------------- ⚠ Commits were pushed since the last approving review: ⚠ - meta: remove modules team from CODEOWNERS ℹ This PR was created on Wed, 30 Aug 2023 16:31:29 GMT ✔ Approvals: 6 ✔ - Geoffrey Booth (@GeoffreyBooth) (TSC): https://github.com/nodejs/node/pull/49412#pullrequestreview-1603111038 ✔ - Richard Lau (@richardlau) (TSC): https://github.com/nodejs/node/pull/49412#pullrequestreview-1603111317 ✔ - Yagiz Nizipli (@anonrig) (TSC): https://github.com/nodejs/node/pull/49412#pullrequestreview-1603163118 ✔ - Rafael Gonzaga (@RafaelGSS) (TSC): https://github.com/nodejs/node/pull/49412#pullrequestreview-1603483216 ✔ - Luigi Pinca (@lpinca): https://github.com/nodejs/node/pull/49412#pullrequestreview-1605620553 ✔ - Jacob Smith (@JakobJingleheimer): https://github.com/nodejs/node/pull/49412#pullrequestreview-1607301198 ✔ Last GitHub CI successful ℹ Green GitHub CI is sufficient -------------------------------------------------------------------------------- ✔ Aborted `git node land` session in /home/runner/work/node/node/.ncuhttps://github.com/nodejs/node/actions/runs/6052969025 |
GeoffreyBooth approved these changes Sep 1, 2023
GeoffreyBooth added commit-queue nodejs-github-bot removed the commit-queue Collaborator
nodejs-github-bot commented Sep 1, 2023
Landed in 12ee988 |
UlisesGascon pushed a commit that referenced this pull request Sep 10, 2023
Currently the modules team is inactive and the loaders team functions as the team in charge of these files/areas. cc @nodejs/modules in case anyone wants to join the @nodejs/loaders team since the modules may be removed. PR-URL: #49412 Reviewed-By: Geoffrey Booth <[email protected]> Reviewed-By: Richard Lau <[email protected]> Reviewed-By: Yagiz Nizipli <[email protected]> Reviewed-By: Rafael Gonzaga <[email protected]> Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: Jacob Smith <[email protected]>
Merged
alexfernandez pushed a commit to alexfernandez/node that referenced this pull request Nov 1, 2023
Currently the modules team is inactive and the loaders team functions as the team in charge of these files/areas. cc @nodejs/modules in case anyone wants to join the @nodejs/loaders team since the modules may be removed. PR-URL: nodejs#49412 Reviewed-By: Geoffrey Booth <[email protected]> Reviewed-By: Richard Lau <[email protected]> Reviewed-By: Yagiz Nizipli <[email protected]> Reviewed-By: Rafael Gonzaga <[email protected]> Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: Jacob Smith <[email protected]>
targos pushed a commit that referenced this pull request Nov 27, 2023
Currently the modules team is inactive and the loaders team functions as the team in charge of these files/areas. cc @nodejs/modules in case anyone wants to join the @nodejs/loaders team since the modules may be removed. PR-URL: #49412 Reviewed-By: Geoffrey Booth <[email protected]> Reviewed-By: Richard Lau <[email protected]> Reviewed-By: Yagiz Nizipli <[email protected]> Reviewed-By: Rafael Gonzaga <[email protected]> Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: Jacob Smith <[email protected]>
sercher added a commit to sercher/graaljs that referenced this pull request Apr 25, 2024
Currently the modules team is inactive and the loaders team functions as the team in charge of these files/areas. cc @nodejs/modules in case anyone wants to join the @nodejs/loaders team since the modules may be removed. PR-URL: nodejs/node#49412 Reviewed-By: Geoffrey Booth <[email protected]> Reviewed-By: Richard Lau <[email protected]> Reviewed-By: Yagiz Nizipli <[email protected]> Reviewed-By: Rafael Gonzaga <[email protected]> Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: Jacob Smith <[email protected]>
sercher added a commit to sercher/graaljs that referenced this pull request Apr 25, 2024
Currently the modules team is inactive and the loaders team functions as the team in charge of these files/areas. cc @nodejs/modules in case anyone wants to join the @nodejs/loaders team since the modules may be removed. PR-URL: nodejs/node#49412 Reviewed-By: Geoffrey Booth <[email protected]> Reviewed-By: Richard Lau <[email protected]> Reviewed-By: Yagiz Nizipli <[email protected]> Reviewed-By: Rafael Gonzaga <[email protected]> Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: Jacob Smith <[email protected]>
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Currently the modules team is inactive and the loaders team functions as the team in charge of these files/areas.
cc @nodejs/modules in case anyone wants to join the @nodejs/loaders team since the modules may be removed.