test: make test-dotenv-node-options locale-independent#49470
Merged
Uh oh!
There was an error while loading. Please reload this page.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
nodejs-github-bot added needs-ci 
github-actionsbot removed the request-ci 
Collaborator
nodejs-github-bot commented Sep 3, 2023
atlowChemi approved these changes Sep 4, 2023
Collaborator
nodejs-github-bot commented Sep 4, 2023
atlowChemi added the author ready 
lpinca approved these changes Sep 4, 2023
lpinca added the commit-queue nodejs-github-bot removed the commit-queue Collaborator
nodejs-github-bot commented Sep 7, 2023
Landed in f0ebb77 |
ruyadorno pushed a commit that referenced this pull request Sep 28, 2023
PR-URL: #49470 Reviewed-By: Chemi Atlow <[email protected]> Reviewed-By: Luigi Pinca <[email protected]>
alexfernandez pushed a commit to alexfernandez/node that referenced this pull request Nov 1, 2023
PR-URL: nodejs#49470 Reviewed-By: Chemi Atlow <[email protected]> Reviewed-By: Luigi Pinca <[email protected]>
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Note: I've tried to add
LANG=CorLC_ALL=Ctotest/fixtures/dotenv/node-options.envand it didn't help. Settingprocess.env.LANG = 'C'in main process helps. Not sure if it's bug or feature.