test: increase coverage of Module.register and initialize hook#49532
Uh oh!
There was an error while loading. Please reload this page.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
nodejs-github-bot added esm ContributorAuthor
aduh95 commented Sep 7, 2023
/cc @nodejs/loaders |
Member
GeoffreyBooth commented Sep 7, 2023
How does this relate to #49529? |
GeoffreyBooth approved these changes Sep 7, 2023
aduh95 added author ready ContributorAuthor
aduh95 commented Sep 7, 2023
Hum both PRs are dealing with the same |
github-actionsbot removed the request-ci Member
GeoffreyBooth commented Sep 7, 2023
As in, none of these tests involve the That’s fine, I was just hoping that they weren’t in conflict, and it sounds like they aren’t. |
Collaborator
nodejs-github-bot commented Sep 7, 2023
ContributorAuthor
aduh95 commented Sep 7, 2023
They probably are in conflict, they are modifying the same lines in the test, for unrelated reasons. |
github-actionsbot removed the request-ci Collaborator
nodejs-github-bot commented Sep 9, 2023
19 tasks
Collaborator
nodejs-github-bot commented Sep 10, 2023
anonrig approved these changes Sep 10, 2023
Collaborator
nodejs-github-bot commented Sep 10, 2023
GeoffreyBooth added commit-queue nodejs-github-bot removed the commit-queue Collaborator
nodejs-github-bot commented Sep 10, 2023
Landed in c159b90 |
This was referenced Sep 11, 2023
This was referenced Sep 13, 2023
ruyadorno pushed a commit that referenced this pull request Sep 28, 2023
PR-URL: #49532 Reviewed-By: Geoffrey Booth <[email protected]> Reviewed-By: Yagiz Nizipli <[email protected]>
alexfernandez pushed a commit to alexfernandez/node that referenced this pull request Nov 1, 2023
PR-URL: nodejs#49532 Reviewed-By: Geoffrey Booth <[email protected]> Reviewed-By: Yagiz Nizipli <[email protected]>
targos pushed a commit to targos/node that referenced this pull request Nov 11, 2023
PR-URL: nodejs#49532 Reviewed-By: Geoffrey Booth <[email protected]> Reviewed-By: Yagiz Nizipli <[email protected]>
targos pushed a commit that referenced this pull request Nov 23, 2023
PR-URL: #49532 Backport-PR-URL: #50669 Reviewed-By: Geoffrey Booth <[email protected]> Reviewed-By: Yagiz Nizipli <[email protected]>
sercher added a commit to sercher/graaljs that referenced this pull request Apr 25, 2024
PR-URL: nodejs/node#49532 Backport-PR-URL: nodejs/node#50669 Reviewed-By: Geoffrey Booth <[email protected]> Reviewed-By: Yagiz Nizipli <[email protected]>
sercher added a commit to sercher/graaljs that referenced this pull request Apr 25, 2024
PR-URL: nodejs/node#49532 Backport-PR-URL: nodejs/node#50669 Reviewed-By: Geoffrey Booth <[email protected]> Reviewed-By: Yagiz Nizipli <[email protected]>
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I recommend reviewing with whitespaces turned off.