esm: isolate globalPreload#49545
Merged
esm: isolate globalPreload #49545
Uh oh!
There was an error while loading. Please reload this page.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
GeoffreyBooth added esm 
Collaborator
nodejs-github-bot commented Sep 7, 2023
Review requested:
|
GeoffreyBoothforce-pushed the isolate-globalpreload branch from ddff9d9 to 53a714bCompare
aduh95 reviewed Sep 8, 2023
Uh oh!
There was an error while loading. Please reload this page.
aduh95 reviewed Sep 8, 2023
Contributor
aduh95 left a comment
aduh95 left a comment There was a problem hiding this comment.
I would recommend doing a test-only PR and leave the lib/ changes as they hardly have anything to do with globalPreload, and are so small anyway that it will pollute git blame without helping much in case of conflicts.
test/fixtures/es-module-loaders/loader-this-value-inside-hook-functions.mjs Outdated Show resolvedHide resolved
Uh oh!
There was an error while loading. Please reload this page.
aduh95 reviewed Sep 8, 2023
Uh oh!
There was an error while loading. Please reload this page.
aduh95 requested changes Sep 8, 2023
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
aduh95force-pushed the isolate-globalpreload branch from 2998e47 to a1d13f2Compareaduh95 approved these changes Sep 8, 2023
aduh95 added author ready 
github-actionsbot removed the request-ci Collaborator
nodejs-github-bot commented Sep 8, 2023
Collaborator
nodejs-github-bot commented Sep 8, 2023
Collaborator
nodejs-github-bot commented Sep 9, 2023
GeoffreyBooth added commit-queue 
JakobJingleheimer approved these changes Sep 9, 2023
nodejs-github-bot removed the commit-queue Collaborator
nodejs-github-bot commented Sep 9, 2023
Landed in 479a50c |
ruyadorno pushed a commit that referenced this pull request Sep 28, 2023
PR-URL: #49545 Reviewed-By: Antoine du Hamel <[email protected]> Reviewed-By: Jacob Smith <[email protected]>
Closed
Merged
alexfernandez pushed a commit to alexfernandez/node that referenced this pull request Nov 1, 2023
PR-URL: nodejs#49545 Reviewed-By: Antoine du Hamel <[email protected]> Reviewed-By: Jacob Smith <[email protected]>
targos pushed a commit to targos/node that referenced this pull request Nov 11, 2023
PR-URL: nodejs#49545 Reviewed-By: Antoine du Hamel <[email protected]> Reviewed-By: Jacob Smith <[email protected]>
targos pushed a commit that referenced this pull request Nov 23, 2023
PR-URL: #49545 Backport-PR-URL: #50669 Reviewed-By: Antoine du Hamel <[email protected]> Reviewed-By: Jacob Smith <[email protected]>
sercher added a commit to sercher/graaljs that referenced this pull request Apr 25, 2024
PR-URL: nodejs/node#49545 Backport-PR-URL: nodejs/node#50669 Reviewed-By: Antoine du Hamel <[email protected]> Reviewed-By: Jacob Smith <[email protected]>
sercher added a commit to sercher/graaljs that referenced this pull request Apr 25, 2024
PR-URL: nodejs/node#49545 Backport-PR-URL: nodejs/node#50669 Reviewed-By: Antoine du Hamel <[email protected]> Reviewed-By: Jacob Smith <[email protected]>
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
From #49144 (comment), this PR minimizes the changes in #49144 so that if an extended period goes by before it gets backported, the potential for conflicts is as reduced as possible. The idea is that this can be merged now, without breaking anyone; and #49144 can be merged on
mainbut not backported for a while, which might cause difficulties backporting later PRs but hopefully such conflicts will be fewer because of the changes in this PR. @nodejs/loadersI left one test in
test-esm-loader-hooks.mjsbecause I expect that to remain (but change) after #49144, because presumably we’ll want to emit some kind of warning or error indefinitely when this hook is defined.