test: use setImmediate() in test-heapdump-shadowrealm.js#49573
Merged
Uh oh!
There was an error while loading. Please reload this page.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
With a tight loop the GC may not have enough time to kick in. Try setImmediate() instead.
nodejs-github-bot added needs-ci 
MemberAuthor
joyeecheung commented Sep 9, 2023
I am not sure if stress test work on debian and fedora boxes, but here it is https://ci.nodejs.org/job/node-stress-single-test/424/ |
github-actionsbot removed the request-ci 
Collaborator
nodejs-github-bot commented Sep 9, 2023
lpinca approved these changes Sep 11, 2023
legendecas approved these changes Sep 11, 2023
joyeecheung added the commit-queue nodejs-github-bot removed the commit-queue Collaborator
nodejs-github-bot commented Sep 11, 2023
Landed in dca4d84 |
ruyadorno pushed a commit that referenced this pull request Sep 28, 2023
With a tight loop the GC may not have enough time to kick in. Try setImmediate() instead. PR-URL: #49573 Refs: #49572 Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: Chengzhong Wu <[email protected]>
alexfernandez pushed a commit to alexfernandez/node that referenced this pull request Nov 1, 2023
With a tight loop the GC may not have enough time to kick in. Try setImmediate() instead. PR-URL: nodejs#49573 Refs: nodejs#49572 Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: Chengzhong Wu <[email protected]>
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
With a tight loop the GC may not have enough time to kick in. Try setImmediate() instead.
Refs: #49572