[v18.x backport] fs, stream: initial Symbol.dispose and Symbol.asyncDispose support#49598
Uh oh!
There was an error while loading. Please reload this page.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Co-authored-by: Benjamin Gruenbaum <[email protected]> PR-URL: nodejs#48518 Reviewed-By: Robert Nagy <[email protected]> Reviewed-By: Erick Wendel <[email protected]> Reviewed-By: Yagiz Nizipli <[email protected]> Reviewed-By: Matteo Collina <[email protected]>
Collaborator
nodejs-github-bot commented Sep 11, 2023
Review requested:
|
nodejs-github-bot added lib / src Merged
github-actionsbot removed the request-ci Collaborator
nodejs-github-bot commented Sep 11, 2023
ruyadorno approved these changes Sep 11, 2023
ruyadorno pushed a commit that referenced this pull request Sep 11, 2023
Co-authored-by: Benjamin Gruenbaum <[email protected]> PR-URL: #48518 Backport-PR-URL: #49598 Reviewed-By: Robert Nagy <[email protected]> Reviewed-By: Erick Wendel <[email protected]> Reviewed-By: Yagiz Nizipli <[email protected]> Reviewed-By: Matteo Collina <[email protected]>
Member
ruyadorno commented Sep 11, 2023
Landed in 6747721 |
ruyadorno pushed a commit that referenced this pull request Sep 13, 2023
Co-authored-by: Benjamin Gruenbaum <[email protected]> PR-URL: #48518 Backport-PR-URL: #49598 Reviewed-By: Robert Nagy <[email protected]> Reviewed-By: Erick Wendel <[email protected]> Reviewed-By: Yagiz Nizipli <[email protected]> Reviewed-By: Matteo Collina <[email protected]>
ruyadorno pushed a commit that referenced this pull request Sep 17, 2023
Co-authored-by: Benjamin Gruenbaum <[email protected]> PR-URL: #48518 Backport-PR-URL: #49598 Reviewed-By: Robert Nagy <[email protected]> Reviewed-By: Erick Wendel <[email protected]> Reviewed-By: Yagiz Nizipli <[email protected]> Reviewed-By: Matteo Collina <[email protected]>
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR-URL: #48518
Reviewed-By: Robert Nagy [email protected]
Reviewed-By: Erick Wendel [email protected]
Reviewed-By: Yagiz Nizipli [email protected]
Reviewed-By: Matteo Collina [email protected]