module: refactor redeclared variable#4962
Closed
Uh oh!
There was an error while loading. Please reload this page.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
`homedir` was declared with `var` twice in the same scope in `lib/module.js`. This change makes it a single declaration.
Trott added module 
Contributor
mscdex commented Jan 30, 2016
LGTM |
MemberAuthor
Trott commented Jan 30, 2016
Member
JungMinu commented Jan 30, 2016
LGTM |
r-52 pushed a commit that referenced this pull request Jan 31, 2016
`homedir` was declared with `var` twice in the same scope in `lib/module.js`. This change makes it a single declaration. PR-URL: #4962 Reviewed-By: Brian White <[email protected]> Reviewed-By: Minwoo Jung <[email protected]> Reviewed-By: Roman Klauke <[email protected]>
Contributor
r-52 commented Jan 31, 2016
Thanks! Landed in 0c113e8 |
rvagg pushed a commit that referenced this pull request Feb 8, 2016
`homedir` was declared with `var` twice in the same scope in `lib/module.js`. This change makes it a single declaration. PR-URL: #4962 Reviewed-By: Brian White <[email protected]> Reviewed-By: Minwoo Jung <[email protected]> Reviewed-By: Roman Klauke <[email protected]>
MylesBorins pushed a commit that referenced this pull request Feb 17, 2016
`homedir` was declared with `var` twice in the same scope in `lib/module.js`. This change makes it a single declaration. PR-URL: #4962 Reviewed-By: Brian White <[email protected]> Reviewed-By: Minwoo Jung <[email protected]> Reviewed-By: Roman Klauke <[email protected]>
MylesBorins pushed a commit that referenced this pull request Feb 18, 2016
`homedir` was declared with `var` twice in the same scope in `lib/module.js`. This change makes it a single declaration. PR-URL: #4962 Reviewed-By: Brian White <[email protected]> Reviewed-By: Minwoo Jung <[email protected]> Reviewed-By: Roman Klauke <[email protected]>
Merged
MylesBorins pushed a commit that referenced this pull request Mar 2, 2016
`homedir` was declared with `var` twice in the same scope in `lib/module.js`. This change makes it a single declaration. PR-URL: #4962 Reviewed-By: Brian White <[email protected]> Reviewed-By: Minwoo Jung <[email protected]> Reviewed-By: Roman Klauke <[email protected]>
scovetta pushed a commit to scovetta/node that referenced this pull request Apr 2, 2016
`homedir` was declared with `var` twice in the same scope in `lib/module.js`. This change makes it a single declaration. PR-URL: nodejs#4962 Reviewed-By: Brian White <[email protected]> Reviewed-By: Minwoo Jung <[email protected]> Reviewed-By: Roman Klauke <[email protected]>
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
homedirwas declared withvartwice in the same scope inlib/module.js. This change makes it a single declaration.