src, doc: improve documentation and error message for ICU data fallback#49666
Uh oh!
There was an error while loading. Please reload this page.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Collaborator
nodejs-github-bot commented Sep 15, 2023
Review requested:
|
nodejs-github-bot added c++ 
richardlau approved these changes Sep 15, 2023
github-actionsbot removed the request-ci Collaborator
nodejs-github-bot commented Sep 15, 2023
25 tasks
Collaborator
nodejs-github-bot commented Sep 16, 2023
jasnell reviewed Sep 16, 2023
| namespacei18n{ | ||
| boolInitializeICUDirectory(const std::string& path); | ||
| boolInitializeICUDirectory(const std::string& path, std::string* error); |
Member
There was a problem hiding this comment.
Just curious, why std::string* and not const std::string&?
MemberAuthor
There was a problem hiding this comment.
This is an out parameter, the caller gets the error string if it fails
jasnell approved these changes Sep 16, 2023
32 tasks
Collaborator
nodejs-github-bot commented Sep 17, 2023
33 tasks
joyeecheungforce-pushed the small-icu-doc branch from 81991de to ac4edacCompare
MemberAuthor
joyeecheung commented Sep 18, 2023
Fixed the line length to make the linter happy |
github-actionsbot removed the request-ci Collaborator
nodejs-github-bot commented Sep 18, 2023
Previously when we fail to initialize ICU data, the error message is ``` could not initialize ICU (check NODE_ICU_DATA or --icu-data-dir parameters) ``` This patch updates it to something similar to: ``` U_FILE_ACCESS_ERROR: Could not initialize ICU. Check the directory specified by NODE_ICU_DATA or --icu-data-dir contains icudt73l.dat and it's readable ``` Where the expected data file name is the same as U_ICUDATA_NAME.
This patch: - Documents `--with-icu-default-data-dir` and its precedence - Elaborates a bit more about the format of the name of the expected data file.
joyeecheungforce-pushed the small-icu-doc branch from ac4edac to 930aba9CompareMemberAuthor
joyeecheung commented Sep 18, 2023
Apparently test-icu-data-dir was matching the old error messages. Updated the test a bit. |
MemberAuthor
joyeecheung commented Sep 18, 2023
@richardlau@jasnell I've updated the test for new error message matches. Can you take a look again? Thanks |
Collaborator
nodejs-github-bot commented Sep 18, 2023
github-actionsbot removed the request-ci Collaborator
nodejs-github-bot commented Sep 18, 2023
richardlau approved these changes Sep 18, 2023
Collaborator
nodejs-github-bot commented Sep 18, 2023
This was referenced Sep 19, 2023
joyeecheung added commit-queue nodejs-github-bot removed the commit-queue Collaborator
nodejs-github-bot commented Sep 22, 2023
Landed in c2cd744...db5e993 |
nodejs-github-bot pushed a commit that referenced this pull request Sep 22, 2023
Previously when we fail to initialize ICU data, the error message is ``` could not initialize ICU (check NODE_ICU_DATA or --icu-data-dir parameters) ``` This patch updates it to something similar to: ``` U_FILE_ACCESS_ERROR: Could not initialize ICU. Check the directory specified by NODE_ICU_DATA or --icu-data-dir contains icudt73l.dat and it's readable ``` Where the expected data file name is the same as U_ICUDATA_NAME. PR-URL: #49666 Reviewed-By: Richard Lau <[email protected]> Reviewed-By: James M Snell <[email protected]>
nodejs-github-bot pushed a commit that referenced this pull request Sep 22, 2023
This patch: - Documents `--with-icu-default-data-dir` and its precedence - Elaborates a bit more about the format of the name of the expected data file. PR-URL: #49666 Reviewed-By: Richard Lau <[email protected]> Reviewed-By: James M Snell <[email protected]>
ruyadorno pushed a commit that referenced this pull request Sep 28, 2023
Previously when we fail to initialize ICU data, the error message is ``` could not initialize ICU (check NODE_ICU_DATA or --icu-data-dir parameters) ``` This patch updates it to something similar to: ``` U_FILE_ACCESS_ERROR: Could not initialize ICU. Check the directory specified by NODE_ICU_DATA or --icu-data-dir contains icudt73l.dat and it's readable ``` Where the expected data file name is the same as U_ICUDATA_NAME. PR-URL: #49666 Reviewed-By: Richard Lau <[email protected]> Reviewed-By: James M Snell <[email protected]>
ruyadorno pushed a commit that referenced this pull request Sep 28, 2023
This patch: - Documents `--with-icu-default-data-dir` and its precedence - Elaborates a bit more about the format of the name of the expected data file. PR-URL: #49666 Reviewed-By: Richard Lau <[email protected]> Reviewed-By: James M Snell <[email protected]>
alexfernandez pushed a commit to alexfernandez/node that referenced this pull request Nov 1, 2023
Previously when we fail to initialize ICU data, the error message is ``` could not initialize ICU (check NODE_ICU_DATA or --icu-data-dir parameters) ``` This patch updates it to something similar to: ``` U_FILE_ACCESS_ERROR: Could not initialize ICU. Check the directory specified by NODE_ICU_DATA or --icu-data-dir contains icudt73l.dat and it's readable ``` Where the expected data file name is the same as U_ICUDATA_NAME. PR-URL: nodejs#49666 Reviewed-By: Richard Lau <[email protected]> Reviewed-By: James M Snell <[email protected]>
alexfernandez pushed a commit to alexfernandez/node that referenced this pull request Nov 1, 2023
This patch: - Documents `--with-icu-default-data-dir` and its precedence - Elaborates a bit more about the format of the name of the expected data file. PR-URL: nodejs#49666 Reviewed-By: Richard Lau <[email protected]> Reviewed-By: James M Snell <[email protected]>
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
src: improve error message when ICU data cannot be initialized
Previously when we fail to initialize ICU data, the error message is
This patch updates it to something similar to:
Where the expected data file name is the same as U_ICUDATA_NAME.
doc: improve documentation about ICU data fallback
This patch:
--with-icu-default-data-dirand its precedencedata file.