Skip to content

test: use fs.constants for fs.access constants#49685

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
nodejs-github-bot merged 1 commit into from
Sep 20, 2023
Merged

test: use fs.constants for fs.access constants #49685

nodejs-github-bot merged 1 commit into from
Sep 20, 2023

Conversation

@LiviaMedeiros
Copy link
Member

@LiviaMedeirosLiviaMedeiros commented Sep 17, 2023

No description provided.

@nodejs-github-botnodejs-github-bot added needs-ci PRs that need a full CI run. test Issues and PRs related to the tests. labels Sep 17, 2023
@LiviaMedeirosLiviaMedeiros mentioned this pull request Sep 17, 2023
Merged
@LiviaMedeirosLiviaMedeiros added the request-ci Add this label to start a Jenkins CI on a PR. label Sep 17, 2023
@github-actionsgithub-actionsbot removed the request-ci Add this label to start a Jenkins CI on a PR. label Sep 17, 2023
@nodejs-github-bot
Copy link
Collaborator

nodejs-github-bot commented Sep 17, 2023

CI: https://ci.nodejs.org/job/node-test-pull-request/54005/

@LiviaMedeirosLiviaMedeiros added the author ready PRs that have at least one approval, no pending requests for changes, and a CI started. label Sep 17, 2023
@LiviaMedeirosLiviaMedeiros added the commit-queue Add this label to land a pull request using GitHub Actions. label Sep 20, 2023
@nodejs-github-botnodejs-github-bot removed the commit-queue Add this label to land a pull request using GitHub Actions. label Sep 20, 2023
@nodejs-github-botnodejs-github-bot merged commit cdad3d8 into nodejs:mainSep 20, 2023
@nodejs-github-bot
Copy link
Collaborator

nodejs-github-bot commented Sep 20, 2023

Landed in cdad3d8

ruyadorno pushed a commit that referenced this pull request Sep 28, 2023
@LiviaMedeiros@ruyadorno
test: use fs.constants for fs.access constants
e5185b0
PR-URL: #49685 Reviewed-By: Benjamin Gruenbaum <[email protected]> Reviewed-By: Luigi Pinca <[email protected]>
This was referenced Sep 28, 2023
Closed
Merged
alexfernandez pushed a commit to alexfernandez/node that referenced this pull request Nov 1, 2023
@LiviaMedeiros@alexfernandez
test: use fs.constants for fs.access constants
6bc122f
PR-URL: nodejs#49685 Reviewed-By: Benjamin Gruenbaum <[email protected]> Reviewed-By: Luigi Pinca <[email protected]>
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@benjamingrbenjamingrbenjamingr approved these changes

@lpincalpincalpinca approved these changes

Assignees

No one assigned

Labels

author readyPRs that have at least one approval, no pending requests for changes, and a CI started.needs-ciPRs that need a full CI run.testIssues and PRs related to the tests.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@LiviaMedeiros@nodejs-github-bot@benjamingr@lpinca