meta: add primordials strategic initiative #49706
Merged
Uh oh!
There was an error while loading. Please reload this page.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Collaborator
nodejs-github-bot commented Sep 18, 2023
Review requested:
|
benjamingr changed the title 
anonrig approved these changes Sep 18, 2023
MoLow approved these changes Sep 18, 2023
fhinkel approved these changes Sep 19, 2023
targos reviewed Sep 19, 2023
Uh oh!
There was an error while loading. Please reload this page.
targos approved these changes Sep 19, 2023
tniessen approved these changes Sep 19, 2023
Uh oh!
There was an error while loading. Please reload this page.
benjamingr added the commit-queue 
nodejs-github-bot added commit-queue-failed Collaborator
nodejs-github-bot commented Sep 20, 2023
Commit Queue failed- Loading data for nodejs/node/pull/49706 ✔ Done loading data for nodejs/node/pull/49706 ----------------------------------- PR info ------------------------------------ Title meta: add primordials strategic initiative (#49706) Author Benjamin Gruenbaum (@benjamingr) Branch benjamingr:add-primordials-strategic-initiatiive -> nodejs:main Labels doc Commits 2 - Update strategic-initiatives.md - fixup: update link Committers 1 - GitHub PR-URL: https://github.com/nodejs/node/pull/49706 Reviewed-By: Yagiz Nizipli Reviewed-By: Matteo Collina Reviewed-By: Moshe Atlow Reviewed-By: Franziska Hinkelmann Reviewed-By: Michaël Zasso Reviewed-By: Tobias Nießen ------------------------------ Generated metadata ------------------------------ PR-URL: https://github.com/nodejs/node/pull/49706 Reviewed-By: Yagiz Nizipli Reviewed-By: Matteo Collina Reviewed-By: Moshe Atlow Reviewed-By: Franziska Hinkelmann Reviewed-By: Michaël Zasso Reviewed-By: Tobias Nießen -------------------------------------------------------------------------------- ⚠ Commits were pushed since the last approving review: ⚠ - fixup: update link ℹ This PR was created on Mon, 18 Sep 2023 17:56:58 GMT ✔ Approvals: 6 ✔ - Yagiz Nizipli (@anonrig) (TSC): https://github.com/nodejs/node/pull/49706#pullrequestreview-1631839626 ✔ - Matteo Collina (@mcollina) (TSC): https://github.com/nodejs/node/pull/49706#pullrequestreview-1631852567 ✔ - Moshe Atlow (@MoLow) (TSC): https://github.com/nodejs/node/pull/49706#pullrequestreview-1631881734 ✔ - Franziska Hinkelmann (@fhinkel) (TSC): https://github.com/nodejs/node/pull/49706#pullrequestreview-1632218574 ✔ - Michaël Zasso (@targos) (TSC): https://github.com/nodejs/node/pull/49706#pullrequestreview-1632662147 ✔ - Tobias Nießen (@tniessen) (TSC): https://github.com/nodejs/node/pull/49706#pullrequestreview-1632747668 ✘ Last GitHub CI failed ℹ Green GitHub CI is sufficient -------------------------------------------------------------------------------- ✔ Aborted `git node land` session in /home/runner/work/node/node/.ncuhttps://github.com/nodejs/node/actions/runs/6254106051 |
RafaelGSS approved these changes Sep 21, 2023
benjamingr added commit-queue nodejs-github-bot added commit-queue-failed Collaborator
nodejs-github-bot commented Sep 21, 2023
Commit Queue failed- Loading data for nodejs/node/pull/49706 ✔ Done loading data for nodejs/node/pull/49706 ----------------------------------- PR info ------------------------------------ Title meta: add primordials strategic initiative (#49706) Author Benjamin Gruenbaum (@benjamingr) Branch benjamingr:add-primordials-strategic-initiatiive -> nodejs:main Labels doc, commit-queue-squash Commits 2 - Update strategic-initiatives.md - fixup: update link Committers 1 - GitHub PR-URL: https://github.com/nodejs/node/pull/49706 Reviewed-By: Yagiz Nizipli Reviewed-By: Matteo Collina Reviewed-By: Moshe Atlow Reviewed-By: Franziska Hinkelmann Reviewed-By: Michaël Zasso Reviewed-By: Tobias Nießen Reviewed-By: Rafael Gonzaga ------------------------------ Generated metadata ------------------------------ PR-URL: https://github.com/nodejs/node/pull/49706 Reviewed-By: Yagiz Nizipli Reviewed-By: Matteo Collina Reviewed-By: Moshe Atlow Reviewed-By: Franziska Hinkelmann Reviewed-By: Michaël Zasso Reviewed-By: Tobias Nießen Reviewed-By: Rafael Gonzaga -------------------------------------------------------------------------------- ℹ This PR was created on Mon, 18 Sep 2023 17:56:58 GMT ✔ Approvals: 7 ✔ - Yagiz Nizipli (@anonrig) (TSC): https://github.com/nodejs/node/pull/49706#pullrequestreview-1631839626 ✔ - Matteo Collina (@mcollina) (TSC): https://github.com/nodejs/node/pull/49706#pullrequestreview-1631852567 ✔ - Moshe Atlow (@MoLow) (TSC): https://github.com/nodejs/node/pull/49706#pullrequestreview-1631881734 ✔ - Franziska Hinkelmann (@fhinkel) (TSC): https://github.com/nodejs/node/pull/49706#pullrequestreview-1632218574 ✔ - Michaël Zasso (@targos) (TSC): https://github.com/nodejs/node/pull/49706#pullrequestreview-1632662147 ✔ - Tobias Nießen (@tniessen) (TSC): https://github.com/nodejs/node/pull/49706#pullrequestreview-1632747668 ✔ - Rafael Gonzaga (@RafaelGSS) (TSC): https://github.com/nodejs/node/pull/49706#pullrequestreview-1638400077 ✘ Last GitHub CI failed ℹ Green GitHub CI is sufficient -------------------------------------------------------------------------------- ✔ Aborted `git node land` session in /home/runner/work/node/node/.ncuhttps://github.com/nodejs/node/actions/runs/6265913467 |
Contributor
aduh95 commented Sep 21, 2023
Landed in 2e4e1e1 |
Member
anonrig commented Sep 21, 2023
This broke main |
ruyadorno pushed a commit that referenced this pull request Sep 28, 2023
PR-URL: #49706 Reviewed-By: Yagiz Nizipli <[email protected]> Reviewed-By: Matteo Collina <[email protected]> Reviewed-By: Moshe Atlow <[email protected]> Reviewed-By: Franziska Hinkelmann <[email protected]> Reviewed-By: Michaël Zasso <[email protected]> Reviewed-By: Tobias Nießen <[email protected]> Reviewed-By: Rafael Gonzaga <[email protected]>
Closed
Merged
alexfernandez pushed a commit to alexfernandez/node that referenced this pull request Nov 1, 2023
PR-URL: nodejs#49706 Reviewed-By: Yagiz Nizipli <[email protected]> Reviewed-By: Matteo Collina <[email protected]> Reviewed-By: Moshe Atlow <[email protected]> Reviewed-By: Franziska Hinkelmann <[email protected]> Reviewed-By: Michaël Zasso <[email protected]> Reviewed-By: Tobias Nießen <[email protected]> Reviewed-By: Rafael Gonzaga <[email protected]>
targos pushed a commit that referenced this pull request Nov 27, 2023
PR-URL: #49706 Reviewed-By: Yagiz Nizipli <[email protected]> Reviewed-By: Matteo Collina <[email protected]> Reviewed-By: Moshe Atlow <[email protected]> Reviewed-By: Franziska Hinkelmann <[email protected]> Reviewed-By: Michaël Zasso <[email protected]> Reviewed-By: Tobias Nießen <[email protected]> Reviewed-By: Rafael Gonzaga <[email protected]>
sercher added a commit to sercher/graaljs that referenced this pull request Apr 25, 2024
PR-URL: nodejs/node#49706 Reviewed-By: Yagiz Nizipli <[email protected]> Reviewed-By: Matteo Collina <[email protected]> Reviewed-By: Moshe Atlow <[email protected]> Reviewed-By: Franziska Hinkelmann <[email protected]> Reviewed-By: Michaël Zasso <[email protected]> Reviewed-By: Tobias Nießen <[email protected]> Reviewed-By: Rafael Gonzaga <[email protected]>
sercher added a commit to sercher/graaljs that referenced this pull request Apr 25, 2024
PR-URL: nodejs/node#49706 Reviewed-By: Yagiz Nizipli <[email protected]> Reviewed-By: Matteo Collina <[email protected]> Reviewed-By: Moshe Atlow <[email protected]> Reviewed-By: Franziska Hinkelmann <[email protected]> Reviewed-By: Michaël Zasso <[email protected]> Reviewed-By: Tobias Nießen <[email protected]> Reviewed-By: Rafael Gonzaga <[email protected]>
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is a pull request to add the strategic initiative outlined in nodejs/TSC#1439 there is a list of tasks here nodejs/TSC#1439 (comment)
Please do not fast-track this as I'd like to give nodejs/TSC#1439 (comment) a week to make sure everyone had time to see it for lazy consensus