doc: fix notDeepEqual API#4971
Closed
Uh oh!
There was an error while loading. Please reload this page.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Member
Trott commented Jan 30, 2016
LGTM |
Contributor
stevemao commented Jan 30, 2016
LGTM |
API calls in `assert` are `deepEqual()`, not `notDeepEqual()`. use `notDeepEqual` to make it clear. PR-URL: #4971 Reviewed-By: Rich Trott <[email protected]>
JungMinu added a commit that referenced this pull request Jan 31, 2016
API calls in `assert` are `deepEqual()`, not `notDeepEqual()`. use `notDeepEqual` to make it clear. PR-URL: #4971 Reviewed-By: Rich Trott <[email protected]>
MemberAuthor
JungMinu commented Jan 31, 2016
Thanks, landed in de3e94b |
rvagg pushed a commit that referenced this pull request Feb 8, 2016
API calls in `assert` are `deepEqual()`, not `notDeepEqual()`. use `notDeepEqual` to make it clear. PR-URL: #4971 Reviewed-By: Rich Trott <[email protected]>
Contributor
MylesBorins commented Feb 17, 2016
Blocked from backporting due to other Doc fixes |
MylesBorins pushed a commit that referenced this pull request Feb 22, 2016
API calls in `assert` are `deepEqual()`, not `notDeepEqual()`. use `notDeepEqual` to make it clear. PR-URL: #4971 Reviewed-By: Rich Trott <[email protected]>
MylesBorins pushed a commit that referenced this pull request Feb 22, 2016
API calls in `assert` are `deepEqual()`, not `notDeepEqual()`. use `notDeepEqual` to make it clear. PR-URL: #4971 Reviewed-By: Rich Trott <[email protected]>
MylesBorins pushed a commit that referenced this pull request Mar 2, 2016
API calls in `assert` are `deepEqual()`, not `notDeepEqual()`. use `notDeepEqual` to make it clear. PR-URL: #4971 Reviewed-By: Rich Trott <[email protected]>
scovetta pushed a commit to scovetta/node that referenced this pull request Apr 2, 2016
API calls in `assert` are `deepEqual()`, not `notDeepEqual()`. use `notDeepEqual` to make it clear. PR-URL: nodejs#4971 Reviewed-By: Rich Trott <[email protected]>
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
API calls in
assertaredeepEqual(), notnotDeepEqual().use
notDeepEqualto make it clear.