Skip to content

doc: update output of example in mimeParams.set()#49718

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
nodejs-github-bot merged 1 commit into from
Sep 21, 2023
Merged

doc: update output of example in mimeParams.set()#49718

nodejs-github-bot merged 1 commit into from
Sep 21, 2023

Conversation

@deokjinkim
Copy link
Contributor

@deokjinkimdeokjinkim commented Sep 19, 2023

Actual output of example in mimeParams.set() is mismatched.
So update output of example in mimeParams.set().

Expected output:

foo=def&bar=1&baz=xyz

Actual output:

foo=def;bar=1;baz=xyz

@deokjinkim
doc: update output of example in mimeParams.set()
68b81c9
Actual output of example in `mimeParams.set()` is mismatched.
@nodejs-github-botnodejs-github-bot added doc Issues and PRs related to the documentations. util Issues and PRs related to the built-in util module. labels Sep 19, 2023
@deokjinkimdeokjinkim added the author ready PRs that have at least one approval, no pending requests for changes, and a CI started. label Sep 20, 2023
@deokjinkimdeokjinkim added the commit-queue Add this label to land a pull request using GitHub Actions. label Sep 21, 2023
@nodejs-github-botnodejs-github-bot removed the commit-queue Add this label to land a pull request using GitHub Actions. label Sep 21, 2023
@nodejs-github-botnodejs-github-bot merged commit 05ebb8e into nodejs:mainSep 21, 2023
@nodejs-github-bot
Copy link
Collaborator

nodejs-github-bot commented Sep 21, 2023

Landed in 05ebb8e

ruyadorno pushed a commit that referenced this pull request Sep 28, 2023
@deokjinkim@ruyadorno
doc: update output of example in mimeParams.set()
fe78a34
Actual output of example in `mimeParams.set()` is mismatched. PR-URL: #49718 Reviewed-By: Matthew Aitken <[email protected]> Reviewed-By: Luigi Pinca <[email protected]>
This was referenced Sep 28, 2023
Closed
Merged
alexfernandez pushed a commit to alexfernandez/node that referenced this pull request Nov 1, 2023
@deokjinkim@alexfernandez
doc: update output of example in mimeParams.set()
7f3a31f
Actual output of example in `mimeParams.set()` is mismatched. PR-URL: nodejs#49718 Reviewed-By: Matthew Aitken <[email protected]> Reviewed-By: Luigi Pinca <[email protected]>
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@lpincalpincalpinca approved these changes

@KhafraDevKhafraDevKhafraDev approved these changes

+1 more reviewer

@aymen94aymen94aymen94 approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

author readyPRs that have at least one approval, no pending requests for changes, and a CI started.docIssues and PRs related to the documentations.utilIssues and PRs related to the built-in util module.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@deokjinkim@nodejs-github-bot@lpinca@aymen94@KhafraDev