Skip to content

lib: fix internalBinding typings#49742

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
nodejs-github-bot merged 2 commits into from
Sep 23, 2023
Merged

lib: fix internalBinding typings #49742

nodejs-github-bot merged 2 commits into from
Sep 23, 2023

Conversation

@anonrig
Copy link
Member

@anonriganonrig commented Sep 20, 2023

I've finally found a way to fix the internalBinding typings for both VSCode and Clion (Intellij).

@nodejs-github-bot
Copy link
Collaborator

nodejs-github-bot commented Sep 20, 2023•
edited by GeoffreyBooth
Loading

Review requested:

  • @nodejs/loaders
  • @nodejs/startup
  • @nodejs/typescript

@nodejs-github-botnodejs-github-bot added lib / src Issues and PRs related to general changes in the lib or src directory. needs-ci PRs that need a full CI run. labels Sep 20, 2023
GeoffreyBooth
GeoffreyBooth reviewed Sep 20, 2023
View reviewed changes
Copy link
Member

@GeoffreyBoothGeoffreyBooth left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is amazing, thank you! Can you confirm that this fixes the references to ModuleWrap in the modules code? And/or update those references in this PR?

@anonrig@GeoffreyBooth
Update globals.d.ts
6720461
Co-authored-by: Geoffrey Booth <[email protected]>
himself65
himself65 approved these changes Sep 20, 2023
View reviewed changes
Copy link
Member

@himself65himself65 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is helpful

@anonriganonrig added author ready PRs that have at least one approval, no pending requests for changes, and a CI started. commit-queue Add this label to land a pull request using GitHub Actions. commit-queue-squash Add this label to instruct the Commit Queue to squash all the PR commits into the first one. labels Sep 21, 2023
@nodejs-github-botnodejs-github-bot added commit-queue-failed An error occurred while landing this pull request using GitHub Actions. and removed commit-queue Add this label to land a pull request using GitHub Actions. labels Sep 22, 2023
@nodejs-github-bot
Copy link
Collaborator

nodejs-github-bot commented Sep 22, 2023

Commit Queue failed
- Loading data for nodejs/node/pull/49742 ✔ Done loading data for nodejs/node/pull/49742 ----------------------------------- PR info ------------------------------------ Title lib: fix `internalBinding` typings (#49742) Author Yagiz Nizipli (@anonrig) Branch anonrig:internal-binding-2023 -> nodejs:main Labels lib / src, author ready, needs-ci, typings, commit-queue-squash Commits 2 - lib: fix `internalBinding` typings - Update globals.d.ts Committers 2 - Yagiz Nizipli - GitHub PR-URL: https://github.com/nodejs/node/pull/49742 Reviewed-By: Chemi Atlow Reviewed-By: Geoffrey Booth Reviewed-By: Zeyu "Alex" Yang Reviewed-By: Moshe Atlow ------------------------------ Generated metadata ------------------------------ PR-URL: https://github.com/nodejs/node/pull/49742 Reviewed-By: Chemi Atlow Reviewed-By: Geoffrey Booth Reviewed-By: Zeyu "Alex" Yang Reviewed-By: Moshe Atlow -------------------------------------------------------------------------------- ℹ This PR was created on Wed, 20 Sep 2023 21:55:40 GMT ✔ Approvals: 4 ✔ - Chemi Atlow (@atlowChemi): https://github.com/nodejs/node/pull/49742#pullrequestreview-1636575033 ✔ - Geoffrey Booth (@GeoffreyBooth) (TSC): https://github.com/nodejs/node/pull/49742#pullrequestreview-1636593235 ✔ - Zeyu "Alex" Yang (@himself65): https://github.com/nodejs/node/pull/49742#pullrequestreview-1636652931 ✔ - Moshe Atlow (@MoLow) (TSC): https://github.com/nodejs/node/pull/49742#pullrequestreview-1636923558 ✔ Last GitHub CI successful ✘ No Jenkins CI runs detected -------------------------------------------------------------------------------- ✔ Aborted `git node land` session in /home/runner/work/node/node/.ncu
https://github.com/nodejs/node/actions/runs/6279502512

@anonriganonrig added the request-ci Add this label to start a Jenkins CI on a PR. label Sep 22, 2023
@github-actionsgithub-actionsbot removed the request-ci Add this label to start a Jenkins CI on a PR. label Sep 22, 2023
@nodejs-github-bot
Copy link
Collaborator

nodejs-github-bot commented Sep 22, 2023

CI: https://ci.nodejs.org/job/node-test-pull-request/54165/

@nodejs-github-bot
Copy link
Collaborator

nodejs-github-bot commented Sep 23, 2023

CI: https://ci.nodejs.org/job/node-test-pull-request/54173/

@anonriganonrig added commit-queue Add this label to land a pull request using GitHub Actions. and removed commit-queue-failed An error occurred while landing this pull request using GitHub Actions. labels Sep 23, 2023
@nodejs-github-botnodejs-github-bot removed the commit-queue Add this label to land a pull request using GitHub Actions. label Sep 23, 2023
@nodejs-github-botnodejs-github-bot merged commit da7962f into nodejs:mainSep 23, 2023
@nodejs-github-bot
Copy link
Collaborator

nodejs-github-bot commented Sep 23, 2023

Landed in da7962f

@github-actionsgithub-actionsbot mentioned this pull request Sep 24, 2023
Open
20 tasks
ruyadorno pushed a commit that referenced this pull request Sep 28, 2023
@anonrig@ruyadorno
lib: fix internalBinding typings
efd6815
PR-URL: #49742 Reviewed-By: Chemi Atlow <[email protected]> Reviewed-By: Geoffrey Booth <[email protected]> Reviewed-By: Zeyu "Alex" Yang <[email protected]> Reviewed-By: Moshe Atlow <[email protected]>
@ruyadornoruyadorno mentioned this pull request Sep 28, 2023
Closed
@ruyadornoruyadorno mentioned this pull request Sep 28, 2023
Merged
alexfernandez pushed a commit to alexfernandez/node that referenced this pull request Nov 1, 2023
@anonrig@alexfernandez
lib: fix internalBinding typings
6a5fc4e
PR-URL: nodejs#49742 Reviewed-By: Chemi Atlow <[email protected]> Reviewed-By: Geoffrey Booth <[email protected]> Reviewed-By: Zeyu "Alex" Yang <[email protected]> Reviewed-By: Moshe Atlow <[email protected]>
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@GeoffreyBoothGeoffreyBoothGeoffreyBooth approved these changes

@MoLowMoLowMoLow approved these changes

@himself65himself65himself65 approved these changes

@Ethan-ArrowoodEthan-ArrowoodEthan-Arrowood approved these changes

@atlowChemiatlowChemiatlowChemi approved these changes

Assignees

No one assigned

Labels

author readyPRs that have at least one approval, no pending requests for changes, and a CI started.commit-queue-squashAdd this label to instruct the Commit Queue to squash all the PR commits into the first one.lib / srcIssues and PRs related to general changes in the lib or src directory.needs-ciPRs that need a full CI run.typings

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

7 participants

@anonrig@nodejs-github-bot@GeoffreyBooth@MoLow@himself65@Ethan-Arrowood@atlowChemi