Skip to content

test_runner: accept testOnly in run#49743

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
MoLow merged 1 commit into from
Sep 21, 2023
Merged

test_runner: accept testOnly in run#49743

MoLow merged 1 commit into from
Sep 21, 2023
+49 −4

Conversation

@MoLow
Copy link
Member

@MoLowMoLow commented Sep 21, 2023

Fixes: #49733

@nodejs-github-bot
Copy link
Collaborator

nodejs-github-bot commented Sep 21, 2023

Review requested:

  • @nodejs/test_runner

@nodejs-github-botnodejs-github-bot added needs-ci PRs that need a full CI run. test_runner Issues and PRs related to the test runner subsystem. labels Sep 21, 2023
@MoLow
Copy link
MemberAuthor

MoLow commented Sep 21, 2023

after this change --experimental-test-coverage is the last cli flag that cannot be passed to run (except for reporters - they should just use pipe), might be worth adding it as well. @cjihrig WDYT?

@atlowChemi
Copy link
Member

atlowChemi commented Sep 21, 2023

might be worth adding it as well

@MoLow I think it could be a nice addition, as it would simplify the usage (would not require understanding of streams etc) without adding a lot of overhead

atlowChemi
atlowChemi approved these changes Sep 21, 2023
View reviewed changes
@MoLow
Copy link
MemberAuthor

MoLow commented Sep 21, 2023

@MoLow I think it could be a nice addition, as it would simplify the usage (would not require understanding of streams etc) without adding a lot of overhead

I was not suggesting to add support for the reporter flags. was suggesting to add the coverage flag

@MoLowMoLow added request-ci Add this label to start a Jenkins CI on a PR. author ready PRs that have at least one approval, no pending requests for changes, and a CI started. labels Sep 21, 2023
@github-actionsgithub-actionsbot removed the request-ci Add this label to start a Jenkins CI on a PR. label Sep 21, 2023
@nodejs-github-bot
Copy link
Collaborator

nodejs-github-bot commented Sep 21, 2023

CI: https://ci.nodejs.org/job/node-test-pull-request/54117/

@cjihrig
Copy link
Contributor

cjihrig commented Sep 21, 2023

@cjihrig WDYT?

Sounds great to me.

@nodejs-github-bot
Copy link
Collaborator

nodejs-github-bot commented Sep 21, 2023

CI: https://ci.nodejs.org/job/node-test-pull-request/54143/

@MoLow
test_runner: catch reporter errors
a4c7f81
PR-URL: nodejs#49646Fixes: nodejs#48937 Reviewed-By: Chemi Atlow <[email protected]> Reviewed-By: Benjamin Gruenbaum <[email protected]> Reviewed-By: Colin Ihrig <[email protected]>
@MoLowMoLow merged commit a4c7f81 into nodejs:mainSep 21, 2023
@MoLowMoLow deleted the run-accept-only branch September 21, 2023 20:24
@MoLowMoLow mentioned this pull request Sep 21, 2023
Merged
This was referenced Sep 22, 2023
Open
Open
Open
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@benjamingrbenjamingrbenjamingr approved these changes

@cjihrigcjihrigcjihrig approved these changes

@atlowChemiatlowChemiAwaiting requested review from atlowChemi

Assignees

No one assigned

Labels

author readyPRs that have at least one approval, no pending requests for changes, and a CI started.needs-ciPRs that need a full CI run.test_runnerIssues and PRs related to the test runner subsystem.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Test runner: add 'testOnly' parameter to 'run' function

5 participants

@MoLow@nodejs-github-bot@atlowChemi@cjihrig@benjamingr