deps: remove pthread-fixes.c from uv.gyp#49744
Merged
+0 −2
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
The file was removed in the latest libuv upgrade. Remove it from the build recipe as well. Fixes: nodejs#49739
Collaborator
nodejs-github-bot commented Sep 21, 2023
Review requested:
|
nodejs-github-bot added libuv Closed
RaisinTen approved these changes Sep 21, 2023
debadree25 approved these changes Sep 21, 2023
debadree25 added author ready 
github-actionsbot removed the request-ci Collaborator
nodejs-github-bot commented Sep 21, 2023
cjihrig approved these changes Sep 21, 2023
richardlau approved these changes Sep 21, 2023
Collaborator
nodejs-github-bot commented Sep 21, 2023
gengjiawen approved these changes Sep 21, 2023
tniessen approved these changes Sep 21, 2023
Collaborator
nodejs-github-bot commented Sep 21, 2023
Collaborator
nodejs-github-bot commented Sep 21, 2023
lpinca approved these changes Sep 21, 2023
santigimeno approved these changes Sep 21, 2023
Member
santigimeno left a comment
santigimeno left a comment There was a problem hiding this comment.
My bad. Thanks for fixing this
richardlau added the commit-queue This was referenced Sep 22, 2023
nodejs-github-bot removed the commit-queue Collaborator
nodejs-github-bot commented Sep 23, 2023
Landed in 914ad2f |
20 tasks
ruyadorno pushed a commit that referenced this pull request Sep 28, 2023
The file was removed in the latest libuv upgrade. Remove it from the build recipe as well. Fixes: #49739 PR-URL: #49744 Reviewed-By: Darshan Sen <[email protected]> Reviewed-By: Debadree Chatterjee <[email protected]> Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Richard Lau <[email protected]> Reviewed-By: Jiawen Geng <[email protected]> Reviewed-By: Tobias Nießen <[email protected]> Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: Santiago Gimeno <[email protected]>
Closed
Merged
alexfernandez pushed a commit to alexfernandez/node that referenced this pull request Nov 1, 2023
The file was removed in the latest libuv upgrade. Remove it from the build recipe as well. Fixes: nodejs#49739 PR-URL: nodejs#49744 Reviewed-By: Darshan Sen <[email protected]> Reviewed-By: Debadree Chatterjee <[email protected]> Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Richard Lau <[email protected]> Reviewed-By: Jiawen Geng <[email protected]> Reviewed-By: Tobias Nießen <[email protected]> Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: Santiago Gimeno <[email protected]>
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment
10 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The file was removed in the latest libuv upgrade. Remove it from the build recipe as well.
Fixes: #49739