test: replace forEach() with for ... of loop in test-global.js for enhanced…#49772
Uh oh!
There was an error while loading. Please reload this page.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
nodejs-github-bot added needs-ci Member
RafaelGSS left a comment
RafaelGSS left a comment There was a problem hiding this comment.
Thanks for your contribution, could you please adjust the commit message? It must contain the namespace, in your case, test. Therefore, the new message should be:
test: replace forEach() with for .. loop in test-global.js
you can do this by running:
git commit --amend -> adjust your messagegit push -f origin kajol-ghc
RafaelGSS changed the title 
tniessen added the code-and-learn 
RafaelGSS approved these changes Sep 24, 2023
github-actionsbot removed the request-ci 
Collaborator
nodejs-github-bot commented Sep 24, 2023
trivikr approved these changes Sep 25, 2023
21 tasks
Collaborator
nodejs-github-bot commented Oct 9, 2023
Collaborator
nodejs-github-bot commented Oct 23, 2023
This was referenced Oct 24, 2023
Collaborator
nodejs-github-bot commented Oct 25, 2023
jasnell approved these changes Oct 28, 2023
RafaelGSS added the commit-queue nodejs-github-bot removed the commit-queue Collaborator
nodejs-github-bot commented Nov 7, 2023
Landed in 5e3217c |
targos pushed a commit that referenced this pull request Nov 11, 2023
PR-URL: #49772 Reviewed-By: Rafael Gonzaga <[email protected]> Reviewed-By: Trivikram Kamat <[email protected]> Reviewed-By: James M Snell <[email protected]>
targos pushed a commit that referenced this pull request Nov 14, 2023
PR-URL: #49772 Reviewed-By: Rafael Gonzaga <[email protected]> Reviewed-By: Trivikram Kamat <[email protected]> Reviewed-By: James M Snell <[email protected]>
UlisesGascon pushed a commit that referenced this pull request Dec 11, 2023
PR-URL: #49772 Reviewed-By: Rafael Gonzaga <[email protected]> Reviewed-By: Trivikram Kamat <[email protected]> Reviewed-By: James M Snell <[email protected]>
Merged
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Replace forEach() with for ... of in test-global.js
Grace Hopper Day - pull request to replace forEach.