Skip to content

test: use destructuring in test-path-parse-format#49790

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
aduh95 merged 2 commits into from
May 12, 2024
Merged

test: use destructuring in test-path-parse-format #49790

aduh95 merged 2 commits into from
May 12, 2024

Conversation

@gibbyfree
Copy link
Contributor

@gibbyfreegibbyfree commented Sep 22, 2023

No description provided.

@nodejs-github-botnodejs-github-bot added needs-ci PRs that need a full CI run. test Issues and PRs related to the tests. labels Sep 22, 2023
tniessen
tniessen approved these changes Sep 22, 2023
View reviewed changes
Copy link
Member

@tniessentniessen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome, thank you @gibbyfree.

@tniessentniessen added the code-and-learn Issues related to the Code-and-Learn events and PRs submitted during the events. label Sep 22, 2023
tniessen
tniessen approved these changes Sep 22, 2023
View reviewed changes
Copy link
Member

@tniessentniessen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great work, thank you!

@tniessentniessen added the request-ci Add this label to start a Jenkins CI on a PR. label Sep 22, 2023
@github-actionsgithub-actionsbot removed the request-ci Add this label to start a Jenkins CI on a PR. label Sep 22, 2023
@nodejs-github-bot
Copy link
Collaborator

nodejs-github-bot commented Sep 22, 2023

CI: https://ci.nodejs.org/job/node-test-pull-request/54166/

@github-actionsgithub-actionsbot mentioned this pull request Sep 24, 2023
Open
20 tasks
@joyeecheungjoyeecheung mentioned this pull request Sep 25, 2023
Closed
@lpincalpinca added the request-ci Add this label to start a Jenkins CI on a PR. label Sep 25, 2023
@github-actionsgithub-actionsbot removed the request-ci Add this label to start a Jenkins CI on a PR. label Sep 25, 2023
@nodejs-github-bot
Copy link
Collaborator

nodejs-github-bot commented Sep 25, 2023

CI: https://ci.nodejs.org/job/node-test-pull-request/54232/

This was referenced Sep 27, 2023
Open
Open
@RafaelGSSRafaelGSS added commit-queue-squash Add this label to instruct the Commit Queue to squash all the PR commits into the first one. request-ci Add this label to start a Jenkins CI on a PR. labels Nov 7, 2023
@github-actionsgithub-actionsbot removed the request-ci Add this label to start a Jenkins CI on a PR. label Nov 7, 2023
@nodejs-github-bot
Copy link
Collaborator

nodejs-github-bot commented Nov 7, 2023

CI: https://ci.nodejs.org/job/node-test-pull-request/55477/

@RafaelGSSRafaelGSS added the request-ci Add this label to start a Jenkins CI on a PR. label Nov 24, 2023
@github-actionsgithub-actionsbot removed the request-ci Add this label to start a Jenkins CI on a PR. label Nov 24, 2023
@nodejs-github-bot
Copy link
Collaborator

nodejs-github-bot commented Nov 24, 2023

CI: https://ci.nodejs.org/job/node-test-pull-request/55893/

@lpincalpinca added the request-ci Add this label to start a Jenkins CI on a PR. label Dec 29, 2023
@github-actionsgithub-actionsbot removed the request-ci Add this label to start a Jenkins CI on a PR. label Dec 29, 2023
@nodejs-github-bot
Copy link
Collaborator

nodejs-github-bot commented Dec 29, 2023

CI: https://ci.nodejs.org/job/node-test-pull-request/56585/

@aduh95aduh95 added author ready PRs that have at least one approval, no pending requests for changes, and a CI started. request-ci Add this label to start a Jenkins CI on a PR. labels May 11, 2024
@github-actionsgithub-actionsbot removed the request-ci Add this label to start a Jenkins CI on a PR. label May 11, 2024
@nodejs-github-bot
Copy link
Collaborator

nodejs-github-bot commented May 11, 2024

CI: https://ci.nodejs.org/job/node-test-pull-request/59109/

@nodejs-github-bot
Copy link
Collaborator

nodejs-github-bot commented May 12, 2024

CI: https://ci.nodejs.org/job/node-test-pull-request/59149/

@nodejs-github-bot
Copy link
Collaborator

nodejs-github-bot commented May 12, 2024

CI: https://ci.nodejs.org/job/node-test-pull-request/59178/

@aduh95aduh95 merged commit 33370ee into nodejs:mainMay 12, 2024
@aduh95
Copy link
Contributor

aduh95 commented May 12, 2024

Landed in 33370ee

targos pushed a commit that referenced this pull request May 12, 2024
@gibbyfree@targos
test: use for-of instead of forEach
a589de0
PR-URL: #49790 Reviewed-By: Tobias Nießen <[email protected]> Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: Ruy Adorno <[email protected]> Reviewed-By: Antoine du Hamel <[email protected]>
@targostargos mentioned this pull request May 13, 2024
Merged
marco-ippolito pushed a commit that referenced this pull request Jun 17, 2024
@gibbyfree@marco-ippolito
test: use for-of instead of forEach
7980963
PR-URL: #49790 Reviewed-By: Tobias Nießen <[email protected]> Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: Ruy Adorno <[email protected]> Reviewed-By: Antoine du Hamel <[email protected]>
@marco-ippolitomarco-ippolito mentioned this pull request Jun 17, 2024
Merged
marco-ippolito pushed a commit that referenced this pull request Jun 17, 2024
@gibbyfree@marco-ippolito
test: use for-of instead of forEach
58c0294
PR-URL: #49790 Reviewed-By: Tobias Nießen <[email protected]> Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: Ruy Adorno <[email protected]> Reviewed-By: Antoine du Hamel <[email protected]>
marco-ippolito pushed a commit that referenced this pull request Jun 17, 2024
@gibbyfree@marco-ippolito
test: use for-of instead of forEach
0513e07
PR-URL: #49790 Reviewed-By: Tobias Nießen <[email protected]> Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: Ruy Adorno <[email protected]> Reviewed-By: Antoine du Hamel <[email protected]>
eliphazbouye pushed a commit to eliphazbouye/node that referenced this pull request Jun 20, 2024
@gibbyfree@eliphazbouye
test: use for-of instead of forEach
c300d67
PR-URL: nodejs#49790 Reviewed-By: Tobias Nießen <[email protected]> Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: Ruy Adorno <[email protected]> Reviewed-By: Antoine du Hamel <[email protected]>
bmeck pushed a commit to bmeck/node that referenced this pull request Jun 22, 2024
@gibbyfree@bmeck
test: use for-of instead of forEach
934ca8b
PR-URL: nodejs#49790 Reviewed-By: Tobias Nießen <[email protected]> Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: Ruy Adorno <[email protected]> Reviewed-By: Antoine du Hamel <[email protected]>
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@ruyadornoruyadornoruyadorno approved these changes

@lpincalpincalpinca approved these changes

@tniessentniessentniessen approved these changes

@aduh95aduh95aduh95 approved these changes

Assignees

No one assigned

Labels

author readyPRs that have at least one approval, no pending requests for changes, and a CI started.code-and-learnIssues related to the Code-and-Learn events and PRs submitted during the events.commit-queue-squashAdd this label to instruct the Commit Queue to squash all the PR commits into the first one.needs-ciPRs that need a full CI run.testIssues and PRs related to the tests.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

7 participants

@gibbyfree@nodejs-github-bot@aduh95@ruyadorno@lpinca@tniessen@RafaelGSS