test: replace forEach with for..of in test-fs-realpath-buffer-encoding#49804
Uh oh!
There was an error while loading. Please reload this page.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
nodejs-github-bot added needs-ci 
ContributorAuthor
niyashiyas commented Sep 23, 2023
Changed file test-fs-realpath-buffer-encoding.js |
tniessen added the code-and-learn Uh oh!
There was an error while loading. Please reload this page.
ContributorAuthor
niyashiyas commented Sep 24, 2023
I've made the required changes. Please review again. |
trivikr approved these changes Sep 25, 2023
tniessen approved these changes Sep 25, 2023
github-actionsbot removed the request-ci 
Collaborator
nodejs-github-bot commented Sep 25, 2023
This was referenced Sep 27, 2023
niyashiyasforce-pushed the test-fs-realpath branch from 11ee8cc to 13fb7dcCompareniyashiyasforce-pushed the test-fs-realpath branch from 13fb7dc to af311e7Compare
lpinca added request-ci github-actionsbot removed the request-ci Collaborator
nodejs-github-bot commented Oct 21, 2023
lpinca added the commit-queue nodejs-github-bot added commit-queue-failed Collaborator
nodejs-github-bot commented Oct 21, 2023
Commit Queue failed- Loading data for nodejs/node/pull/49804 ✔ Done loading data for nodejs/node/pull/49804 ----------------------------------- PR info ------------------------------------ Title test: replace forEach with for..of in test-fs-realpath-buffer-encoding (#49804) ⚠ Could not retrieve the email or name of the PR author's from user's GitHub profile! Branch niyashiyas:test-fs-realpath -> nodejs:main Labels test, code-and-learn, needs-ci, commit-queue-squash Commits 3 - test: replace forEach with for..of in test-fs-realpath-buffer-encoding - test: replace forEach with for..of in test-fs-readv.js - test: replace forEach with for..of in test-fs-realpath-buffer-encoding Committers 1 - Niya Shiyas PR-URL: https://github.com/nodejs/node/pull/49804 Reviewed-By: Trivikram Kamat Reviewed-By: Tobias Nießen ------------------------------ Generated metadata ------------------------------ PR-URL: https://github.com/nodejs/node/pull/49804 Reviewed-By: Trivikram Kamat Reviewed-By: Tobias Nießen -------------------------------------------------------------------------------- ⚠ Commits were pushed since the last approving review: ⚠ - test: replace forEach with for..of in test-fs-realpath-buffer-encoding ⚠ - test: replace forEach with for..of in test-fs-readv.js ⚠ - test: replace forEach with for..of in test-fs-realpath-buffer-encoding ℹ This PR was created on Sat, 23 Sep 2023 06:14:31 GMT ✔ Approvals: 2 ✔ - Trivikram Kamat (@trivikr): https://github.com/nodejs/node/pull/49804#pullrequestreview-1641281338 ✔ - Tobias Nießen (@tniessen) (TSC): https://github.com/nodejs/node/pull/49804#pullrequestreview-1642000311 ℹ This PR is being fast-tracked because it is from a Code and Learn event ✘ Last GitHub CI failed ℹ Last Full PR CI on 2023-10-21T04:56:27Z: https://ci.nodejs.org/job/node-test-pull-request/55081/ - Querying data for job/node-test-pull-request/55081/ ✔ Last Jenkins CI successful -------------------------------------------------------------------------------- ✔ Aborted `git node land` session in /home/runner/work/node/node/.ncuhttps://github.com/nodejs/node/actions/runs/6597965086 |
ZYSzys approved these changes Oct 22, 2023
jasnell approved these changes Oct 28, 2023
lpinca pushed a commit that referenced this pull request Nov 2, 2023
PR-URL: #49804 Reviewed-By: Trivikram Kamat <[email protected]> Reviewed-By: Tobias Nießen <[email protected]> Reviewed-By: Yongsheng Zhang <[email protected]> Reviewed-By: James M Snell <[email protected]>
Member
lpinca commented Nov 2, 2023
Landed in a1693c6. |
anonrig pushed a commit to anonrig/node that referenced this pull request Nov 9, 2023
PR-URL: nodejs#49804 Reviewed-By: Trivikram Kamat <[email protected]> Reviewed-By: Tobias Nießen <[email protected]> Reviewed-By: Yongsheng Zhang <[email protected]> Reviewed-By: James M Snell <[email protected]>
targos pushed a commit that referenced this pull request Nov 11, 2023
PR-URL: #49804 Reviewed-By: Trivikram Kamat <[email protected]> Reviewed-By: Tobias Nießen <[email protected]> Reviewed-By: Yongsheng Zhang <[email protected]> Reviewed-By: James M Snell <[email protected]>
targos pushed a commit that referenced this pull request Nov 14, 2023
PR-URL: #49804 Reviewed-By: Trivikram Kamat <[email protected]> Reviewed-By: Tobias Nießen <[email protected]> Reviewed-By: Yongsheng Zhang <[email protected]> Reviewed-By: James M Snell <[email protected]>
UlisesGascon pushed a commit that referenced this pull request Dec 11, 2023
PR-URL: #49804 Reviewed-By: Trivikram Kamat <[email protected]> Reviewed-By: Tobias Nießen <[email protected]> Reviewed-By: Yongsheng Zhang <[email protected]> Reviewed-By: James M Snell <[email protected]>
Merged
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment
7 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Replaced forEach with for..of in test-fs-realpath-buffer-encoding.js