Skip to content

fs: improve error performance for rmdirSync#49846

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
nodejs-github-bot merged 1 commit into from
Nov 26, 2023
Merged

fs: improve error performance for rmdirSync#49846

nodejs-github-bot merged 1 commit into from
Nov 26, 2023

Conversation

@CanadaHonk
Copy link
Member

@CanadaHonkCanadaHonk commented Sep 25, 2023•
edited
Loading

Results from i9/Linux/SSD:

 confidence improvement accuracy (*) (**) (***) fs/bench-rmdirSync.js n=10000 type='existing' 0.54 % ±1.35% ±1.80% ±2.34% fs/bench-rmdirSync.js n=10000 type='non-existing' *** 61.81 % ±2.15% ±2.88% ±3.77%

Ref: nodejs/performance#106

Thanks to and inspiration from @anonrig 🚀

@nodejs-github-botnodejs-github-bot added c++ Issues and PRs that require attention from people who are familiar with C++. fs Issues and PRs related to the fs subsystem / file system. needs-ci PRs that need a full CI run. labels Sep 25, 2023
anonrig
anonrig reviewed Sep 25, 2023
View reviewed changes
@anonriganonrig mentioned this pull request Sep 25, 2023
Open
anonrig
anonrig reviewed Sep 25, 2023
View reviewed changes
@CanadaHonk
Copy link
MemberAuthor

CanadaHonk commented Sep 25, 2023

Updated to fix all things mentioned in review, thanks!

@CanadaHonkCanadaHonk changed the title fs: improve performance for fs.rmdirSyncfs: improve error performance for fs.rmdirSyncSep 25, 2023
@anonriganonrig added performance Issues and PRs related to the performance of Node.js. author ready PRs that have at least one approval, no pending requests for changes, and a CI started. request-ci Add this label to start a Jenkins CI on a PR. needs-benchmark-ci PR that need a benchmark CI run. labels Sep 25, 2023
@github-actionsgithub-actionsbot removed the request-ci Add this label to start a Jenkins CI on a PR. label Sep 25, 2023
@nodejs-github-bot

This comment was marked as outdated.

Sign in to view
@anonriganonrig added the request-ci Add this label to start a Jenkins CI on a PR. label Sep 25, 2023
@github-actionsgithub-actionsbot removed the request-ci Add this label to start a Jenkins CI on a PR. label Sep 25, 2023
@nodejs-github-bot

This comment was marked as outdated.

Sign in to view
@CanadaHonkCanadaHonk changed the title fs: improve error performance for fs.rmdirSyncfs: improve error performance for rmdirSyncSep 25, 2023
@anonriganonrig added the request-ci Add this label to start a Jenkins CI on a PR. label Sep 25, 2023
@github-actionsgithub-actionsbot removed the request-ci Add this label to start a Jenkins CI on a PR. label Sep 25, 2023
@nodejs-github-bot

This comment was marked as outdated.

Sign in to view
@nodejs-github-bot

This comment was marked as outdated.

Sign in to view
@CanadaHonk
Copy link
MemberAuthor

CanadaHonk commented Sep 25, 2023

Flaky CI I think?

@nodejs-github-bot

This comment was marked as outdated.

Sign in to view
@CanadaHonk
Copy link
MemberAuthor

CanadaHonk commented Sep 26, 2023

Flaky CI again? 😅

@nodejs-github-bot

This comment was marked as outdated.

Sign in to view
@richardlaurichardlau added the request-ci Add this label to start a Jenkins CI on a PR. label Sep 26, 2023
@github-actionsgithub-actionsbot removed the request-ci Add this label to start a Jenkins CI on a PR. label Sep 26, 2023
@anonriganonrig added the request-ci Add this label to start a Jenkins CI on a PR. label Oct 15, 2023
@github-actionsgithub-actionsbot removed the request-ci Add this label to start a Jenkins CI on a PR. label Oct 15, 2023
@nodejs-github-bot
Copy link
Collaborator

nodejs-github-bot commented Oct 15, 2023

CI: https://ci.nodejs.org/job/node-test-pull-request/54829/

@nodejs-github-bot
Copy link
Collaborator

nodejs-github-bot commented Oct 17, 2023

CI: https://ci.nodejs.org/job/node-test-pull-request/54897/

@github-actionsgithub-actionsbot mentioned this pull request Oct 19, 2023
Open
25 tasks
@CanadaHonk
Copy link
MemberAuthor

CanadaHonk commented Nov 19, 2023

Rebased on latest main and updated description with rebenchmark.

@anonriganonrig added the request-ci Add this label to start a Jenkins CI on a PR. label Nov 19, 2023
@github-actionsgithub-actionsbot removed the request-ci Add this label to start a Jenkins CI on a PR. label Nov 19, 2023
@nodejs-github-bot
Copy link
Collaborator

nodejs-github-bot commented Nov 19, 2023

CI: https://ci.nodejs.org/job/node-test-pull-request/55773/

@CanadaHonk
Copy link
MemberAuthor

CanadaHonk commented Nov 21, 2023

Flaky CI?

@nodejs-github-bot
Copy link
Collaborator

nodejs-github-bot commented Nov 21, 2023

CI: https://ci.nodejs.org/job/node-test-pull-request/55837/

@nodejs-github-bot
Copy link
Collaborator

nodejs-github-bot commented Nov 23, 2023

CI: https://ci.nodejs.org/job/node-test-pull-request/55862/

@H4adH4ad added the commit-queue Add this label to land a pull request using GitHub Actions. label Nov 26, 2023
@nodejs-github-botnodejs-github-bot removed the commit-queue Add this label to land a pull request using GitHub Actions. label Nov 26, 2023
@nodejs-github-botnodejs-github-bot merged commit f11b206 into nodejs:mainNov 26, 2023
@nodejs-github-bot
Copy link
Collaborator

nodejs-github-bot commented Nov 26, 2023

Landed in f11b206

lucshi pushed a commit to lucshi/node that referenced this pull request Nov 27, 2023
@CanadaHonk
fs: improve error performance for rmdirSync
31e837c
PR-URL: nodejs#49846 Refs: nodejs/performance#106 Reviewed-By: Yagiz Nizipli <[email protected]> Reviewed-By: Joyee Cheung <[email protected]> Reviewed-By: Vinícius Lourenço Claro Cardoso <[email protected]>
RafaelGSS pushed a commit that referenced this pull request Nov 27, 2023
@CanadaHonk@RafaelGSS
fs: improve error performance for rmdirSync
c4f9654
PR-URL: #49846 Refs: nodejs/performance#106 Reviewed-By: Yagiz Nizipli <[email protected]> Reviewed-By: Joyee Cheung <[email protected]> Reviewed-By: Vinícius Lourenço Claro Cardoso <[email protected]>
@RafaelGSSRafaelGSS mentioned this pull request Nov 28, 2023
Merged
RafaelGSS pushed a commit that referenced this pull request Nov 29, 2023
@CanadaHonk@RafaelGSS
fs: improve error performance for rmdirSync
483200f
PR-URL: #49846 Refs: nodejs/performance#106 Reviewed-By: Yagiz Nizipli <[email protected]> Reviewed-By: Joyee Cheung <[email protected]> Reviewed-By: Vinícius Lourenço Claro Cardoso <[email protected]>
RafaelGSS pushed a commit that referenced this pull request Nov 30, 2023
@CanadaHonk@RafaelGSS
fs: improve error performance for rmdirSync
d44dd9b
PR-URL: #49846 Refs: nodejs/performance#106 Reviewed-By: Yagiz Nizipli <[email protected]> Reviewed-By: Joyee Cheung <[email protected]> Reviewed-By: Vinícius Lourenço Claro Cardoso <[email protected]>
UlisesGascon pushed a commit that referenced this pull request Dec 11, 2023
@CanadaHonk@UlisesGascon
fs: improve error performance for rmdirSync
7a09209
PR-URL: #49846 Refs: nodejs/performance#106 Reviewed-By: Yagiz Nizipli <[email protected]> Reviewed-By: Joyee Cheung <[email protected]> Reviewed-By: Vinícius Lourenço Claro Cardoso <[email protected]>
@UlisesGasconUlisesGascon mentioned this pull request Dec 12, 2023
Merged
UlisesGascon pushed a commit that referenced this pull request Dec 13, 2023
@CanadaHonk@UlisesGascon
fs: improve error performance for rmdirSync
cb55d04
PR-URL: #49846 Refs: nodejs/performance#106 Reviewed-By: Yagiz Nizipli <[email protected]> Reviewed-By: Joyee Cheung <[email protected]> Reviewed-By: Vinícius Lourenço Claro Cardoso <[email protected]>
UlisesGascon pushed a commit that referenced this pull request Dec 15, 2023
@CanadaHonk@UlisesGascon
fs: improve error performance for rmdirSync
0d59dda
PR-URL: #49846 Refs: nodejs/performance#106 Reviewed-By: Yagiz Nizipli <[email protected]> Reviewed-By: Joyee Cheung <[email protected]> Reviewed-By: Vinícius Lourenço Claro Cardoso <[email protected]>
UlisesGascon pushed a commit that referenced this pull request Dec 19, 2023
@CanadaHonk@UlisesGascon
fs: improve error performance for rmdirSync
f94a24c
PR-URL: #49846 Refs: nodejs/performance#106 Reviewed-By: Yagiz Nizipli <[email protected]> Reviewed-By: Joyee Cheung <[email protected]> Reviewed-By: Vinícius Lourenço Claro Cardoso <[email protected]>
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@anonriganonriganonrig approved these changes

@joyeecheungjoyeecheungjoyeecheung approved these changes

@H4adH4adH4ad approved these changes

Assignees

No one assigned

Labels

author readyPRs that have at least one approval, no pending requests for changes, and a CI started.c++Issues and PRs that require attention from people who are familiar with C++.fsIssues and PRs related to the fs subsystem / file system.needs-benchmark-ciPR that need a benchmark CI run.needs-ciPRs that need a full CI run.performanceIssues and PRs related to the performance of Node.js.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

7 participants

@CanadaHonk@nodejs-github-bot@anonrig@IlyasShabi@joyeecheung@H4ad@richardlau