Skip to content

fs: improve error performance for mkdirSync#49847

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
nodejs-github-bot merged 1 commit into from
Oct 20, 2023
Merged

fs: improve error performance for mkdirSync#49847

nodejs-github-bot merged 1 commit into from
Oct 20, 2023

Conversation

@CanadaHonk
Copy link
Member

@CanadaHonkCanadaHonk commented Sep 25, 2023

Results from i7 Windows laptop:

 confidence improvement accuracy (*) (**) (***) fs\bench-mkdirSync.js n=1000 recursive='false' type='existing' *** 66.99 % ±3.62% ±4.85% ±6.38% fs\bench-mkdirSync.js n=1000 recursive='false' type='non-existing' 3.40 % ±4.02% ±5.35% ±6.96% fs\bench-mkdirSync.js n=1000 recursive='true' type='existing' 4.32 % ±5.81% ±7.76% ±10.16% fs\bench-mkdirSync.js n=1000 recursive='true' type='non-existing' * 3.36 % ±2.72% ±3.62% ±4.71%

Ref: nodejs/performance#106

@nodejs-github-botnodejs-github-bot added c++ Issues and PRs that require attention from people who are familiar with C++. fs Issues and PRs related to the fs subsystem / file system. needs-ci PRs that need a full CI run. labels Sep 25, 2023
anonrig
anonrig reviewed Sep 25, 2023
View reviewed changes
@CanadaHonk
Copy link
MemberAuthor

CanadaHonk commented Sep 25, 2023

Updated to fix all review comments, thanks!

@anonriganonrig added performance Issues and PRs related to the performance of Node.js. author ready PRs that have at least one approval, no pending requests for changes, and a CI started. request-ci Add this label to start a Jenkins CI on a PR. labels Sep 25, 2023
@anonriganonrig mentioned this pull request Sep 25, 2023
Open
@github-actionsgithub-actionsbot removed the request-ci Add this label to start a Jenkins CI on a PR. label Sep 25, 2023
@nodejs-github-bot
Copy link
Collaborator

nodejs-github-bot commented Sep 25, 2023

CI: https://ci.nodejs.org/job/node-test-pull-request/54210/

@anonriganonrig added the request-ci Add this label to start a Jenkins CI on a PR. label Sep 25, 2023
@github-actionsgithub-actionsbot removed the request-ci Add this label to start a Jenkins CI on a PR. label Sep 25, 2023
@nodejs-github-bot
Copy link
Collaborator

nodejs-github-bot commented Sep 25, 2023

CI: https://ci.nodejs.org/job/node-test-pull-request/54231/

@CanadaHonk
Copy link
MemberAuthor

CanadaHonk commented Sep 25, 2023

Flaky CI?

@nodejs-github-bot
Copy link
Collaborator

nodejs-github-bot commented Sep 25, 2023

CI: https://ci.nodejs.org/job/node-test-pull-request/54238/

@CanadaHonk
Copy link
MemberAuthor

CanadaHonk commented Sep 26, 2023

Broken (empty?) CI again?

@CanadaHonk
Copy link
MemberAuthor

CanadaHonk commented Sep 26, 2023

Rebased on latest main to fix merge conflict.

@anonriganonrig added the request-ci Add this label to start a Jenkins CI on a PR. label Sep 26, 2023
@github-actionsgithub-actionsbot removed the request-ci Add this label to start a Jenkins CI on a PR. label Sep 26, 2023
@nodejs-github-bot
Copy link
Collaborator

nodejs-github-bot commented Sep 26, 2023

CI: https://ci.nodejs.org/job/node-test-pull-request/54242/

@nodejs-github-bot
Copy link
Collaborator

nodejs-github-bot commented Sep 26, 2023

CI: https://ci.nodejs.org/job/node-test-pull-request/54255/

@github-actionsgithub-actionsbot mentioned this pull request Sep 27, 2023
Open
21 tasks
@anonrig
Copy link
Member

anonrig commented Sep 27, 2023

@CanadaHonk can you resolve the conflicts?

@anonriganonrig added commit-queue-squash Add this label to instruct the Commit Queue to squash all the PR commits into the first one. request-ci Add this label to start a Jenkins CI on a PR. labels Sep 27, 2023
@joyeecheung
Copy link
Member

joyeecheung commented Oct 2, 2023

#49913 has landed. Can you move the JS code back to lib/fs.js and switch to use SyncCallAndThrowOnError in the original implementation instead of introducing a new binding? Thanks.

@anonriganonrig added request-ci Add this label to start a Jenkins CI on a PR. and removed commit-queue-squash Add this label to instruct the Commit Queue to squash all the PR commits into the first one. labels Oct 11, 2023
@github-actionsgithub-actionsbot removed the request-ci Add this label to start a Jenkins CI on a PR. label Oct 11, 2023
@nodejs-github-bot
Copy link
Collaborator

nodejs-github-bot commented Oct 11, 2023

CI: https://ci.nodejs.org/job/node-test-pull-request/54711/

@anonriganonrig added the request-ci Add this label to start a Jenkins CI on a PR. label Oct 11, 2023
@github-actionsgithub-actionsbot removed the request-ci Add this label to start a Jenkins CI on a PR. label Oct 11, 2023
@nodejs-github-bot
Copy link
Collaborator

nodejs-github-bot commented Oct 11, 2023

CI: https://ci.nodejs.org/job/node-test-pull-request/54717/

joyeecheung
joyeecheung reviewed Oct 12, 2023
View reviewed changes
@anonriganonrig added the request-ci Add this label to start a Jenkins CI on a PR. label Oct 17, 2023
@github-actionsgithub-actionsbot removed the request-ci Add this label to start a Jenkins CI on a PR. label Oct 17, 2023
@nodejs-github-bot
Copy link
Collaborator

nodejs-github-bot commented Oct 17, 2023

CI: https://ci.nodejs.org/job/node-test-pull-request/54898/

@github-actionsgithub-actionsbot mentioned this pull request Oct 19, 2023
Open
25 tasks
@nodejs-github-bot
Copy link
Collaborator

nodejs-github-bot commented Oct 19, 2023

CI: https://ci.nodejs.org/job/node-test-pull-request/55006/

@anonriganonrig added the commit-queue Add this label to land a pull request using GitHub Actions. label Oct 20, 2023
@nodejs-github-botnodejs-github-bot removed the commit-queue Add this label to land a pull request using GitHub Actions. label Oct 20, 2023
@nodejs-github-botnodejs-github-bot merged commit c37cf18 into nodejs:mainOct 20, 2023
@nodejs-github-bot
Copy link
Collaborator

nodejs-github-bot commented Oct 20, 2023

Landed in c37cf18

targos pushed a commit that referenced this pull request Oct 23, 2023
@CanadaHonk@targos
fs: improve error performance for mkdirSync
6ec5aba
PR-URL: #49847 Refs: nodejs/performance#106 Reviewed-By: Yagiz Nizipli <[email protected]> Reviewed-By: Joyee Cheung <[email protected]>
@targostargos mentioned this pull request Oct 23, 2023
Merged
alexfernandez pushed a commit to alexfernandez/node that referenced this pull request Nov 1, 2023
@CanadaHonk@alexfernandez
fs: improve error performance for mkdirSync
a4756a6
PR-URL: nodejs#49847 Refs: nodejs/performance#106 Reviewed-By: Yagiz Nizipli <[email protected]> Reviewed-By: Joyee Cheung <[email protected]>
targos pushed a commit that referenced this pull request Nov 11, 2023
@CanadaHonk@targos
fs: improve error performance for mkdirSync
8d0edc6
PR-URL: #49847 Refs: nodejs/performance#106 Reviewed-By: Yagiz Nizipli <[email protected]> Reviewed-By: Joyee Cheung <[email protected]>
@targostargos mentioned this pull request Nov 12, 2023
Merged
@juanarboljuanarbol mentioned this pull request Dec 6, 2023
Merged
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@anonriganonriganonrig approved these changes

@joyeecheungjoyeecheungjoyeecheung approved these changes

Assignees

No one assigned

Labels

author readyPRs that have at least one approval, no pending requests for changes, and a CI started.c++Issues and PRs that require attention from people who are familiar with C++.fsIssues and PRs related to the fs subsystem / file system.needs-ciPRs that need a full CI run.performanceIssues and PRs related to the performance of Node.js.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@CanadaHonk@nodejs-github-bot@anonrig@joyeecheung