Skip to content

test: deflake test-runner-output#49878

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
nodejs-github-bot merged 1 commit into from
Sep 26, 2023
Merged

test: deflake test-runner-output #49878

nodejs-github-bot merged 1 commit into from
Sep 26, 2023

Conversation

@MoLow
Copy link
Member

@MoLowMoLow commented Sep 26, 2023

Fixes: #49853

@nodejs-github-bot
Copy link
Collaborator

nodejs-github-bot commented Sep 26, 2023

Review requested:

  • @nodejs/test_runner

@nodejs-github-botnodejs-github-bot added needs-ci PRs that need a full CI run. test Issues and PRs related to the tests. labels Sep 26, 2023
cjihrig
cjihrig approved these changes Sep 26, 2023
View reviewed changes
Copy link
Contributor

@cjihrigcjihrig left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Great job with #49853 (comment)

@lpincalpinca added the request-ci Add this label to start a Jenkins CI on a PR. label Sep 26, 2023
@MoLowMoLow added the author ready PRs that have at least one approval, no pending requests for changes, and a CI started. label Sep 26, 2023
@github-actionsgithub-actionsbot removed the request-ci Add this label to start a Jenkins CI on a PR. label Sep 26, 2023
@nodejs-github-bot
Copy link
Collaborator

nodejs-github-bot commented Sep 26, 2023

CI: https://ci.nodejs.org/job/node-test-pull-request/54258/

@GeoffreyBoothGeoffreyBooth added the fast-track PRs that do not need to wait for 48 hours to land. label Sep 26, 2023
@github-actions
Copy link
Contributor

github-actionsbot commented Sep 26, 2023

Fast-track has been requested by @GeoffreyBooth. Please 👍 to approve.

@MoLowMoLow added the commit-queue Add this label to land a pull request using GitHub Actions. label Sep 26, 2023
@nodejs-github-botnodejs-github-bot removed the commit-queue Add this label to land a pull request using GitHub Actions. label Sep 26, 2023
@nodejs-github-botnodejs-github-bot merged commit fef7927 into nodejs:mainSep 26, 2023
@nodejs-github-bot
Copy link
Collaborator

nodejs-github-bot commented Sep 26, 2023

Landed in fef7927

@MoLowMoLow deleted the deflake-test-runner branch September 26, 2023 23:03
ruyadorno pushed a commit that referenced this pull request Sep 28, 2023
@MoLow@ruyadorno
test: deflake test-runner-output
d44a812
PR-URL: #49878Fixes: #49853 Reviewed-By: Benjamin Gruenbaum <[email protected]> Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: Geoffrey Booth <[email protected]> Reviewed-By: Chemi Atlow <[email protected]>
@ruyadornoruyadorno mentioned this pull request Sep 28, 2023
Closed
ruyadorno pushed a commit that referenced this pull request Sep 28, 2023
@MoLow@ruyadorno
test: deflake test-runner-output
5f02711
PR-URL: #49878Fixes: #49853 Reviewed-By: Benjamin Gruenbaum <[email protected]> Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: Geoffrey Booth <[email protected]> Reviewed-By: Chemi Atlow <[email protected]>
@ruyadornoruyadorno mentioned this pull request Sep 28, 2023
Merged
alexfernandez pushed a commit to alexfernandez/node that referenced this pull request Nov 1, 2023
@MoLow@alexfernandez
test: deflake test-runner-output
0b466ec
PR-URL: nodejs#49878Fixes: nodejs#49853 Reviewed-By: Benjamin Gruenbaum <[email protected]> Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: Geoffrey Booth <[email protected]> Reviewed-By: Chemi Atlow <[email protected]>
targos pushed a commit that referenced this pull request Nov 27, 2023
@MoLow@targos
test: deflake test-runner-output
5820d7e
PR-URL: #49878Fixes: #49853 Reviewed-By: Benjamin Gruenbaum <[email protected]> Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: Geoffrey Booth <[email protected]> Reviewed-By: Chemi Atlow <[email protected]>
@targostargos mentioned this pull request Nov 28, 2023
Merged
debadree25 pushed a commit to debadree25/node that referenced this pull request Apr 15, 2024
@MoLow@debadree25
test: deflake test-runner-output
c496080
PR-URL: nodejs#49878Fixes: nodejs#49853 Reviewed-By: Benjamin Gruenbaum <[email protected]> Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: Geoffrey Booth <[email protected]> Reviewed-By: Chemi Atlow <[email protected]>
sercher added a commit to sercher/graaljs that referenced this pull request Apr 25, 2024
@sercher
test: deflake test-runner-output
f5040dc
PR-URL: nodejs/node#49878Fixes: nodejs/node#49853 Reviewed-By: Benjamin Gruenbaum <[email protected]> Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: Geoffrey Booth <[email protected]> Reviewed-By: Chemi Atlow <[email protected]>
sercher added a commit to sercher/graaljs that referenced this pull request Apr 25, 2024
@sercher
test: deflake test-runner-output
bd80ca5
PR-URL: nodejs/node#49878Fixes: nodejs/node#49853 Reviewed-By: Benjamin Gruenbaum <[email protected]> Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: Geoffrey Booth <[email protected]> Reviewed-By: Chemi Atlow <[email protected]>
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@GeoffreyBoothGeoffreyBoothGeoffreyBooth approved these changes

@benjamingrbenjamingrbenjamingr approved these changes

@lpincalpincalpinca approved these changes

@cjihrigcjihrigcjihrig approved these changes

@atlowChemiatlowChemiatlowChemi approved these changes

Assignees

No one assigned

Labels

author readyPRs that have at least one approval, no pending requests for changes, and a CI started.fast-trackPRs that do not need to wait for 48 hours to land.needs-ciPRs that need a full CI run.testIssues and PRs related to the tests.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

parallel/test-runner-output is flaky

7 participants

@MoLow@nodejs-github-bot@GeoffreyBooth@benjamingr@lpinca@cjihrig@atlowChemi