meta: update website team with new name#49883
Merged
Uh oh!
There was an error while loading. Please reload this page.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Collaborator
nodejs-github-bot commented Sep 26, 2023
Review requested:
|
MemberAuthor
Trott commented Sep 26, 2023
nodejs-github-bot added the meta 
Contributor
Fast-track has been requested by @Trott. Please 👍 to approve. |
anonrig approved these changes Sep 26, 2023
aduh95 approved these changes Sep 26, 2023
ovflowd approved these changes Sep 26, 2023
Member
@Trott can you update the PR? The correct team here would be (Due to this being a more technical + infrastructure part (the API tooling)) |
MoLow approved these changes Sep 26, 2023
MemberAuthor
Are you sure about that? I mean, maybe the |
Member
ovflowd commented Sep 26, 2023
That's fair. Let's keep for the template to the website and tooling to web-infra |
RaisinTen approved these changes Sep 27, 2023
tniessen approved these changes Sep 27, 2023
ovflowd reviewed Sep 27, 2023
Uh oh!
There was an error while loading. Please reload this page.
lpinca approved these changes Sep 27, 2023
Trott added commit-queue-squash nodejs-github-bot added commit-queue-failed Collaborator
nodejs-github-bot commented Sep 28, 2023
Commit Queue failed- Loading data for nodejs/node/pull/49883 ✔ Done loading data for nodejs/node/pull/49883 ----------------------------------- PR info ------------------------------------ Title meta: update website team with new name (#49883) Author Rich Trott (@Trott) Branch Trott:codeowners -> nodejs:main Labels meta, fast-track, commit-queue-squash Commits 5 - meta: update website team with new name - Merge branch 'main' into codeowners - Merge branch 'main' into codeowners - Update .github/CODEOWNERS - Merge branch 'main' into codeowners Committers 2 - Rich Trott - GitHub PR-URL: https://github.com/nodejs/node/pull/49883 Reviewed-By: Yagiz Nizipli Reviewed-By: Antoine du Hamel Reviewed-By: Claudio Wunder Reviewed-By: Moshe Atlow Reviewed-By: Darshan Sen Reviewed-By: Tobias Nießen Reviewed-By: Luigi Pinca ------------------------------ Generated metadata ------------------------------ PR-URL: https://github.com/nodejs/node/pull/49883 Reviewed-By: Yagiz Nizipli Reviewed-By: Antoine du Hamel Reviewed-By: Claudio Wunder Reviewed-By: Moshe Atlow Reviewed-By: Darshan Sen Reviewed-By: Tobias Nießen Reviewed-By: Luigi Pinca -------------------------------------------------------------------------------- ⚠ Commits were pushed since the last approving review: ⚠ - Update .github/CODEOWNERS ⚠ - Merge branch 'main' into codeowners ℹ This PR was created on Tue, 26 Sep 2023 18:28:51 GMT ✔ Approvals: 7 ✔ - Yagiz Nizipli (@anonrig) (TSC): https://github.com/nodejs/node/pull/49883#pullrequestreview-1644961950 ✔ - Antoine du Hamel (@aduh95) (TSC): https://github.com/nodejs/node/pull/49883#pullrequestreview-1645005247 ✔ - Claudio Wunder (@ovflowd): https://github.com/nodejs/node/pull/49883#pullrequestreview-1645020927 ✔ - Moshe Atlow (@MoLow) (TSC): https://github.com/nodejs/node/pull/49883#pullrequestreview-1645030663 ✔ - Darshan Sen (@RaisinTen) (TSC): https://github.com/nodejs/node/pull/49883#pullrequestreview-1645620447 ✔ - Tobias Nießen (@tniessen) (TSC): https://github.com/nodejs/node/pull/49883#pullrequestreview-1647064713 ✔ - Luigi Pinca (@lpinca): https://github.com/nodejs/node/pull/49883#pullrequestreview-1647488560 ℹ This PR is being fast-tracked ✔ Last GitHub CI successful ℹ Green GitHub CI is sufficient -------------------------------------------------------------------------------- ✔ Aborted `git node land` session in /home/runner/work/node/node/.ncuhttps://github.com/nodejs/node/actions/runs/6344268112 |
Pings for the website team aren't working because the team name changed but it did not get updated in CODEOWNERS. PR-URL: nodejs#49883 Reviewed-By: Yagiz Nizipli <[email protected]> Reviewed-By: Antoine du Hamel <[email protected]> Reviewed-By: Claudio Wunder <[email protected]> Reviewed-By: Moshe Atlow <[email protected]> Reviewed-By: Darshan Sen <[email protected]> Reviewed-By: Tobias Nießen <[email protected]> Reviewed-By: Luigi Pinca <[email protected]>
MemberAuthor
Trott commented Sep 28, 2023
Landed in 0fe673c |
alexfernandez pushed a commit to alexfernandez/node that referenced this pull request Nov 1, 2023
Pings for the website team aren't working because the team name changed but it did not get updated in CODEOWNERS. PR-URL: nodejs#49883 Reviewed-By: Yagiz Nizipli <[email protected]> Reviewed-By: Antoine du Hamel <[email protected]> Reviewed-By: Claudio Wunder <[email protected]> Reviewed-By: Moshe Atlow <[email protected]> Reviewed-By: Darshan Sen <[email protected]> Reviewed-By: Tobias Nießen <[email protected]> Reviewed-By: Luigi Pinca <[email protected]>
targos pushed a commit that referenced this pull request Nov 11, 2023
Pings for the website team aren't working because the team name changed but it did not get updated in CODEOWNERS. PR-URL: #49883 Reviewed-By: Yagiz Nizipli <[email protected]> Reviewed-By: Antoine du Hamel <[email protected]> Reviewed-By: Claudio Wunder <[email protected]> Reviewed-By: Moshe Atlow <[email protected]> Reviewed-By: Darshan Sen <[email protected]> Reviewed-By: Tobias Nießen <[email protected]> Reviewed-By: Luigi Pinca <[email protected]>
targos pushed a commit that referenced this pull request Nov 27, 2023
Pings for the website team aren't working because the team name changed but it did not get updated in CODEOWNERS. PR-URL: #49883 Reviewed-By: Yagiz Nizipli <[email protected]> Reviewed-By: Antoine du Hamel <[email protected]> Reviewed-By: Claudio Wunder <[email protected]> Reviewed-By: Moshe Atlow <[email protected]> Reviewed-By: Darshan Sen <[email protected]> Reviewed-By: Tobias Nießen <[email protected]> Reviewed-By: Luigi Pinca <[email protected]>
debadree25 pushed a commit to debadree25/node that referenced this pull request Apr 15, 2024
Pings for the website team aren't working because the team name changed but it did not get updated in CODEOWNERS. PR-URL: nodejs#49883 Reviewed-By: Yagiz Nizipli <[email protected]> Reviewed-By: Antoine du Hamel <[email protected]> Reviewed-By: Claudio Wunder <[email protected]> Reviewed-By: Moshe Atlow <[email protected]> Reviewed-By: Darshan Sen <[email protected]> Reviewed-By: Tobias Nießen <[email protected]> Reviewed-By: Luigi Pinca <[email protected]>
sercher added a commit to sercher/graaljs that referenced this pull request Apr 25, 2024
Pings for the website team aren't working because the team name changed but it did not get updated in CODEOWNERS. PR-URL: nodejs/node#49883 Reviewed-By: Yagiz Nizipli <[email protected]> Reviewed-By: Antoine du Hamel <[email protected]> Reviewed-By: Claudio Wunder <[email protected]> Reviewed-By: Moshe Atlow <[email protected]> Reviewed-By: Darshan Sen <[email protected]> Reviewed-By: Tobias Nießen <[email protected]> Reviewed-By: Luigi Pinca <[email protected]>
sercher added a commit to sercher/graaljs that referenced this pull request Apr 25, 2024
Pings for the website team aren't working because the team name changed but it did not get updated in CODEOWNERS. PR-URL: nodejs/node#49883 Reviewed-By: Yagiz Nizipli <[email protected]> Reviewed-By: Antoine du Hamel <[email protected]> Reviewed-By: Claudio Wunder <[email protected]> Reviewed-By: Moshe Atlow <[email protected]> Reviewed-By: Darshan Sen <[email protected]> Reviewed-By: Tobias Nießen <[email protected]> Reviewed-By: Luigi Pinca <[email protected]>
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment
9 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pings for the website team aren't working because the team name changed but it did not get updated in CODEOWNERS.