Skip to content

[v20.x backport] test_runner: catch reporter errors#49941

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
MoLow wants to merge 1 commit into from
Closed

[v20.x backport] test_runner: catch reporter errors #49941

MoLow wants to merge 1 commit into from

Conversation

@MoLow
Copy link
Member

@MoLowMoLow commented Sep 28, 2023

Backporting #49646

@MoLow
test_runner: catch reporter errors
0e27a7a
PR-URL: nodejs#49646Fixes: nodejs#48937 Reviewed-By: Chemi Atlow <[email protected]> Reviewed-By: Benjamin Gruenbaum <[email protected]> Reviewed-By: Colin Ihrig <[email protected]>
@nodejs-github-bot
Copy link
Collaborator

nodejs-github-bot commented Sep 28, 2023

Review requested:

  • @nodejs/test_runner

@nodejs-github-botnodejs-github-bot added needs-ci PRs that need a full CI run. test_runner Issues and PRs related to the test runner subsystem. v20.x Issues that can be reproduced on v20.x or PRs targeting the v20.x-staging branch. labels Sep 28, 2023
@MoLow
Copy link
MemberAuthor

MoLow commented Nov 8, 2023

@nodejs/releasers can this land?

@RafaelGSS
Copy link
Member

RafaelGSS commented Nov 10, 2023

@nodejs/releasers can this land?

We will land it when creating the release proposal and technically this PR needs Jenkins CI.

@RafaelGSSRafaelGSS mentioned this pull request Nov 10, 2023
Closed
@MoLowMoLow added the request-ci Add this label to start a Jenkins CI on a PR. label Nov 12, 2023
@github-actionsgithub-actionsbot removed the request-ci Add this label to start a Jenkins CI on a PR. label Nov 12, 2023
@nodejs-github-bot
Copy link
Collaborator

nodejs-github-bot commented Nov 12, 2023

CI: https://ci.nodejs.org/job/node-test-pull-request/55591/

@targos
Copy link
Member

targos commented Nov 12, 2023

Commit landed cleanly after other ones and is part of #50682

@targostargos closed this Nov 12, 2023
@MoLowMoLow deleted the backport-print-report-errors branch May 24, 2024 09:01
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@rluvatonrluvatonrluvaton approved these changes

Assignees

No one assigned

Labels

needs-ciPRs that need a full CI run.test_runnerIssues and PRs related to the test runner subsystem.v20.xIssues that can be reproduced on v20.x or PRs targeting the v20.x-staging branch.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@MoLow@nodejs-github-bot@RafaelGSS@targos@rluvaton