esm: improve JSDoc annotation of internal functions#49959
Merged
Uh oh!
There was an error while loading. Please reload this page.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Collaborator
nodejs-github-bot commented Sep 29, 2023
Review requested:
|
aduh95 added fast-track 
Contributor
Fast-track has been requested by @aduh95. Please 👍 to approve. |
This comment was marked as resolved.
This comment was marked as resolved.
GeoffreyBooth approved these changes Sep 29, 2023
Co-authored-by: Geoffrey Booth <[email protected]>
GeoffreyBoothforce-pushed the run-main-typings branch from 1409d4a to 0fd188bCompare
atlowChemi approved these changes Oct 1, 2023
atlowChemi added commit-queue aduh95 removed the commit-queue ContributorAuthor
aduh95 commented Oct 1, 2023
Landed in aadfea4 |
alexfernandez pushed a commit to alexfernandez/node that referenced this pull request Nov 1, 2023
Co-authored-by: Geoffrey Booth <[email protected]> PR-URL: nodejs#49959 Reviewed-By: Geoffrey Booth <[email protected]> Reviewed-By: Chemi Atlow <[email protected]>
targos pushed a commit to targos/node that referenced this pull request Nov 11, 2023
Co-authored-by: Geoffrey Booth <[email protected]> PR-URL: nodejs#49959 Reviewed-By: Geoffrey Booth <[email protected]> Reviewed-By: Chemi Atlow <[email protected]>
targos pushed a commit to targos/node that referenced this pull request Nov 11, 2023
Co-authored-by: Geoffrey Booth <[email protected]> PR-URL: nodejs#49959 Reviewed-By: Geoffrey Booth <[email protected]> Reviewed-By: Chemi Atlow <[email protected]>
targos pushed a commit that referenced this pull request Nov 11, 2023
Co-authored-by: Geoffrey Booth <[email protected]> PR-URL: #49959 Reviewed-By: Geoffrey Booth <[email protected]> Reviewed-By: Chemi Atlow <[email protected]>
targos pushed a commit to targos/node that referenced this pull request Nov 11, 2023
Co-authored-by: Geoffrey Booth <[email protected]> PR-URL: nodejs#49959 Reviewed-By: Geoffrey Booth <[email protected]> Reviewed-By: Chemi Atlow <[email protected]>
targos pushed a commit that referenced this pull request Nov 23, 2023
Co-authored-by: Geoffrey Booth <[email protected]> PR-URL: #49959 Backport-PR-URL: #50669 Reviewed-By: Geoffrey Booth <[email protected]> Reviewed-By: Chemi Atlow <[email protected]>
debadree25 pushed a commit to debadree25/node that referenced this pull request Apr 15, 2024
Co-authored-by: Geoffrey Booth <[email protected]> PR-URL: nodejs#49959 Reviewed-By: Geoffrey Booth <[email protected]> Reviewed-By: Chemi Atlow <[email protected]>
sercher added a commit to sercher/graaljs that referenced this pull request Apr 25, 2024
Co-authored-by: Geoffrey Booth <[email protected]> PR-URL: nodejs/node#49959 Backport-PR-URL: nodejs/node#50669 Reviewed-By: Geoffrey Booth <[email protected]> Reviewed-By: Chemi Atlow <[email protected]>
sercher added a commit to sercher/graaljs that referenced this pull request Apr 25, 2024
Co-authored-by: Geoffrey Booth <[email protected]> PR-URL: nodejs/node#49959 Backport-PR-URL: nodejs/node#50669 Reviewed-By: Geoffrey Booth <[email protected]> Reviewed-By: Chemi Atlow <[email protected]>
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Extracted from #49918