esm: bypass CJS loader in default load under --default-type=module#50004
Uh oh!
There was an error while loading. Please reload this page.
Conversation
nodejs-github-bot commented Oct 1, 2023
Review requested:
|
nodejs-github-bot added esm 
GeoffreyBooth left a comment
GeoffreyBooth left a comment There was a problem hiding this comment.
I like it. I would maybe rephrase the PR description though, I think this more a continued expansion of the behavior of --default-type to mean “in module mode, the ESM loader is the only loader in use” which is what we want and was part of the proposal.
| }); | ||
| }); | ||
| it('should affect CJS .js files',async()=>{ |
There was a problem hiding this comment.
CJS .js files . . . that are required?
There was a problem hiding this comment.
that are required, imported, or used as entry point
There was a problem hiding this comment.
Might be worth spelling that out, I was assuming “CJS .js files” meant .js files required by CommonJS modules, rather than what I now presume you meant, “.js file that is interpreted as CommonJS.”
This allows user to opt-out from using the monkey-patchable CJS loader, even to load CJS modules.
aduh95 added author ready 
github-actionsbot removed the request-ci nodejs-github-bot commented Oct 27, 2023
github-actionsbot removed the request-ci nodejs-github-bot commented Nov 9, 2023
aduh95 commented Nov 10, 2023
Landed in 0dfc59e |
This allows user to opt-out from using the monkey-patchable CJS loader, even to load CJS modules. PR-URL: #50004 Reviewed-By: Geoffrey Booth <[email protected]>
This allows user to opt-out from using the monkey-patchable CJS loader, even to load CJS modules. PR-URL: #50004 Reviewed-By: Geoffrey Booth <[email protected]>
This allows user to opt-out from using the monkey-patchable CJS loader, even to load CJS modules. PR-URL: #50004 Reviewed-By: Geoffrey Booth <[email protected]>
3 participants
This allows user to opt-out from using the monkey-patchable CJS loader to load CJS modules.