Skip to content

Conversation

@dsanders11
Copy link
Contributor

This PR reserves NMV 119 for Electron 28.

@nodejs-github-botnodejs-github-bot added the doc Issues and PRs related to the documentations. label Oct 3, 2023
@dsanders11
Copy link
ContributorAuthor

Not sure if this will interfere with #49870, but happy to tweak it as needed.

@richardlaurichardlau added the commit-queue Add this label to land a pull request using GitHub Actions. label Oct 3, 2023
@targostargos added the fast-track PRs that do not need to wait for 48 hours to land. label Oct 3, 2023
@github-actions
Copy link
Contributor

Fast-track has been requested by @targos. Please 👍 to approve.

@nodejs-github-botnodejs-github-bot removed the commit-queue Add this label to land a pull request using GitHub Actions. label Oct 3, 2023
@nodejs-github-botnodejs-github-bot merged commit f3ed57b into nodejs:mainOct 3, 2023
@nodejs-github-bot
Copy link
Collaborator

Landed in f3ed57b

@dsanders11dsanders11 deleted the nmv-electron-28 branch October 3, 2023 16:22
alexfernandez pushed a commit to alexfernandez/node that referenced this pull request Nov 1, 2023
Signed-off-by: David Sanders <[email protected]> PR-URL: nodejs#50020 Reviewed-By: Michaël Zasso <[email protected]> Reviewed-By: Moshe Atlow <[email protected]> Reviewed-By: Yagiz Nizipli <[email protected]> Reviewed-By: Richard Lau <[email protected]>
targos pushed a commit that referenced this pull request Nov 11, 2023
Signed-off-by: David Sanders <[email protected]> PR-URL: #50020 Reviewed-By: Michaël Zasso <[email protected]> Reviewed-By: Moshe Atlow <[email protected]> Reviewed-By: Yagiz Nizipli <[email protected]> Reviewed-By: Richard Lau <[email protected]>
@targostargos mentioned this pull request Nov 12, 2023
debadree25 pushed a commit to debadree25/node that referenced this pull request Apr 15, 2024
Signed-off-by: David Sanders <[email protected]> PR-URL: nodejs#50020 Reviewed-By: Michaël Zasso <[email protected]> Reviewed-By: Moshe Atlow <[email protected]> Reviewed-By: Yagiz Nizipli <[email protected]> Reviewed-By: Richard Lau <[email protected]>
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

docIssues and PRs related to the documentations.fast-trackPRs that do not need to wait for 48 hours to land.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants

@dsanders11@nodejs-github-bot@anonrig@targos@richardlau@MoLow