Uh oh!
There was an error while loading. Please reload this page.
- Notifications
You must be signed in to change notification settings - Fork 34.2k
deps: update undici to 5.25.4#50025
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Uh oh!
There was an error while loading. Please reload this page.
Conversation
nodejs-github-bot commented Oct 3, 2023 • edited
Loading Uh oh!
There was an error while loading. Please reload this page.
edited
Uh oh!
There was an error while loading. Please reload this page.
KhafraDev commented Oct 4, 2023
test failures seem like a weird issue with |
KhafraDev commented Oct 4, 2023
@fastify/busboy imports |
mcollina commented Oct 4, 2023
I think we need to revert the |
KhafraDev commented Oct 4, 2023
it seems like a bug in the wpt runner, @panva maybe? |
panva commented Oct 4, 2023
@KhafraDev it doesn't seem like it to me |
KhafraDev commented Oct 4, 2023 • edited
Loading Uh oh!
There was an error while loading. Please reload this page.
edited
Uh oh!
There was an error while loading. Please reload this page.
I don't understand why it's trying to require (sorry I didn't know who else to ping) |
mcollina commented Oct 4, 2023
I think we can revert that change in |
KhafraDev commented Oct 4, 2023 • edited
Loading Uh oh!
There was an error while loading. Please reload this page.
edited
Uh oh!
There was an error while loading. Please reload this page.
this is actually a bug in node, but removing the node/lib/internal/bootstrap/realm.js Lines 428 to 433 in b1ada0a
|
nodejs-github-bot commented Oct 6, 2023
nodejs-github-bot commented Oct 6, 2023
mcollina commented Oct 7, 2023
The CI is not flaky, there is a tiny bug here. |
a705b57 to 9253851Comparetargos commented Oct 7, 2023
Rebased to include 6b599a3 and make a single commit. |
nodejs-github-bot commented Oct 7, 2023
nodejs-github-bot commented Oct 8, 2023
mcollina left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
nodejs-github-bot commented Oct 8, 2023
Landed in 588784e |
PR-URL: nodejs#50025 Reviewed-By: Filip Skokan <[email protected]> Reviewed-By: Matthew Aitken <[email protected]> Reviewed-By: Matteo Collina <[email protected]>
PR-URL: nodejs#50025 Reviewed-By: Filip Skokan <[email protected]> Reviewed-By: Matthew Aitken <[email protected]> Reviewed-By: Matteo Collina <[email protected]>
This is an automated update of undici to 5.25.4.