doc: use precise promise terminology in fs#50029
Merged
Uh oh!
There was an error while loading. Please reload this page.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
See #50028 for context - this also has the added benefit of reducing the amount of times we use resolving a promise vs resolving a path. Note this document already used `fulfills` in many cases and I kept resolves (for promises) in some cases where it made sense to me from a technical point of view
benjamingr added doc 
lpinca approved these changes Oct 3, 2023
MoLow approved these changes Oct 3, 2023
atlowChemi approved these changes Oct 3, 2023
Contributor
aduh95 commented Oct 8, 2023
Landed in e43bf4c |
alexfernandez pushed a commit to alexfernandez/node that referenced this pull request Nov 1, 2023
See nodejs#50028 for context - this also has the added benefit of reducing the amount of times we use resolving a promise vs resolving a path. Note this document already used `fulfills` in many cases and I kept resolves (for promises) in some cases where it made sense to me from a technical point of view. PR-URL: nodejs#50029 Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: Moshe Atlow <[email protected]> Reviewed-By: Chemi Atlow <[email protected]>
targos pushed a commit that referenced this pull request Nov 11, 2023
See #50028 for context - this also has the added benefit of reducing the amount of times we use resolving a promise vs resolving a path. Note this document already used `fulfills` in many cases and I kept resolves (for promises) in some cases where it made sense to me from a technical point of view. PR-URL: #50029 Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: Moshe Atlow <[email protected]> Reviewed-By: Chemi Atlow <[email protected]>
debadree25 pushed a commit to debadree25/node that referenced this pull request Apr 15, 2024
See nodejs#50028 for context - this also has the added benefit of reducing the amount of times we use resolving a promise vs resolving a path. Note this document already used `fulfills` in many cases and I kept resolves (for promises) in some cases where it made sense to me from a technical point of view. PR-URL: nodejs#50029 Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: Moshe Atlow <[email protected]> Reviewed-By: Chemi Atlow <[email protected]>
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
See #50028 for context - this also has the added benefit of reducing the amount of times we use resolving a promise vs resolving a path.
Note this document already used
fulfillsin many cases and I kept resolves (for promises) in some cases where it made sense to me from a technical point of view