Skip to content

fs: improve error performance for ftruncateSync#50032

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
nodejs-github-bot merged 1 commit into from
Oct 10, 2023
Merged

fs: improve error performance for ftruncateSync#50032

nodejs-github-bot merged 1 commit into from
Oct 10, 2023

Conversation

@andremralves
Copy link
Contributor

@andremralvesandremralves commented Oct 3, 2023

 confidence improvement accuracy (*) (**) (***) fs/bench-ftruncateSync.js n=10000 type='invalid' *** 120.78 % ±13.28% ±17.82% ±23.49% fs/bench-ftruncateSync.js n=10000 type='valid' 6.01 % ±8.63% ±11.48% ±14.95%

Ref: nodejs/performance#106

cc @nodejs/performance

@nodejs-github-botnodejs-github-bot added c++ Issues and PRs that require attention from people who are familiar with C++. fs Issues and PRs related to the fs subsystem / file system. needs-ci PRs that need a full CI run. labels Oct 3, 2023
@anonriganonrig added performance Issues and PRs related to the performance of Node.js. author ready PRs that have at least one approval, no pending requests for changes, and a CI started. request-ci Add this label to start a Jenkins CI on a PR. labels Oct 3, 2023
@andremralves
Copy link
ContributorAuthor

andremralves commented Oct 3, 2023

I think this change probably improves the performance of truncateSync as well, since it uses ftruncateSync under the hood.

@github-actionsgithub-actionsbot removed the request-ci Add this label to start a Jenkins CI on a PR. label Oct 3, 2023
@nodejs-github-bot
Copy link
Collaborator

nodejs-github-bot commented Oct 3, 2023

CI: https://ci.nodejs.org/job/node-test-pull-request/54510/

@anonriganonrig mentioned this pull request Oct 3, 2023
Open
@aduh95
Copy link
Contributor

aduh95 commented Oct 6, 2023

Benchmark CI: https://ci.nodejs.org/view/Node.js%20benchmark/job/benchmark-node-micro-benchmarks/1439 (queued, will 404 until it starts)

@anonriganonrig added the commit-queue Add this label to land a pull request using GitHub Actions. label Oct 10, 2023
@nodejs-github-botnodejs-github-bot added commit-queue-failed An error occurred while landing this pull request using GitHub Actions. and removed commit-queue Add this label to land a pull request using GitHub Actions. labels Oct 10, 2023
@nodejs-github-bot
Copy link
Collaborator

nodejs-github-bot commented Oct 10, 2023

Commit Queue failed
- Loading data for nodejs/node/pull/50032 ✔ Done loading data for nodejs/node/pull/50032 ----------------------------------- PR info ------------------------------------ Title fs: improve error performance for `ftruncateSync` (#50032) ⚠ Could not retrieve the email or name of the PR author's from user's GitHub profile! Branch andremralves:imprv-ftruncate -> nodejs:main Labels c++, fs, performance, author ready, needs-ci Commits 1 - fs: improve error performance for `ftruncateSync` Committers 1 - Andre Alves PR-URL: https://github.com/nodejs/node/pull/50032 Refs: https://github.com/nodejs/performance/issues/106 Reviewed-By: Yagiz Nizipli ------------------------------ Generated metadata ------------------------------ PR-URL: https://github.com/nodejs/node/pull/50032 Refs: https://github.com/nodejs/performance/issues/106 Reviewed-By: Yagiz Nizipli -------------------------------------------------------------------------------- ℹ This PR was created on Tue, 03 Oct 2023 22:16:05 GMT ✔ Approvals: 1 ✔ - Yagiz Nizipli (@anonrig) (TSC): https://github.com/nodejs/node/pull/50032#pullrequestreview-1656221675 ✘ This PR needs to wait 1 more hours to land (or 0 hours if there is one more approval) ✔ Last GitHub CI successful ℹ Last Full PR CI on 2023-10-03T22:30:22Z: https://ci.nodejs.org/job/node-test-pull-request/54510/ ℹ Last Benchmark CI on 2023-10-06T14:30:20Z: https://ci.nodejs.org/view/Node.js%20benchmark/job/benchmark-node-micro-benchmarks/1439 - Querying data for job/node-test-pull-request/1439/ ✔ Last Jenkins CI successful -------------------------------------------------------------------------------- ✔ Aborted `git node land` session in /home/runner/work/node/node/.ncu
https://github.com/nodejs/node/actions/runs/6474540635

@anonriganonrig added commit-queue Add this label to land a pull request using GitHub Actions. and removed commit-queue-failed An error occurred while landing this pull request using GitHub Actions. labels Oct 10, 2023
@nodejs-github-botnodejs-github-bot removed the commit-queue Add this label to land a pull request using GitHub Actions. label Oct 10, 2023
@nodejs-github-botnodejs-github-bot merged commit ed49722 into nodejs:mainOct 10, 2023
@nodejs-github-bot
Copy link
Collaborator

nodejs-github-bot commented Oct 10, 2023

Landed in ed49722

@RafaelGSSRafaelGSS mentioned this pull request Oct 15, 2023
Merged
alexfernandez pushed a commit to alexfernandez/node that referenced this pull request Nov 1, 2023
@andremralves@alexfernandez
fs: improve error performance for ftruncateSync
0cc729c
PR-URL: nodejs#50032 Refs: nodejs/performance#106 Reviewed-By: Yagiz Nizipli <[email protected]>
targos pushed a commit that referenced this pull request Nov 11, 2023
@andremralves@targos
fs: improve error performance for ftruncateSync
57eb06e
PR-URL: #50032 Refs: nodejs/performance#106 Reviewed-By: Yagiz Nizipli <[email protected]>
@targostargos mentioned this pull request Nov 12, 2023
Merged
@juanarboljuanarbol mentioned this pull request Dec 6, 2023
Merged
debadree25 pushed a commit to debadree25/node that referenced this pull request Apr 15, 2024
@andremralves@debadree25
fs: improve error performance for ftruncateSync
418416a
PR-URL: nodejs#50032 Refs: nodejs/performance#106 Reviewed-By: Yagiz Nizipli <[email protected]>
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@anonriganonriganonrig approved these changes

@joyeecheungjoyeecheungAwaiting requested review from joyeecheung

Assignees

No one assigned

Labels

author readyPRs that have at least one approval, no pending requests for changes, and a CI started.c++Issues and PRs that require attention from people who are familiar with C++.fsIssues and PRs related to the fs subsystem / file system.needs-ciPRs that need a full CI run.performanceIssues and PRs related to the performance of Node.js.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@andremralves@nodejs-github-bot@aduh95@anonrig