tools: remove no-return-await lint rule#50118
Merged
Uh oh!
There was an error while loading. Please reload this page.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
no-return-await rule was deprecated in ESLint 8.46.0. According to the ESLint docs removing `await` can make the code slower. Refs: https://eslint.org/docs/latest/rules/no-return-await
sapphi-redforce-pushed the tools/remove-no-return-await-rule branch from a503145 to 0d4caeeCompare
anonrig approved these changes Oct 10, 2023
anonrig added the author ready 
lpinca approved these changes Oct 10, 2023
aduh95 added the commit-queue 
nodejs-github-bot removed the commit-queue 
Collaborator
nodejs-github-bot commented Oct 12, 2023
Landed in 760b5dd |
alexfernandez pushed a commit to alexfernandez/node that referenced this pull request Nov 1, 2023
no-return-await rule was deprecated in ESLint 8.46.0. According to the ESLint docs removing `await` can make the code slower. Refs: https://eslint.org/docs/latest/rules/no-return-await PR-URL: nodejs#50118 Reviewed-By: Yagiz Nizipli <[email protected]> Reviewed-By: Luigi Pinca <[email protected]>
targos pushed a commit that referenced this pull request Nov 11, 2023
no-return-await rule was deprecated in ESLint 8.46.0. According to the ESLint docs removing `await` can make the code slower. Refs: https://eslint.org/docs/latest/rules/no-return-await PR-URL: #50118 Reviewed-By: Yagiz Nizipli <[email protected]> Reviewed-By: Luigi Pinca <[email protected]>
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
no-return-await rule was deprecated in ESLint 8.46.0. According to the ESLint docs removing
awaitcan make the code slower.Refs: https://eslint.org/docs/latest/rules/no-return-await
This rule was added in #17265.
return awaitis sometimes necessary to create a better stacktrace (#49849 (comment)).