Skip to content

[v18.x backport] test: fix edge snapshot stack traces#50237

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
codebytere wants to merge 1 commit into from
Closed

[v18.x backport] test: fix edge snapshot stack traces #50237

codebytere wants to merge 1 commit into from

Conversation

@codebytere
Copy link
Member

@codebyterecodebytere commented Oct 18, 2023

Backporting #49659 - it's affecting Electron in 18 and it'd help us a fair bit for this to land.

@nodejs-github-botnodejs-github-bot added needs-ci PRs that need a full CI run. test Issues and PRs related to the tests. v18.x Issues that can be reproduced on v18.x or PRs targeting the v18.x-staging branch. labels Oct 18, 2023
@codebyterecodebytereforce-pushed the backport-message-tests-18 branch from 6aeb5d7 to 57814aeCompareOctober 18, 2023 08:35
@codebyterecodebytere mentioned this pull request Oct 18, 2023
Merged
4 tasks
@GeoffreyBooth@codebytere
test: fix edge snapshot stack traces
fc6fe0f
PR-URL: nodejs#49659 Reviewed-By: James M Snell <[email protected]> Reviewed-By: Yagiz Nizipli <[email protected]> Reviewed-By: Moshe Atlow <[email protected]>
@codebyterecodebytereforce-pushed the backport-message-tests-18 branch from 57814ae to fc6fe0fCompareOctober 18, 2023 09:14
mcollina
mcollina approved these changes Oct 18, 2023
View reviewed changes
Copy link
Member

@mcollinamcollina left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@codebyterecodebytere added request-ci Add this label to start a Jenkins CI on a PR. and removed needs-ci PRs that need a full CI run. labels Nov 1, 2023
@github-actionsgithub-actionsbot removed the request-ci Add this label to start a Jenkins CI on a PR. label Nov 1, 2023
@nodejs-github-bot
Copy link
Collaborator

nodejs-github-bot commented Nov 1, 2023

CI: https://ci.nodejs.org/job/node-test-pull-request/55393/

@nodejs-github-bot
Copy link
Collaborator

nodejs-github-bot commented Nov 2, 2023

CI: https://ci.nodejs.org/job/node-test-pull-request/55422/

This was referenced Nov 3, 2023
Open
Open
Open
Open
Open
Open
Open
@targos
Copy link
Member

targos commented Nov 12, 2023

Thanks, the commit is now part of #50669

@targostargos closed this Nov 12, 2023
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@mcollinamcollinamcollina approved these changes

@MoLowMoLowMoLow approved these changes

@GeoffreyBoothGeoffreyBoothAwaiting requested review from GeoffreyBooth

Assignees

No one assigned

Labels

testIssues and PRs related to the tests.v18.xIssues that can be reproduced on v18.x or PRs targeting the v18.x-staging branch.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

6 participants

@codebytere@nodejs-github-bot@targos@mcollina@MoLow@GeoffreyBooth