fixup! test: set test-worker-nearheaplimit-deadlock flaky#50277
Uh oh!
There was an error while loading. Please reload this page.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
nodejs-github-bot added needs-ci 
richardlau approved these changes Oct 19, 2023
Member
targos commented Oct 19, 2023
I edited the OP to remove the |
StefanStojanovicforce-pushed the mefi-test-worker-nearheaplimit-deadlock-flaky-2 branch from 4b081e1 to bae1e41Compare
github-actionsbot removed the request-ci 
Collaborator
nodejs-github-bot commented Oct 19, 2023
ContributorAuthor
StefanStojanovic commented Oct 19, 2023
Makes sense! Btw, I had to change the commit message since having |
anonrig approved these changes Oct 19, 2023
Collaborator
nodejs-github-bot commented Oct 19, 2023
anonrig added the commit-queue 20 tasks
ContributorAuthor
StefanStojanovic commented Oct 20, 2023
Can someone please request |
richardlau added the fast-track 
Contributor
Fast-track has been requested by @richardlau. Please 👍 to approve. |
richardlau added the author ready nodejs-github-bot added commit-queue-failed Collaborator
nodejs-github-bot commented Oct 20, 2023
Commit Queue failed- Loading data for nodejs/node/pull/50277 ✔ Done loading data for nodejs/node/pull/50277 ----------------------------------- PR info ------------------------------------ Title fixup! test: set test-worker-nearheaplimit-deadlock flaky (#50277) ⚠ Could not retrieve the email or name of the PR author's from user's GitHub profile! Branch StefanStojanovic:mefi-test-worker-nearheaplimit-deadlock-flaky-2 -> nodejs:main Labels test, fast-track, author ready, needs-ci Commits 1 - test: set test-worker-nearheaplimit-deadlock flaky Committers 1 - StefanStojanovic PR-URL: https://github.com/nodejs/node/pull/50277 Reviewed-By: Richard Lau Reviewed-By: Yagiz Nizipli ------------------------------ Generated metadata ------------------------------ PR-URL: https://github.com/nodejs/node/pull/50277 Reviewed-By: Richard Lau Reviewed-By: Yagiz Nizipli -------------------------------------------------------------------------------- ℹ This PR was created on Thu, 19 Oct 2023 10:58:20 GMT ✔ Approvals: 2 ✔ - Richard Lau (@richardlau) (TSC): https://github.com/nodejs/node/pull/50277#pullrequestreview-1687369552 ✔ - Yagiz Nizipli (@anonrig) (TSC): https://github.com/nodejs/node/pull/50277#pullrequestreview-1687520300 ℹ This PR is being fast-tracked ✘ This PR needs to wait 23 more hours to land (or 0 hours if there is 1 more approval (👍) of the fast-track request from collaborators). ✔ Last GitHub CI successful ℹ Last Full PR CI on 2023-10-19T17:01:00Z: https://ci.nodejs.org/job/node-test-pull-request/55019/ - Querying data for job/node-test-pull-request/55019/ ✔ Last Jenkins CI successful -------------------------------------------------------------------------------- ✔ Aborted `git node land` session in /home/runner/work/node/node/.ncuhttps://github.com/nodejs/node/actions/runs/6586894859 |
richardlau removed the commit-queue-failed ContributorAuthor
StefanStojanovic commented Oct 20, 2023
From what I see this is why it failed |
mhdawson pushed a commit that referenced this pull request Oct 20, 2023
PR-URL: #50277 Reviewed-By: Richard Lau <[email protected]> Reviewed-By: Yagiz Nizipli <[email protected]> Reviewed-By: Michael Dawson <[email protected]>
Member
mhdawson commented Oct 20, 2023
Landed in b4cc3e2 |
24 tasks
targos pushed a commit that referenced this pull request Oct 23, 2023
PR-URL: #50277 Reviewed-By: Richard Lau <[email protected]> Reviewed-By: Yagiz Nizipli <[email protected]> Reviewed-By: Michael Dawson <[email protected]>
alexfernandez pushed a commit to alexfernandez/node that referenced this pull request Nov 1, 2023
PR-URL: nodejs#50277 Reviewed-By: Richard Lau <[email protected]> Reviewed-By: Yagiz Nizipli <[email protected]> Reviewed-By: Michael Dawson <[email protected]>
targos pushed a commit that referenced this pull request Nov 11, 2023
PR-URL: #50277 Reviewed-By: Richard Lau <[email protected]> Reviewed-By: Yagiz Nizipli <[email protected]> Reviewed-By: Michael Dawson <[email protected]>
targos pushed a commit that referenced this pull request Nov 27, 2023
PR-URL: #50277 Reviewed-By: Richard Lau <[email protected]> Reviewed-By: Yagiz Nizipli <[email protected]> Reviewed-By: Michael Dawson <[email protected]>
sercher added a commit to sercher/graaljs that referenced this pull request Apr 25, 2024
PR-URL: nodejs/node#50277 Reviewed-By: Richard Lau <[email protected]> Reviewed-By: Yagiz Nizipli <[email protected]> Reviewed-By: Michael Dawson <[email protected]>
sercher added a commit to sercher/graaljs that referenced this pull request Apr 25, 2024
PR-URL: nodejs/node#50277 Reviewed-By: Richard Lau <[email protected]> Reviewed-By: Yagiz Nizipli <[email protected]> Reviewed-By: Michael Dawson <[email protected]>
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The test is only flaky on x86 Windows.
This is a fixup to #50238 because
process.archreturnsia32and notx86on x86 node.exe on Windows.