Skip to content

Conversation

@anonrig
Copy link
Member

@anonriganonrig commented Oct 19, 2023

Ref: #50293

cc @nodejs/platform-macos @nodejs/inspector

@nodejs-github-botnodejs-github-bot added needs-ci PRs that need a full CI run. test Issues and PRs related to the tests. labels Oct 19, 2023
@anonriganonrig added flaky-test Issues and PRs related to the tests with unstable failures on the CI. fast-track PRs that do not need to wait for 48 hours to land. request-ci Add this label to start a Jenkins CI on a PR. labels Oct 19, 2023
@github-actions
Copy link
Contributor

Fast-track has been requested by @anonrig. Please 👍 to approve.

@github-actionsgithub-actionsbot removed the request-ci Add this label to start a Jenkins CI on a PR. label Oct 19, 2023
@nodejs-github-bot
Copy link
Collaborator

@nodejs-github-bot
Copy link
Collaborator

@H4adH4ad added the author ready PRs that have at least one approval, no pending requests for changes, and a CI started. label Oct 22, 2023
@nodejs-github-bot
Copy link
Collaborator

@nodejs-github-bot
Copy link
Collaborator

@anonriganonrig added the request-ci Add this label to start a Jenkins CI on a PR. label Oct 26, 2023
@github-actionsgithub-actionsbot removed the request-ci Add this label to start a Jenkins CI on a PR. label Oct 26, 2023
@nodejs-github-bot
Copy link
Collaborator

@nodejs-github-bot
Copy link
Collaborator

@aduh95aduh95 added request-ci Add this label to start a Jenkins CI on a PR. and removed fast-track PRs that do not need to wait for 48 hours to land. labels Nov 29, 2023
@aduh95aduh95 removed the request-ci Add this label to start a Jenkins CI on a PR. label Nov 29, 2023
@aduh95
Copy link
Contributor

This needs a rebase

@aduh95aduh95 removed the author ready PRs that have at least one approval, no pending requests for changes, and a CI started. label Dec 5, 2023
@avivkeller
Copy link
Member

Hi! It's been a while since any activity on this PR, but it has several approvals. This comment will bump this issue to the front of the PR page so more people can see (and implement) this change.

If you still want to pursue this, please ensure this change is relevant.

This comment is an attempt to resolve older pull requests.

@targos
Copy link
Member

Closing as the referenced issue is marked as fixed.

@targostargos closed this Apr 23, 2024
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

flaky-testIssues and PRs related to the tests with unstable failures on the CI.needs-ciPRs that need a full CI run.testIssues and PRs related to the tests.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

8 participants

@anonrig@nodejs-github-bot@aduh95@avivkeller@targos@jasnell@H4ad@cola119