test: fix vm assertion actual and expected order#50371
Merged
Uh oh!
There was an error while loading. Please reload this page.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
nodejs-github-bot added needs-ci 
benjamingr approved these changes Oct 24, 2023
lpinca approved these changes Oct 24, 2023
aduh95 approved these changes Oct 24, 2023
aduh95 added fast-track 
Contributor
Fast-track has been requested by @aduh95. Please 👍 to approve. |
github-actionsbot removed the request-ci 
Collaborator
nodejs-github-bot commented Oct 24, 2023
H4ad approved these changes Oct 24, 2023
16 tasks
legendecasforce-pushed the vm/test-assertions branch from c77b893 to 1ef3915Compare
MemberAuthor
legendecas commented Oct 25, 2023
Rebased on the tip of the main branch to fix the CI complaints on the changelog. |
github-actionsbot removed the request-ci Collaborator
nodejs-github-bot commented Oct 25, 2023
H4ad approved these changes Oct 25, 2023
20 tasks
Collaborator
nodejs-github-bot commented Oct 26, 2023
Collaborator
nodejs-github-bot commented Oct 26, 2023
legendecas added the commit-queue nodejs-github-bot removed the commit-queue Collaborator
nodejs-github-bot commented Oct 26, 2023
Landed in 4ddb263 |
This was referenced Oct 27, 2023
alexfernandez pushed a commit to alexfernandez/node that referenced this pull request Nov 1, 2023
PR-URL: nodejs#50371 Reviewed-By: Benjamin Gruenbaum <[email protected]> Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: Antoine du Hamel <[email protected]> Reviewed-By: Vinícius Lourenço Claro Cardoso <[email protected]>
targos pushed a commit that referenced this pull request Nov 11, 2023
PR-URL: #50371 Reviewed-By: Benjamin Gruenbaum <[email protected]> Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: Antoine du Hamel <[email protected]> Reviewed-By: Vinícius Lourenço Claro Cardoso <[email protected]>
UlisesGascon pushed a commit that referenced this pull request Dec 11, 2023
PR-URL: #50371 Reviewed-By: Benjamin Gruenbaum <[email protected]> Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: Antoine du Hamel <[email protected]> Reviewed-By: Vinícius Lourenço Claro Cardoso <[email protected]>
Merged
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The actual and expected arguments order in the assertions were incorrect.
Refs: #50360 (comment)