Skip to content

tools: update gyp-next to v0.16.1#50380

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
targos wants to merge 2 commits into from
Closed

tools: update gyp-next to v0.16.1 #50380

targos wants to merge 2 commits into from

Conversation

@targos
Copy link
Member

@targostargos commented Oct 25, 2023

No description provided.

@nodejs-github-bot
Copy link
Collaborator

nodejs-github-bot commented Oct 25, 2023

Review requested:

  • @nodejs/gyp

@nodejs-github-botnodejs-github-bot added build Issues and PRs related to build files or the CI. gyp Issues and PRs related to the GYP tool and .gyp build files needs-ci PRs that need a full CI run. tools Issues and PRs related to the tools directory. labels Oct 25, 2023
@targos
Copy link
MemberAuthor

targos commented Oct 25, 2023

@nodejs/python not sure what to do about https://github.com/nodejs/node/actions/runs/6636731539/job/18029693061

@gengjiawen
Copy link
Member

gengjiawen commented Oct 25, 2023

@nodejs/python not sure what to do about nodejs/node/actions/runs/6636731539/job/18029693061

ignore tools/gyp should do.

node/pyproject.toml

Line 23 in d1ccca9

"tools/node_modules",

@targostargos added the request-ci Add this label to start a Jenkins CI on a PR. label Oct 25, 2023
@cclauss
Copy link
Contributor

cclauss commented Oct 25, 2023•
edited
Loading

I would comment out this line in tools/gyp/pyproject.toml
error: TOML parse error at line 94, column 3
|
94 | "PLR1714",
| ^^^^^^^^^
Unknown rule selector: PLR1714

@gengjiawen
Copy link
Member

gengjiawen commented Oct 25, 2023

I would comment out this line: error: TOML parse error at line 94, column 3 | 94 | "PLR1714", | ^^^^^^^^^ Unknown rule selector: PLR1714

In the long run, we shouldn't lint and format deps in Node.js repo. This can be done in gyp-next.

@cclauss
Copy link
Contributor

cclauss commented Oct 25, 2023

Oh... This is because we are using a pinned version of ruff and gyp-next is using a current one.

@github-actionsgithub-actionsbot removed the request-ci Add this label to start a Jenkins CI on a PR. label Oct 25, 2023
@cclauss
Copy link
Contributor

cclauss commented Oct 25, 2023

Please update

node/Makefile

Lines 1499 to 1500 in d1ccca9

$(PYTHON) -m pip install --upgrade --target tools/pip/site-packages ruff==0.0.272 ||\
$(PYTHON) -m pip install --upgrade --system --target tools/pip/site-packages ruff==0.0.272

@nodejs-github-bot
Copy link
Collaborator

nodejs-github-bot commented Oct 25, 2023

CI: https://ci.nodejs.org/job/node-test-pull-request/55218/

@targos
Copy link
MemberAuthor

targos commented Oct 25, 2023

This should not be related. gyp-next is linted in its own project and I agree with @gengjiawen we should not lint it again with our own rules here.

@cclauss
Copy link
Contributor

cclauss commented Oct 25, 2023•
edited
Loading

Ruff is designed to work in complex monorepos so we would not be testing the node-gyp directory using this repo’s pyproject.toml (as this error proves). Ruff parsed this file because it will be the settings used to lint that directory.

@anonriganonrig added commit-queue Add this label to land a pull request using GitHub Actions. commit-queue-rebase Add this label to allow the Commit Queue to land a PR in several commits. labels Oct 31, 2023
@nodejs-github-botnodejs-github-bot removed the commit-queue Add this label to land a pull request using GitHub Actions. label Oct 31, 2023
@nodejs-github-bot
Copy link
Collaborator

nodejs-github-bot commented Oct 31, 2023

Landed in a77ef54...6557c1c

nodejs-github-bot pushed a commit that referenced this pull request Oct 31, 2023
@targos@nodejs-github-bot
tools: skip ruff on tools/gyp
76d4e38
PR-URL: #50380 Reviewed-By: Jiawen Geng <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Yagiz Nizipli <[email protected]>
nodejs-github-bot pushed a commit that referenced this pull request Oct 31, 2023
@targos@nodejs-github-bot
tools: update gyp-next to v0.16.1
6557c1c
PR-URL: #50380 Reviewed-By: Jiawen Geng <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Yagiz Nizipli <[email protected]>
@targostargos deleted the update-gyp branch October 31, 2023 12:45
alexfernandez pushed a commit to alexfernandez/node that referenced this pull request Nov 1, 2023
@targos@alexfernandez
tools: skip ruff on tools/gyp
c0c3a8c
PR-URL: nodejs#50380 Reviewed-By: Jiawen Geng <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Yagiz Nizipli <[email protected]>
alexfernandez pushed a commit to alexfernandez/node that referenced this pull request Nov 1, 2023
@targos@alexfernandez
tools: update gyp-next to v0.16.1
5c24551
PR-URL: nodejs#50380 Reviewed-By: Jiawen Geng <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Yagiz Nizipli <[email protected]>
This was referenced Nov 6, 2023
Merged
Merged
anonrig pushed a commit to anonrig/node that referenced this pull request Nov 9, 2023
@targos@anonrig
tools: skip ruff on tools/gyp
e23d836
PR-URL: nodejs#50380 Reviewed-By: Jiawen Geng <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Yagiz Nizipli <[email protected]>
anonrig pushed a commit to anonrig/node that referenced this pull request Nov 9, 2023
@targos@anonrig
tools: update gyp-next to v0.16.1
7478b77
PR-URL: nodejs#50380 Reviewed-By: Jiawen Geng <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Yagiz Nizipli <[email protected]>
targos added a commit that referenced this pull request Nov 11, 2023
@targos
tools: skip ruff on tools/gyp
de9dc10
PR-URL: #50380 Reviewed-By: Jiawen Geng <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Yagiz Nizipli <[email protected]>
targos added a commit that referenced this pull request Nov 11, 2023
@targos
tools: update gyp-next to v0.16.1
171ae59
PR-URL: #50380 Reviewed-By: Jiawen Geng <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Yagiz Nizipli <[email protected]>
@targostargos mentioned this pull request Nov 12, 2023
Merged
targos added a commit that referenced this pull request Nov 14, 2023
@targos
tools: skip ruff on tools/gyp
9fc29c9
PR-URL: #50380 Reviewed-By: Jiawen Geng <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Yagiz Nizipli <[email protected]>
targos added a commit that referenced this pull request Nov 14, 2023
@targos
tools: update gyp-next to v0.16.1
52e7b6d
PR-URL: #50380 Reviewed-By: Jiawen Geng <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Yagiz Nizipli <[email protected]>
@targostargos added lts-watch-v18.x lts-watch-v20.x PRs that may need to be released in v20.x labels Nov 15, 2023
UlisesGascon pushed a commit that referenced this pull request Dec 11, 2023
@targos@UlisesGascon
tools: skip ruff on tools/gyp
f5ccab5
PR-URL: #50380 Reviewed-By: Jiawen Geng <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Yagiz Nizipli <[email protected]>
UlisesGascon pushed a commit that referenced this pull request Dec 11, 2023
@targos@UlisesGascon
tools: update gyp-next to v0.16.1
22b7a74
PR-URL: #50380 Reviewed-By: Jiawen Geng <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Yagiz Nizipli <[email protected]>
@UlisesGasconUlisesGascon mentioned this pull request Dec 12, 2023
Merged
@richardlaurichardlau mentioned this pull request Mar 22, 2024
Merged
@richardlaurichardlau added backported-to-v20.x PRs backported to the v20.x-staging branch. and removed lts-watch-v20.x PRs that may need to be released in v20.x labels Mar 25, 2024
joshuafried pushed a commit to joshuafried/node that referenced this pull request Sep 13, 2024
@targos@joshuafried
tools: update gyp-next to v0.16.1
eb4420d
PR-URL: nodejs/node#50380 Reviewed-By: Jiawen Geng <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Yagiz Nizipli <[email protected]>
aduh95 pushed a commit that referenced this pull request Nov 2, 2024
@targos@aduh95
tools: skip ruff on tools/gyp
fa72b2c
PR-URL: #50380 Reviewed-By: Jiawen Geng <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Yagiz Nizipli <[email protected]>
aduh95 pushed a commit that referenced this pull request Nov 2, 2024
@targos@aduh95
tools: update gyp-next to v0.16.1
0fb652e
PR-URL: #50380 Reviewed-By: Jiawen Geng <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Yagiz Nizipli <[email protected]>
@aduh95aduh95 mentioned this pull request Nov 7, 2024
Merged
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@jasnelljasnelljasnell approved these changes

@anonriganonriganonrig approved these changes

@gengjiawengengjiawengengjiawen approved these changes

Assignees

No one assigned

Labels

backported-to-v20.xPRs backported to the v20.x-staging branch.buildIssues and PRs related to build files or the CI.commit-queue-rebaseAdd this label to allow the Commit Queue to land a PR in several commits.gypIssues and PRs related to the GYP tool and .gyp build filesneeds-ciPRs that need a full CI run.toolsIssues and PRs related to the tools directory.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

8 participants

@targos@nodejs-github-bot@gengjiawen@cclauss@jasnell@anonrig@richardlau@aduh95