Skip to content

meta: add web-standards as web api visibility owner#50418

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
nodejs-github-bot merged 2 commits into from
Oct 28, 2023
Merged

meta: add web-standards as web api visibility owner #50418

nodejs-github-bot merged 2 commits into from
Oct 28, 2023

Conversation

@legendecas
Copy link
Member

@legendecaslegendecas commented Oct 26, 2023

When Web APIs global visibility is changed, ping @nodejs/web-standards.

Refs: #50412 (comment)

@nodejs-github-bot
Copy link
Collaborator

nodejs-github-bot commented Oct 26, 2023

Review requested:

  • @nodejs/tsc

@nodejs-github-botnodejs-github-bot added the meta Issues and PRs related to the general management of the project. label Oct 26, 2023
GeoffreyBooth
GeoffreyBooth approved these changes Oct 26, 2023
View reviewed changes
Copy link
Member

@GeoffreyBoothGeoffreyBooth left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe also any of the Web Platform Tests? Undici, fetch, ws? Are there any other paths we should cover for this team?

@GeoffreyBoothGeoffreyBooth added the web-standards Issues and PRs related to Web APIs label Oct 26, 2023
anonrig
anonrig reviewed Oct 27, 2023
View reviewed changes
@legendecas
Copy link
MemberAuthor

legendecas commented Oct 27, 2023

undici is covered by its own dedicated team so I would prefer to defer it to them. Added navigator.js as suggested by @anonrig .

mcollina
mcollina approved these changes Oct 28, 2023
View reviewed changes
Copy link
Member

@mcollinamcollina left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@debadree25debadree25 added author ready PRs that have at least one approval, no pending requests for changes, and a CI started. commit-queue Add this label to land a pull request using GitHub Actions. labels Oct 28, 2023
@GeoffreyBoothGeoffreyBooth added the commit-queue-squash Add this label to instruct the Commit Queue to squash all the PR commits into the first one. label Oct 28, 2023
@nodejs-github-botnodejs-github-bot removed the commit-queue Add this label to land a pull request using GitHub Actions. label Oct 28, 2023
@nodejs-github-botnodejs-github-bot merged commit d1592bd into nodejs:mainOct 28, 2023
@nodejs-github-bot
Copy link
Collaborator

nodejs-github-bot commented Oct 28, 2023

Landed in d1592bd

@legendecaslegendecas deleted the meta/web-standards branch October 29, 2023 01:51
DylanTet pushed a commit to DylanTet/node that referenced this pull request Oct 29, 2023
@legendecas@DylanTet
meta: add web-standards as web api visibility owner
b9b456a
PR-URL: nodejs#50418 Reviewed-By: Antoine du Hamel <[email protected]> Reviewed-By: Geoffrey Booth <[email protected]> Reviewed-By: Benjamin Gruenbaum <[email protected]> Reviewed-By: Tobias Nießen <[email protected]> Reviewed-By: Darshan Sen <[email protected]> Reviewed-By: Yagiz Nizipli <[email protected]> Reviewed-By: Matteo Collina <[email protected]>
alexfernandez pushed a commit to alexfernandez/node that referenced this pull request Nov 1, 2023
@legendecas@alexfernandez
meta: add web-standards as web api visibility owner
99d27d8
PR-URL: nodejs#50418 Reviewed-By: Antoine du Hamel <[email protected]> Reviewed-By: Geoffrey Booth <[email protected]> Reviewed-By: Benjamin Gruenbaum <[email protected]> Reviewed-By: Tobias Nießen <[email protected]> Reviewed-By: Darshan Sen <[email protected]> Reviewed-By: Yagiz Nizipli <[email protected]> Reviewed-By: Matteo Collina <[email protected]>
targos pushed a commit that referenced this pull request Nov 11, 2023
@legendecas@targos
meta: add web-standards as web api visibility owner
d94010b
PR-URL: #50418 Reviewed-By: Antoine du Hamel <[email protected]> Reviewed-By: Geoffrey Booth <[email protected]> Reviewed-By: Benjamin Gruenbaum <[email protected]> Reviewed-By: Tobias Nießen <[email protected]> Reviewed-By: Darshan Sen <[email protected]> Reviewed-By: Yagiz Nizipli <[email protected]> Reviewed-By: Matteo Collina <[email protected]>
@targostargos mentioned this pull request Nov 12, 2023
Merged
UlisesGascon pushed a commit that referenced this pull request Dec 11, 2023
@legendecas@UlisesGascon
meta: add web-standards as web api visibility owner
8d3cf8c
PR-URL: #50418 Reviewed-By: Antoine du Hamel <[email protected]> Reviewed-By: Geoffrey Booth <[email protected]> Reviewed-By: Benjamin Gruenbaum <[email protected]> Reviewed-By: Tobias Nießen <[email protected]> Reviewed-By: Darshan Sen <[email protected]> Reviewed-By: Yagiz Nizipli <[email protected]> Reviewed-By: Matteo Collina <[email protected]>
@UlisesGasconUlisesGascon mentioned this pull request Dec 12, 2023
Merged
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@ljharbljharbljharb approved these changes

@mcollinamcollinamcollina approved these changes

@GeoffreyBoothGeoffreyBoothGeoffreyBooth approved these changes

@benjamingrbenjamingrbenjamingr approved these changes

@anonriganonriganonrig approved these changes

@tniessentniessentniessen approved these changes

@aduh95aduh95aduh95 approved these changes

@RaisinTenRaisinTenRaisinTen approved these changes

Assignees

No one assigned

Labels

author readyPRs that have at least one approval, no pending requests for changes, and a CI started.commit-queue-squashAdd this label to instruct the Commit Queue to squash all the PR commits into the first one.metaIssues and PRs related to the general management of the project.web-standardsIssues and PRs related to Web APIs

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

11 participants

@legendecas@nodejs-github-bot@ljharb@mcollina@GeoffreyBooth@benjamingr@anonrig@tniessen@aduh95@RaisinTen@debadree25