stream: remove no longer relevant comment#50446
Merged
Uh oh!
There was an error while loading. Please reload this page.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Collaborator
nodejs-github-bot commented Oct 28, 2023
Review requested:
|
benjamingr approved these changes Oct 28, 2023
benjamingr added the fast-track 
Contributor
Fast-track has been requested by @benjamingr. Please 👍 to approve. |
anonrig approved these changes Oct 28, 2023
benjamingr added the commit-queue 
jasnell approved these changes Oct 28, 2023
nodejs-github-bot added commit-queue-failed Collaborator
nodejs-github-bot commented Oct 28, 2023
Commit Queue failed- Loading data for nodejs/node/pull/50446 ✔ Done loading data for nodejs/node/pull/50446 ----------------------------------- PR info ------------------------------------ Title stream: remove no longer relevant comment (#50446) Author Robert Nagy (@ronag) Branch ronag:transform-comment -> nodejs:main Labels fast-track, needs-ci Commits 1 - stream: remove no longer relevant comment Committers 1 - Robert Nagy PR-URL: https://github.com/nodejs/node/pull/50446 Reviewed-By: Benjamin Gruenbaum Reviewed-By: Yagiz Nizipli Reviewed-By: James M Snell ------------------------------ Generated metadata ------------------------------ PR-URL: https://github.com/nodejs/node/pull/50446 Reviewed-By: Benjamin Gruenbaum Reviewed-By: Yagiz Nizipli Reviewed-By: James M Snell -------------------------------------------------------------------------------- ℹ This PR was created on Sat, 28 Oct 2023 13:22:16 GMT ✔ Approvals: 3 ✔ - Benjamin Gruenbaum (@benjamingr) (TSC): https://github.com/nodejs/node/pull/50446#pullrequestreview-1702792357 ✔ - Yagiz Nizipli (@anonrig) (TSC): https://github.com/nodejs/node/pull/50446#pullrequestreview-1702794868 ✔ - James M Snell (@jasnell) (TSC): https://github.com/nodejs/node/pull/50446#pullrequestreview-1702808819 ℹ This PR is being fast-tracked ✔ Last GitHub CI successful ✘ No Jenkins CI runs detected -------------------------------------------------------------------------------- ✔ Aborted `git node land` session in /home/runner/work/node/node/.ncuhttps://github.com/nodejs/node/actions/runs/6678101104 |
benjamingr added commit-queue nodejs-github-bot added commit-queue-failed Collaborator
nodejs-github-bot commented Oct 28, 2023
Commit Queue failed- Loading data for nodejs/node/pull/50446 ✔ Done loading data for nodejs/node/pull/50446 ----------------------------------- PR info ------------------------------------ Title stream: remove no longer relevant comment (#50446) Author Robert Nagy (@ronag) Branch ronag:transform-comment -> nodejs:main Labels fast-track Commits 1 - stream: remove no longer relevant comment Committers 1 - Robert Nagy PR-URL: https://github.com/nodejs/node/pull/50446 Reviewed-By: Benjamin Gruenbaum Reviewed-By: Yagiz Nizipli Reviewed-By: James M Snell ------------------------------ Generated metadata ------------------------------ PR-URL: https://github.com/nodejs/node/pull/50446 Reviewed-By: Benjamin Gruenbaum Reviewed-By: Yagiz Nizipli Reviewed-By: James M Snell -------------------------------------------------------------------------------- ℹ This PR was created on Sat, 28 Oct 2023 13:22:16 GMT ✔ Approvals: 3 ✔ - Benjamin Gruenbaum (@benjamingr) (TSC): https://github.com/nodejs/node/pull/50446#pullrequestreview-1702792357 ✔ - Yagiz Nizipli (@anonrig) (TSC): https://github.com/nodejs/node/pull/50446#pullrequestreview-1702794868 ✔ - James M Snell (@jasnell) (TSC): https://github.com/nodejs/node/pull/50446#pullrequestreview-1702808819 ℹ This PR is being fast-tracked ✔ Last GitHub CI successful ✘ No Jenkins CI runs detected -------------------------------------------------------------------------------- ✔ Aborted `git node land` session in /home/runner/work/node/node/.ncuhttps://github.com/nodejs/node/actions/runs/6678286873 |
lpinca approved these changes Oct 28, 2023
MoLow added request-ci 
MoLow approved these changes Oct 28, 2023
github-actionsbot removed the request-ci Collaborator
nodejs-github-bot commented Oct 28, 2023
VoltrexKeyva added the commit-queue nodejs-github-bot removed the commit-queue Collaborator
nodejs-github-bot commented Oct 29, 2023
Landed in 12766fc |
alexfernandez pushed a commit to alexfernandez/node that referenced this pull request Nov 1, 2023
Refs: nodejs#50014 PR-URL: nodejs#50446 Reviewed-By: Benjamin Gruenbaum <[email protected]> Reviewed-By: Yagiz Nizipli <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: Moshe Atlow <[email protected]>
targos pushed a commit that referenced this pull request Nov 11, 2023
Refs: #50014 PR-URL: #50446 Reviewed-By: Benjamin Gruenbaum <[email protected]> Reviewed-By: Yagiz Nizipli <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: Moshe Atlow <[email protected]>
UlisesGascon pushed a commit that referenced this pull request Dec 11, 2023
Refs: #50014 PR-URL: #50446 Reviewed-By: Benjamin Gruenbaum <[email protected]> Reviewed-By: Yagiz Nizipli <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: Moshe Atlow <[email protected]>
Merged
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment
8 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.