src: upgrade to new v8::Private api#5045
Merged
Uh oh!
There was an error while loading. Please reload this page.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Stop using the deprecated `GetHiddenValue()` and `SetHiddenValue()` methods, start using `GetPrivate()` and `SetPrivate()` instead. This commit turns some of the entries in the per-isolate string table into private symbols. PR-URL: nodejs#5045 Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Trevor Norris <[email protected]>
Contributor
trevnorris commented Feb 3, 2016
LGTM. arm failure is unrelated. |
Contributor
cjihrig commented Feb 3, 2016
LGTM. I guess that answers my question about using |
Member
rvagg commented Feb 8, 2016
can this go on v5.x? v4.x? |
MemberAuthor
bnoordhuis commented Feb 8, 2016
The new APIs don't exist in V8 4.6 and older. |
Member
targos commented Feb 8, 2016
tagging as |
scovetta pushed a commit to scovetta/node that referenced this pull request Apr 2, 2016
Stop using the deprecated `GetHiddenValue()` and `SetHiddenValue()` methods, start using `GetPrivate()` and `SetPrivate()` instead. This commit turns some of the entries in the per-isolate string table into private symbols. PR-URL: nodejs#5045 Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Trevor Norris <[email protected]>
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Stop using the deprecated
GetHiddenValue()andSetHiddenValue()methods, start using
GetPrivate()andSetPrivate()instead.This commit turns some of the entries in the per-isolate string table
into private symbols.
R=@cjihrig or @trevnorris
CI: https://ci.nodejs.org/job/node-test-pull-request/1518/