Skip to content

Conversation

@nodejs-github-bot
Copy link
Collaborator

@nodejs-github-botnodejs-github-bot commented Oct 29, 2023

This is an automated update of acorn-walk to 8.3.1.

@nodejs-github-botnodejs-github-bot added dependencies Pull requests that update a dependency file. needs-ci PRs that need a full CI run. labels Oct 29, 2023
@VoltrexKeyvaVoltrexKeyva added the request-ci Add this label to start a Jenkins CI on a PR. label Oct 29, 2023
@github-actionsgithub-actionsbot removed the request-ci Add this label to start a Jenkins CI on a PR. label Oct 29, 2023
@nodejs-github-bot
Copy link
CollaboratorAuthor

@nodejs-github-bot
Copy link
CollaboratorAuthor

@nodejs-github-bot
Copy link
CollaboratorAuthor

Copy link
Member

@marco-ippolitomarco-ippolito left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

it's not updating the maintaining-dependencies file, will be fixed by #50473

@nodejs-github-botnodejs-github-bot changed the title deps: update acorn-walk to 8.3.0deps: update acorn-walk to 8.3.1Dec 10, 2023
@marco-ippolitomarco-ippolito added the request-ci Add this label to start a Jenkins CI on a PR. label Dec 11, 2023
@github-actionsgithub-actionsbot removed the request-ci Add this label to start a Jenkins CI on a PR. label Dec 11, 2023
@nodejs-github-bot
Copy link
CollaboratorAuthor

@aduh95aduh95 added author ready PRs that have at least one approval, no pending requests for changes, and a CI started. commit-queue Add this label to land a pull request using GitHub Actions. labels Dec 19, 2023
@nodejs-github-botnodejs-github-bot removed the commit-queue Add this label to land a pull request using GitHub Actions. label Dec 19, 2023
@nodejs-github-bot
Copy link
CollaboratorAuthor

Commit Queue failed
- Loading data for nodejs/node/pull/50457 ✔ Done loading data for nodejs/node/pull/50457 ----------------------------------- PR info ------------------------------------ Title deps: update acorn-walk to 8.3.1 (#50457) ⚠ Could not retrieve the email or name of the PR author's from user's GitHub profile! Branch nodejs-github-bot:actions/tools-update-acorn-walk -> nodejs:main Labels author ready, needs-ci, dependencies Commits 2 - deps: update acorn-walk to 8.3.0 - deps: update acorn-walk to 8.3.1 Committers 1 - Node.js GitHub Bot PR-URL: https://github.com/nodejs/node/pull/50457 Reviewed-By: Mohammed Keyvanzadeh Reviewed-By: Moshe Atlow Reviewed-By: Luigi Pinca Reviewed-By: Marco Ippolito ------------------------------ Generated metadata ------------------------------ PR-URL: https://github.com/nodejs/node/pull/50457 Reviewed-By: Mohammed Keyvanzadeh Reviewed-By: Moshe Atlow Reviewed-By: Luigi Pinca Reviewed-By: Marco Ippolito -------------------------------------------------------------------------------- ℹ This PR was created on Sun, 29 Oct 2023 00:24:00 GMT ✔ Approvals: 4 ✔ - Mohammed Keyvanzadeh (@VoltrexKeyva): https://github.com/nodejs/node/pull/50457#pullrequestreview-1702896182 ✔ - Moshe Atlow (@MoLow) (TSC): https://github.com/nodejs/node/pull/50457#pullrequestreview-1702897731 ✔ - Luigi Pinca (@lpinca): https://github.com/nodejs/node/pull/50457#pullrequestreview-1702898751 ✔ - Marco Ippolito (@marco-ippolito): https://github.com/nodejs/node/pull/50457#pullrequestreview-1774150048 ✔ Last GitHub CI successful ℹ Last Full PR CI on 2023-12-11T01:22:41Z: https://ci.nodejs.org/job/node-test-pull-request/56217/ - Querying data for job/node-test-pull-request/56217/ ✔ Last Jenkins CI successful -------------------------------------------------------------------------------- ✔ No git cherry-pick in progress ✔ No git am in progress ✔ No git rebase in progress -------------------------------------------------------------------------------- - Bringing origin/main up to date... From https://github.com/nodejs/node * branch main -> FETCH_HEAD ✔ origin/main is now up-to-date - Downloading patch for 50457 From https://github.com/nodejs/node * branch refs/pull/50457/merge -> FETCH_HEAD ✔ Fetched commits as 898149fed817..6748938b59ca -------------------------------------------------------------------------------- [main 8afff8cf49] deps: update acorn-walk to 8.3.0 Date: Sun Oct 29 00:23:58 2023 +0000 6 files changed, 349 insertions(+), 119 deletions(-) create mode 100644 deps/acorn/acorn-walk/dist/walk.d.mts [main e03260786c] deps: update acorn-walk to 8.3.1 Date: Sun Dec 10 00:26:41 2023 +0000 6 files changed, 25 insertions(+), 13 deletions(-) ✔ Patches applied There are 2 commits in the PR. Attempting autorebase. Rebasing (2/4) 

Executing: git node land --amend --yes
--------------------------------- New Message ----------------------------------
deps: update acorn-walk to 8.3.0

PR-URL: #50457
Reviewed-By: Mohammed Keyvanzadeh [email protected]
Reviewed-By: Moshe Atlow [email protected]
Reviewed-By: Luigi Pinca [email protected]
Reviewed-By: Marco Ippolito [email protected]

[detached HEAD 20b0d6bb90] deps: update acorn-walk to 8.3.0
Date: Sun Oct 29 00:23:58 2023 +0000
6 files changed, 349 insertions(+), 119 deletions(-)
create mode 100644 deps/acorn/acorn-walk/dist/walk.d.mts
Rebasing (3/4)
Rebasing (4/4)

Executing: git node land --amend --yes
--------------------------------- New Message ----------------------------------
deps: update acorn-walk to 8.3.1

PR-URL: #50457
Reviewed-By: Mohammed Keyvanzadeh [email protected]
Reviewed-By: Moshe Atlow [email protected]
Reviewed-By: Luigi Pinca [email protected]
Reviewed-By: Marco Ippolito [email protected]

[detached HEAD 1706441c5d] deps: update acorn-walk to 8.3.1
Date: Sun Dec 10 00:26:41 2023 +0000
6 files changed, 25 insertions(+), 13 deletions(-)

Successfully rebased and updated refs/heads/main.

ℹ Add commit-queue-squash label to land the PR as one commit, or commit-queue-rebase to land as separate commits.

https://github.com/nodejs/node/actions/runs/7260369417

@nodejs-github-botnodejs-github-bot added the commit-queue-failed An error occurred while landing this pull request using GitHub Actions. label Dec 19, 2023
@marco-ippolitomarco-ippolito added commit-queue-rebase Add this label to allow the Commit Queue to land a PR in several commits. and removed commit-queue-failed An error occurred while landing this pull request using GitHub Actions. labels Dec 19, 2023
@marco-ippolitomarco-ippolito added the commit-queue Add this label to land a pull request using GitHub Actions. label Dec 19, 2023
@nodejs-github-botnodejs-github-bot removed the commit-queue Add this label to land a pull request using GitHub Actions. label Dec 19, 2023
@nodejs-github-bot
Copy link
CollaboratorAuthor

Landed in 7014eac...14e3444

nodejs-github-bot added a commit that referenced this pull request Dec 19, 2023
PR-URL: #50457 Reviewed-By: Mohammed Keyvanzadeh <[email protected]> Reviewed-By: Moshe Atlow <[email protected]> Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: Marco Ippolito <[email protected]>
nodejs-github-bot added a commit that referenced this pull request Dec 19, 2023
PR-URL: #50457 Reviewed-By: Mohammed Keyvanzadeh <[email protected]> Reviewed-By: Moshe Atlow <[email protected]> Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: Marco Ippolito <[email protected]>
@targostargos deleted the actions/tools-update-acorn-walk branch December 19, 2023 10:39
ionicmc-js pushed a commit to ionicmc-js/node that referenced this pull request Dec 19, 2023
PR-URL: nodejs#50457 Reviewed-By: Mohammed Keyvanzadeh <[email protected]> Reviewed-By: Moshe Atlow <[email protected]> Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: Marco Ippolito <[email protected]>
ionicmc-js pushed a commit to ionicmc-js/node that referenced this pull request Dec 19, 2023
PR-URL: nodejs#50457 Reviewed-By: Mohammed Keyvanzadeh <[email protected]> Reviewed-By: Moshe Atlow <[email protected]> Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: Marco Ippolito <[email protected]>
RafaelGSS pushed a commit that referenced this pull request Jan 2, 2024
PR-URL: #50457 Reviewed-By: Mohammed Keyvanzadeh <[email protected]> Reviewed-By: Moshe Atlow <[email protected]> Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: Marco Ippolito <[email protected]>
RafaelGSS pushed a commit that referenced this pull request Jan 2, 2024
PR-URL: #50457 Reviewed-By: Mohammed Keyvanzadeh <[email protected]> Reviewed-By: Moshe Atlow <[email protected]> Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: Marco Ippolito <[email protected]>
@RafaelGSSRafaelGSS mentioned this pull request Jan 2, 2024
richardlau pushed a commit that referenced this pull request Mar 25, 2024
PR-URL: #50457 Reviewed-By: Mohammed Keyvanzadeh <[email protected]> Reviewed-By: Moshe Atlow <[email protected]> Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: Marco Ippolito <[email protected]>
richardlau pushed a commit that referenced this pull request Mar 25, 2024
PR-URL: #50457 Reviewed-By: Mohammed Keyvanzadeh <[email protected]> Reviewed-By: Moshe Atlow <[email protected]> Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: Marco Ippolito <[email protected]>
@richardlaurichardlau mentioned this pull request Mar 25, 2024
richardlau pushed a commit that referenced this pull request Apr 26, 2024
PR-URL: #50457 Reviewed-By: Mohammed Keyvanzadeh <[email protected]> Reviewed-By: Moshe Atlow <[email protected]> Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: Marco Ippolito <[email protected]>
richardlau pushed a commit that referenced this pull request Apr 26, 2024
PR-URL: #50457 Reviewed-By: Mohammed Keyvanzadeh <[email protected]> Reviewed-By: Moshe Atlow <[email protected]> Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: Marco Ippolito <[email protected]>
@richardlaurichardlau mentioned this pull request May 16, 2024
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

author readyPRs that have at least one approval, no pending requests for changes, and a CI started.commit-queue-rebaseAdd this label to allow the Commit Queue to land a PR in several commits.dependenciesPull requests that update a dependency file.needs-ciPRs that need a full CI run.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

7 participants

@nodejs-github-bot@lpinca@MoLow@marco-ippolito@VoltrexKeyva@aduh95