lib: use primordials for navigator.userAgent#50467
Merged
Uh oh!
There was an error while loading. Please reload this page.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Collaborator
nodejs-github-bot commented Oct 29, 2023
Review requested:
|
GeoffreyBooth approved these changes Oct 29, 2023
GeoffreyBooth added author ready 
github-actionsbot removed the request-ci Collaborator
nodejs-github-bot commented Oct 29, 2023
H4ad approved these changes Oct 29, 2023
ljharb approved these changes Oct 29, 2023
anonrig requested changes Oct 29, 2023
Member
anonrig left a comment
anonrig left a comment There was a problem hiding this comment.
I'd like to get answer to my questions before merging this PR
Uh oh!
There was an error while loading. Please reload this page.
jasnell approved these changes Oct 29, 2023
anonrig removed the author ready 25 tasks
tniessen approved these changes Oct 30, 2023
Member
tniessen left a comment
tniessen left a comment There was a problem hiding this comment.
This seems like a constant that might as well be constructed before any user code runs, but LGTM either way.
H4ad approved these changes Oct 30, 2023
ContributorAuthor
Uzlopak commented Oct 30, 2023
What is the conclusion? :) |
Member
anonrig commented Oct 30, 2023
I've left a comment: #50467 (comment) |
anonrig approved these changes Oct 30, 2023
17 tasks
Collaborator
nodejs-github-bot commented Oct 31, 2023
Collaborator
nodejs-github-bot commented Oct 31, 2023
Collaborator
nodejs-github-bot commented Oct 31, 2023
Ethan-Arrowood approved these changes Oct 31, 2023
24 tasks
ContributorAuthor
Uzlopak commented Nov 1, 2023
Can somebody please have a look if the CI issues are unrelated and maybe merge? |
ContributorAuthor
Uzlopak commented Nov 2, 2023
@GeoffreyBooth |
25 tasks
Collaborator
nodejs-github-bot commented Nov 2, 2023
Member
GeoffreyBooth commented Nov 2, 2023
Don't rebase unless you have to, we won't be able to resume CI once you do that. |
ContributorAuthor
Uzlopak commented Nov 2, 2023
Seems that the CI is green. Can somebody add the author-ready label and/or merge it? |
H4ad added the commit-queue 
nodejs-github-bot removed the commit-queue Collaborator
nodejs-github-bot commented Nov 2, 2023
Landed in 45f5c9b |
22 tasks
anonrig pushed a commit to anonrig/node that referenced this pull request Nov 9, 2023
PR-URL: nodejs#50467 Reviewed-By: Geoffrey Booth <[email protected]> Reviewed-By: Vinícius Lourenço Claro Cardoso <[email protected]> Reviewed-By: Yagiz Nizipli <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Tobias Nießen <[email protected]> Reviewed-By: Ethan Arrowood <[email protected]>
targos pushed a commit that referenced this pull request Nov 11, 2023
PR-URL: #50467 Reviewed-By: Geoffrey Booth <[email protected]> Reviewed-By: Vinícius Lourenço Claro Cardoso <[email protected]> Reviewed-By: Yagiz Nizipli <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Tobias Nießen <[email protected]> Reviewed-By: Ethan Arrowood <[email protected]>
targos pushed a commit that referenced this pull request Nov 14, 2023
PR-URL: #50467 Reviewed-By: Geoffrey Booth <[email protected]> Reviewed-By: Vinícius Lourenço Claro Cardoso <[email protected]> Reviewed-By: Yagiz Nizipli <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Tobias Nießen <[email protected]> Reviewed-By: Ethan Arrowood <[email protected]>
UlisesGascon pushed a commit that referenced this pull request Dec 11, 2023
PR-URL: #50467 Reviewed-By: Geoffrey Booth <[email protected]> Reviewed-By: Vinícius Lourenço Claro Cardoso <[email protected]> Reviewed-By: Yagiz Nizipli <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Tobias Nießen <[email protected]> Reviewed-By: Ethan Arrowood <[email protected]>
Merged
UlisesGascon pushed a commit that referenced this pull request Dec 13, 2023
PR-URL: #50467 Reviewed-By: Geoffrey Booth <[email protected]> Reviewed-By: Vinícius Lourenço Claro Cardoso <[email protected]> Reviewed-By: Yagiz Nizipli <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Tobias Nießen <[email protected]> Reviewed-By: Ethan Arrowood <[email protected]>
UlisesGascon pushed a commit that referenced this pull request Dec 15, 2023
PR-URL: #50467 Reviewed-By: Geoffrey Booth <[email protected]> Reviewed-By: Vinícius Lourenço Claro Cardoso <[email protected]> Reviewed-By: Yagiz Nizipli <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Tobias Nießen <[email protected]> Reviewed-By: Ethan Arrowood <[email protected]>
UlisesGascon pushed a commit that referenced this pull request Dec 19, 2023
PR-URL: #50467 Reviewed-By: Geoffrey Booth <[email protected]> Reviewed-By: Vinícius Lourenço Claro Cardoso <[email protected]> Reviewed-By: Yagiz Nizipli <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Tobias Nießen <[email protected]> Reviewed-By: Ethan Arrowood <[email protected]>
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment
11 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
@anonrig
@ljharb
I got the PR comment, that we should use primordials for userAgent by ljharb As that line was not touched by my PR I want to mark it as resolved, but not lose the information. So here I provide the corresponding PR and resolve that remark in my PR ;)